Jira (PUP-8540) Type checking fails when a sensitive parameter is autoloaded from hiera (no automatic conversion)

2018-03-10 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren assigned an issue to Henrik Lindberg  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8540  
 
 
  Type checking fails when a sensitive parameter is autoloaded from hiera (no automatic conversion)   
 

  
 
 
 
 

 
Change By: 
 Thomas Hallgren  
 
 
Assignee: 
 Thomas Hallgren Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8540) Type checking fails when a sensitive parameter is autoloaded from hiera (no automatic conversion)

2018-03-10 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren commented on  PUP-8540  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Type checking fails when a sensitive parameter is autoloaded from hiera (no automatic conversion)   
 

  
 
 
 
 

 
 I think this will be resolved by Henrik Lindberg's recent work on PUP-7675.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8540) Type checking fails when a sensitive parameter is autoloaded from hiera (no automatic conversion)

2018-03-10 Thread Jacob Henner (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jacob Henner created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8540  
 
 
  Type checking fails when a sensitive parameter is autoloaded from hiera (no automatic conversion)   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 PUP 5.4.0  
 
 
Assignee: 
 Thomas Hallgren  
 
 
Components: 
 Hiera & Lookup  
 
 
Created: 
 2018/03/10 11:13 AM  
 
 
Labels: 
 hiera Hiera  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Jacob Henner  
 

  
 
 
 
 

 
 Puppet Version: 5.4.0 Puppet Server Version: N/A OS Name/Version: CentOS 7 When a class parameter is set to use the sensitive type, automatic class parameter lookup fails with a type checking error. Desired Behavior: The value stored in hiera should be automatically validated against the datatype specified within Sensitive[], or not type-validated if the inner type was not specified. Actual Behavior: Error: Evaluation Error: Error while evaluating a Function Call, Class[Cntlm]: parameter 'cntlm_password' expects a value of type Undef or Sensitive[String], got String (file: /tmp/modules/cntlm/examples/init.pp, line: 2, column: 5) on node localhost.localdomain Workaround: Remove the value as a class parameter, and use Sensitive(lookup()) within the body of the class.  
 

  
 
 
 
 

 
 
   

Jira (PUP-8500) puppet lookup cli should support adding facts as arguments, not just from a file.

2018-03-10 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren commented on  PUP-8500  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet lookup cli should support adding facts as arguments, not just from a file.   
 

  
 
 
 
 

 
 That can be achieved by allowing more than one --facts option and then process each file in order and merge their content so that last one wins. Overrides can then be added from the command-line by letting the argument to the last one be a dash.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8513) Cannot add a resource parameter, when a default resource declaration already defines this param

2018-03-10 Thread Peter Meier (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Peter Meier assigned an issue to Henrik Lindberg  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8513  
 
 
  Cannot add a resource parameter, when a default resource declaration already defines this param   
 

  
 
 
 
 

 
Change By: 
 Peter Meier  
 
 
Assignee: 
 Peter Meier Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8513) Cannot add a resource parameter, when a default resource declaration already defines this param

2018-03-10 Thread Peter Meier (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Peter Meier commented on  PUP-8513  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cannot add a resource parameter, when a default resource declaration already defines this param   
 

  
 
 
 
 

 
 I can't say whether it ever worked, because it was new code I added that failed. But I have similar code patterns that are working for a long time and still work. But it was likely the first time I added such a piece of code with a resource default _expression_ setting the particular param in site.pp. 

The override of the resource occurs outside the scope of the containing class of the resource (and is also not within a scope that inherits from the declaring class.
 I don't understand why you are saying that the override of the resource occurs outside the scope of the containing class. There is only one class and except for the resource default both param declaration are within the same class.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8500) puppet lookup cli should support adding facts as arguments, not just from a file.

2018-03-10 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8500  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet lookup cli should support adding facts as arguments, not just from a file.   
 

  
 
 
 
 

 
 What if you want to use facts file and override one or a couple of facts? I can imagine that one of the typical facts files available for testing purposes (or one you obtained from an actual node) is used and you want to try out some custom additions.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8500) puppet lookup cli should support adding facts as arguments, not just from a file.

2018-03-10 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren commented on  PUP-8500  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet lookup cli should support adding facts as arguments, not just from a file.   
 

  
 
 
 
 

 
 An idea, wouldn't it be simpler if we allowed the facts to be read from stdin by using a dash as the name of the facts file? Your command would be similar to:  
 
 
 
 
 {code:java}/opt/puppetlabs/bin/puppet lookup site_domain --environment boo --facts - --node myhost.r00.zone1.foo.bar.com --node_terminus=plain --external_nodes=none <  
 
 
 boo: test  
 
 
 test: boo  
 
 
 asdfasd: 123  
 
 
 END
  
 
 
 
  Pros: 
 
No need to repeat an option 
Full YAML syntax available (arrays, hashes, etc.) 
Very minor adjustments needed in existing code. 
Can read facts using a pipe. 
 Cons: 
 
Added EOF tags. 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  

Jira (PUP-8493) The differences between the vendored semantic_puppet and the original make it impossible to swap in the original

2018-03-10 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren commented on  PUP-8493  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: The differences between the vendored semantic_puppet and the original make it impossible to swap in the original   
 

  
 
 
 
 

 
 Josh Cooper, yes. I think that would be the right thing to do.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.