Jira (PUP-10890) empty lookup_options

2021-02-06 Thread Chris Denneen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Chris Denneen commented on  PUP-10890  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: empty lookup_options   
 

  
 
 
 
 

 
 @Josh Cooper the issue is seen when the module has empty hash (I had the old keys actually commented out) and you run a “pdk test unit”. Should be pretty straight forward to reproduce?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.135095.1612614960030%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-02-06 Thread Henrik Lindberg (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-10890  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: empty lookup_options   
 

  
 
 
 
 

 
 line 288 is weird with two trailing unless - I think it errors as it should if value is neither nil nor a hash. Then it returns options as is if modulename is not given. Then it will fail if options are nil on line 292. The correct thing is probably to change line 293 to read:   
 
 
 
 
 return options if module_name.nil? || options.nil?
  
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.135094.1612612980050%40Atlassian.JIRA.