Jira (PUP-10942) Listing environments during code deploys can prevent environment cache invalidation
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10942 Listing environments during code deploys can prevent environment cache invalidation Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Catalog compilations for a newly created environment directory could fail if the environment was listed while the directory and its contents were being created. This issue only occurred when using an environment_timeout value greater than 0 and less than unlimited. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.388981.1614289885000.160586.1615265280032%40Atlassian.JIRA.
Jira (PUP-10942) Listing environments during code deploys can prevent environment cache invalidation
Title: Message Title Josh Cooper commented on PUP-10942 Re: Listing environments during code deploys can prevent environment cache invalidation Merged to 6.x in https://github.com/puppetlabs/puppet/commit/8ea8c456810c602b85c7c8f7ac7354f9aa9b Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.388981.1614289885000.160584.1615264740037%40Atlassian.JIRA.
Jira (PUP-10943) Windows package provider continues to read DisplayVersion key after embedded NULL
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10943 Windows package provider continues to read DisplayVersion key after embedded NULL Change By: Josh Cooper Fix Version/s: PUP 6.22.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.388985.1614292739000.160573.161526353%40Atlassian.JIRA.
Jira (PUP-10943) Windows package provider continues to read DisplayVersion key after embedded NULL
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10943 Windows package provider continues to read DisplayVersion key after embedded NULL Change By: Josh Cooper Fix Version/s: PUP 7.5.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.388985.1614292739000.160574.1615263000112%40Atlassian.JIRA.
Jira (FACT-1628) Set of breaking changes staged for facter 5
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Facter / FACT-1628 Set of breaking changes staged for facter 5 Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.191533.1495038377000.160523.1615262220235%40Atlassian.JIRA.
Jira (FACT-1628) Set of breaking changes staged for facter 5
Title: Message Title Josh Cooper assigned an issue to Unassigned Facter / FACT-1628 Set of breaking changes staged for facter 5 Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.191533.1495038377000.160526.1615262220371%40Atlassian.JIRA.
Jira (FACT-1628) Set of breaking changes staged for facter 5
Title: Message Title Josh Cooper updated an issue Facter / FACT-1628 Set of breaking changes staged for facter 5 Change By: Josh Cooper Fix Version/s: FACT 4.0.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.191533.1495038377000.160522.1615262220190%40Atlassian.JIRA.
Jira (FACT-1628) Set of breaking changes staged for facter 5
Title: Message Title Josh Cooper updated an issue Facter / FACT-1628 Set of breaking changes staged for facter 5 Change By: Josh Cooper Epic Name: Facter 4 5 .x breaking changes Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.191533.1495038377000.160525.1615262220323%40Atlassian.JIRA.
Jira (FACT-1628) Set of breaking changes staged for facter 5
Title: Message Title Josh Cooper updated an issue Facter / FACT-1628 Set of breaking changes staged for facter 5 Change By: Josh Cooper Team/s: Platform OS Night's Watch Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.191533.1495038377000.160524.1615262220279%40Atlassian.JIRA.
Jira (FACT-1628) Set of breaking changes staged for facter 5
Title: Message Title Josh Cooper updated an issue Facter / FACT-1628 Set of breaking changes staged for facter 5 Change By: Josh Cooper Summary: Set of breaking changes staged for facter 4 5 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.191533.1495038377000.160519.1615262160125%40Atlassian.JIRA.
Jira (PUP-10945) Change the master -> server in Server used http code
Title: Message Title Molly Waggett updated an issue Puppet / PUP-10945 Change the master -> server in Server used http code Change By: Molly Waggett Epic Link: SERVER-2864 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389566.1614715872000.160490.1615258560040%40Atlassian.JIRA.
Jira (FACT-2958) Fact names with dots shouldn't be converted to structured facts
Title: Message Title
Josh Cooper commented on FACT-2958
Re: Fact names with dots shouldn't be converted to structured facts
As with many things in puppet, the issue of dotted fact names has a long, long history... The VRA plugin makes use of dots in fact names, see https://github.com/puppetlabs/puppetlabs-stdlib/blob/a26d0c59cee2b946893d436c74c35b83cd47ee3c/lib/puppet/functions/fact.rb#L17. Confirmed this with Reid Vandewiele. Facts are added as variables to puppet's topscope, eg:
$ puppet apply -e 'notice($osfamily)'
Notice: Scope(Class[main]): RedHat
$ puppet apply -e 'notice($os)'
Notice: Scope(Class[main]): {architecture => x86_64, family => RedHat, hardware => x86_64, name => RedHat, release => {full => 7.2, major => 7, minor => 2}, selinux => {enabled => false}}
However, puppet variables may not contain dots https://puppet.com/docs/puppet/7.4/lang_reserved.html#variable-names, so trying to access $os.family won't work. This is because in the puppet language, dot is a method call, see https://puppet.com/docs/puppet/7.4/lang_facts_accessing.html
Because of ambiguity with function invocation, the dot-separated access syntax that is available in Facter commands is not available with the $facts hash access syntax.
To access structured facts in 6.x, you can use the builtin get function (which supersedes the fact function in stdlib). Since "foo.bar" is not structured in 6, the result is nil
[root@arabic-ideology ~]# puppet apply -e 'notice($facts.get("os.family"))'
Notice: Scope(Class[main]): RedHat
Jira (FACT-2958) Fact names with dots shouldn't be converted to structured facts
Title: Message Title
Josh Cooper updated an issue
Facter / FACT-2958
Fact names with dots shouldn't be converted to structured facts
Change By:
Josh Cooper
In Facter 3, dots are legal characters in fact names, so "a.b" is a valid fact name. The fact can then be used in a puppet manifest using {{$facts['a.b']}}.In Facter 4, dots in custom and external facts cause the fact to be converted to a structured fact. This breaks any puppet code that tries to resolve the fact:For example, given custom and executable external facts:{noformat}mkdir -p /etc/facter/facts.d/cat < /etc/facter/facts.d/dot.sh#!/bin/shecho exe.bar=bazENDchmod u+x /etc/facter/facts.d/dot.shmkdir -p /opt/puppetlabs/puppet/cache/lib/factercat < /opt/puppetlabs/puppet/cache/lib/facter/dot.rbFacter.add('foo.bar') do setcode { 'baz' }endEND{noformat}In 6.x, we can lookup the fact using its dotted name:{noformat}[root@beige-dread ~]# puppet apply -e 'notice($facts["exe.bar"])'Notice: Scope(Class[main]): baz[root@beige-dread ~]# puppet apply -e 'notice($facts["foo.bar"])'Notice: Scope(Class[main]): baz{noformat}In 7.x, the facts cannot be resolved:{noformat}root@debatable-swing ~]# puppet apply -e 'notice($facts["foo.bar"])'Notice: Scope(Class[main]):[root@debatable-swing ~]# puppet apply -e 'notice($facts["exe.bar"])'Notice: Scope(Class[main]):{noformat}Instead you have to access it as a structured fact explicitly or dig for the value:{noformat}[root@debatable-swing ~]# puppet apply -e 'notice($facts["exe"]["bar"])'Notice: Scope(Class[main]): baz[root@debatable-swing ~]# puppet apply -e 'notice($facts["foo"]["bar"])'Notice: Scope(Class[main]): baz{noformat}I am thinking Facter 4's {{Facter.add}} method shouldn't convert facts to structured by default when the name contains dots. - Perhaps allow an option to specify it's defining a structured fact, such as {{Facter.add("a.b", structured: true) do .. end}} - About external facts, it seems like we already have ways of providing structured facts as YAML or JSON so I'm not sure there is much benefit to converting key-value pairs into structured facts, such as {{my_org.my_group.my_fact1 = fact1_value}}
Add Comment
Jira (PUP-10955) Environment caches string and symbol environment names differently
Title: Message Title Josh Cooper created an issue Puppet / PUP-10955 Environment caches string and symbol environment names differently Issue Type: Bug Assignee: Unassigned Created: 2021/03/08 12:41 PM Priority: Normal Reporter: Josh Cooper The Puppet::Environments::Cached#get method says it accepts Strings or Symbols, but it doesn't normalize the name when getting/setting the environment in the cache. So you can end up caching environments for "production" and :production. Agent side we lookup the environment based on the Puppet[:environment] setting. Server side we lookup the environment from a query parameter. But there are other entry points like Bolt and non-indirected REST APIs, so it would be good to fix this. require 'puppet' Puppet.initialize_settings Puppet::Util::Log.newdestination(:console) Puppet::ApplicationSupport.push_application_context(Puppet::Util::RunMode[:user]) envs = Puppet.lookup(:environments)
Jira (PDB-5000) Triage SEC-274 for PuppetDB and PE-PuppetDB
Title: Message Title Austin Blatt updated an issue PuppetDB / PDB-5000 Triage SEC-274 for PuppetDB and PE-PuppetDB Change By: Austin Blatt Security: Internal Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383812.1611166106000.159969.1615228320037%40Atlassian.JIRA.
Jira (PUP-10950) unless should support sensitive data for any type
Title: Message Title Josh Cooper commented on PUP-10950 Re: unless should support sensitive data for any type Hi Sheena Tharakanparampil, puppet will automatically redact sensitive properties, because there are well-defined methods for printing the current state (is_to_s) and desired state (should_to_s), and those methods will redact sensitive properties automatically. However, puppet doesn't know how parameters will be handled in a custom type/provider. If a Sensitive value is passed to a parameter and the parameter hasn't explicitly said it accept sensitive values, then we err on the side of caution and raise an error. The recommended way of fixing this is to override the set_sensitive_parameters method and mark the parameter as sensitive. It's the module's way of saying "I'm taking ownership of this sensitive data". For example: https://github.com/puppetlabs/puppet/commit/abd866a648a32d3895011d25af5d4b3d994669c8#diff-7b346a4c9ed8ffeefe92b019c36ca30c8e3cf1cbfef09fc45485df64075adcc0R607-R614 Alternatively, call the sensitive DSL method like the user's password logonpassword parameter: https://github.com/puppetlabs/puppet/blob/12401c3af42cfbae41b48621f5b42336db1ace1d/lib/puppet/type/service.rb#L180. This option requires puppet 6 or greater that supports the sensitive DSL method. Trying to use that on older puppet versions will prevent the type from loading. We ran into that in the yumrepo_core module and had to go back to the older way of defining sensitive parameters https://github.com/puppetlabs/puppetlabs-yumrepo_core/pull/6 The issue can also be avoided by changing the parameter to a property. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10946) Recursive file resources generate dangerous numbers of resource events
Title: Message Title Nick Walker commented on PUP-10946 Re: Recursive file resources generate dangerous numbers of resource events We have a best practice recommendation around recursive file resources. https://github.com/puppetlabs/best-practices/blob/master/recursive-file-resources.md I wonder if we can move that more officially into the Puppet documentation and then beyond that if it would make sense to include something like this defined type more officially in Puppet as well or we could just mark it supported on the forge and point to it from the documentation. https://forge.puppet.com/modules/npwalker/recursive_file_permissions Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389668.1614728039000.159727.1615220040029%40Atlassian.JIRA.
Jira (FACT-2952) Facter 4 reports lsbmajdistrelease on Ubuntu differently than facter 3
Title: Message Title Dorin Pleava updated an issue Facter / FACT-2952 Facter 4 reports lsbmajdistrelease on Ubuntu differently than facter 3 Change By: Dorin Pleava Fix Version/s: FACT 4.0.52 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389552.161471215.159413.1615213620039%40Atlassian.JIRA.
Jira (FACT-2950) Root of structured core facts cannot be overriden by a custom fact
Title: Message Title Dorin Pleava updated an issue Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact Change By: Dorin Pleava Fix Version/s: FACT 4.0.52 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389257.1614583384000.159324.1615210080140%40Atlassian.JIRA.
Jira (FACT-1383) Azure Instance Metadata
Title: Message Title Dorin Pleava updated an issue Facter / FACT-1383 Azure Instance Metadata Change By: Dorin Pleava Fix Version/s: FACT 4.0.52 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.125281.1459963292000.159318.1615209420033%40Atlassian.JIRA.
Jira (FACT-2958) Fact names with dots shouldn't be converted to structured facts
Title: Message Title
Bogdan Irimie commented on FACT-2958
Re: Fact names with dots shouldn't be converted to structured facts
➜ facter git:(main) ✗ cat /Users/bogdan.irimie/projects/facter/custom_facts/my_custom_fact.rb
# frozen_string_literal: true
Facter.add('foo.bar') do
setcode { 'baz' }
end
2.6.3 :001 > require 'facter'
=> true
2.6.3 :002 > Facter.version
=> "4.0.52"
2.6.3 :003 > Facter.search('/Users/bogdan.irimie/projects/facter/custom_facts')
=> nil
2.6.3 :004 > Facter.value('foo.bar')
Jira (HI-621) Need some help of call same hiera variable from multiple hiera files
Title: Message Title Henrik Lindberg commented on HI-621 Re: Need some help of call same hiera variable from multiple hiera files Have you tried using Google? (Search for puppet community slack for example) Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389949.1614876617000.159109.1615195020031%40Atlassian.JIRA.
Jira (FACT-2951) Facter 3 bad network for VirtualBox or VPN network interfaces
Title: Message Title Claire Cadman commented on FACT-2951 Re: Facter 3 bad network for VirtualBox or VPN network interfaces I've added this as a known issue: https://puppet.com/docs/puppet/6.21/facter-known-issues.html Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389260.1614594854000.159102.1615191720034%40Atlassian.JIRA.
