Jira (PUP-11717) Can't "dig" into facts when legacy facts are excluded
Title: Message Title
Josh Cooper commented on PUP-11717
Re: Can't "dig" into facts when legacy facts are excluded
Looks like it's ok:
❯ bx puppet --version
7.21.0
❯ bx puppet apply -e 'notice(fact("ruby.version"))' --no-include_legacy_facts
Notice: Scope(Class[main]): 2.7.6
Notice: Compiled catalog for localhost in environment production in 0.01 seconds
Notice: Applied catalog in 0.04 seconds
The dig function is a little unique in that it requires a Collection parameter, so it triggers the issue. I'm not sure how many user function do that level of type checking, but I'm sure someone is.
Add Comment
Jira (PUP-11717) Can't "dig" into facts when legacy facts are excluded
Title: Message Title Ben Ford commented on PUP-11717 Re: Can't "dig" into facts when legacy facts are excluded The PR looks like it also protects fact() from breaking, but maybe worth a quick check. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479164.1673933795000.2430.1674088980029%40Atlassian.JIRA.
Jira (PUP-11717) Can't "dig" into facts when legacy facts are excluded
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479164.1673933795000.2424.1674085860031%40Atlassian.JIRA.
Jira (PDB-4688) Deprecation removals for PuppetDB 8
Title: Message Title Rob Browning assigned an issue to Rob Browning PuppetDB / PDB-4688 Deprecation removals for PuppetDB 8 Change By: Rob Browning Assignee: Rob Browning Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.356709.1587757722000.2364.1674072720028%40Atlassian.JIRA.
Jira (PUP-11717) Can't "dig" into facts when legacy facts are excluded
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded Change By: Josh Cooper Epic Link: PUP-11658 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479164.1673933795000.2318.1674069300196%40Atlassian.JIRA.
Jira (FACT-3179) Facter.resolve returns a subclass of Hash, not Hash
Title: Message Title Josh Cooper updated an issue Facter / FACT-3179 Facter.resolve returns a subclass of Hash, not Hash Change By: Josh Cooper Epic Link: PUP-11658 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479163.1673933582000.2317.1674069300141%40Atlassian.JIRA.
Jira (PDB-5560) Update PuppetDB terminus for Puppet 8/Ruby 3
Title: Message Title Justin Stoller commented on PDB-5560 Re: Update PuppetDB terminus for Puppet 8/Ruby 3 Adding a blocking relationship to the PUP ticket to drop PSON support as I think PDB's terminus is the last remaining important internal consumer of PSON. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.474929.1668708016000.2289.1674067560092%40Atlassian.JIRA.
Jira (PUP-11691) Provide setting to report non-versioned path to resource when using versioned dirs
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-11691 Provide setting to report non-versioned path to resource when using versioned dirs Change By: Morgan Rhodes Fix Version/s: 7.22.0 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477092.1671051703000.2286.1674067260024%40Atlassian.JIRA.
Jira (FACT-3170) Facter resolves facts multiple times when providers are confined based on facts, especially on Windows
Title: Message Title Morgan Rhodes updated an issue Facter / FACT-3170 Facter resolves facts multiple times when providers are confined based on facts, especially on Windows Change By: Morgan Rhodes Fix Version/s: FACT 4.3.0 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477181.1671137416000.2281.1674067140020%40Atlassian.JIRA.
Jira (FACT-3170) Facter resolves facts multiple times when providers are confined based on facts, especially on Windows
Title: Message Title Morgan Rhodes updated an issue Facter / FACT-3170 Facter resolves facts multiple times when providers are confined based on facts, especially on Windows Change By: Morgan Rhodes Story Points: 3 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477181.1671137416000.2280.1674067080078%40Atlassian.JIRA.
Jira (FACT-3170) Facter resolves facts multiple times when providers are confined based on facts, especially on Windows
Title: Message Title Morgan Rhodes updated an issue Facter / FACT-3170 Facter resolves facts multiple times when providers are confined based on facts, especially on Windows Change By: Morgan Rhodes Sprint: Phoenix 2023-02-01 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477181.1671137416000.2279.1674067080029%40Atlassian.JIRA.
Jira (FACT-3179) Facter.resolve returns a subclass of Hash, not Hash
Title: Message Title Morgan Rhodes updated an issue Facter / FACT-3179 Facter.resolve returns a subclass of Hash, not Hash Change By: Morgan Rhodes Sprint: Phoenix 2023-02-01 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479163.1673933582000.2247.1674066360134%40Atlassian.JIRA.
Jira (PUP-11717) Can't "dig" into facts when legacy facts are excluded
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded Change By: Morgan Rhodes Sprint: Phoenix 2023-02-01 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479164.1673933795000.2248.1674066360182%40Atlassian.JIRA.
Jira (PDB-5553) Remove foreign keys from report partitions
Title: Message Title Cas Donoghue updated an issue PuppetDB / PDB-5553 Remove foreign keys from report partitions Change By: Cas Donoghue Sprint: Skeletor 11/23/2022, Skeletor 12/07/2022, Skeletor 12/21/2022, Skeletor 01/18/2023 , Skeletor 02/01/2023 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472747.1666299762000.2241.1674066300047%40Atlassian.JIRA.
Jira (PDB-5554) Remove partitions in a non-world-blocking way
Title: Message Title Cas Donoghue updated an issue PuppetDB / PDB-5554 Remove partitions in a non-world-blocking way Change By: Cas Donoghue Sprint: Skeletor 11/09/2022, Skeletor 11/23/2022, Skeletor 12/07/2022, Skeletor 12/21/2022, Skeletor 01/18/2023 , Skeletor 02/01/2023 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472748.1666300333000.2242.1674066300114%40Atlassian.JIRA.
Jira (PDB-5567) Migrate PDB reports and resource_events inheritance based partitions to postgresql declarative partitions
Title: Message Title Cas Donoghue updated an issue PuppetDB / PDB-5567 Migrate PDB reports and resource_events inheritance based partitions to postgresql declarative partitions Change By: Cas Donoghue Sprint: Skeletor 12/07/2022, Skeletor 12/21/2022, Skeletor 01/18/2023 , Skeletor 02/01/2023 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.475715.1669757045000.2243.1674066300161%40Atlassian.JIRA.
Jira (PDB-5557) Enable drop-joins for subqueries
Title: Message Title Cas Donoghue updated an issue PuppetDB / PDB-5557 Enable drop-joins for subqueries Change By: Cas Donoghue Sprint: Skeletor 12/07/2022, Skeletor 12/21/2022, Skeletor 01/18/2023 , Skeletor 02/01/2023 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.473181.127979000.2244.1674066300210%40Atlassian.JIRA.
Jira (PDB-5560) Update PuppetDB terminus for Puppet 8/Ruby 3
Title: Message Title Cas Donoghue updated an issue PuppetDB / PDB-5560 Update PuppetDB terminus for Puppet 8/Ruby 3 Change By: Cas Donoghue Sprint: Skeletor 02/01/2023 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.474929.1668708016000.2240.1674066000410%40Atlassian.JIRA.
Jira (PDB-4688) Deprecation removals for PuppetDB 8
Title: Message Title Cas Donoghue updated an issue PuppetDB / PDB-4688 Deprecation removals for PuppetDB 8 Change By: Cas Donoghue Sprint: Skeletor 02/01/2023 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.356709.1587757722000.2239.1674066000361%40Atlassian.JIRA.
Jira (PUP-11689) Enable strict mode by default
Title: Message Title Morgan Rhodes updated an issue Puppet / PUP-11689 Enable strict mode by default Change By: Morgan Rhodes Sprint: Phoenix 2023-01-18 , Phoenix 2023-02-01 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.476842.1670862344000.2229.1674065340020%40Atlassian.JIRA.
Jira (PDB-5580) puppetlabs/puppetdb uses whitelist/blacklist rather than allow/deny
Title: Message Title Pat Riehecky created an issue PuppetDB / PDB-5580 puppetlabs/puppetdb uses whitelist/blacklist rather than allow/deny Issue Type: Bug Assignee: Unassigned Created: 2023/01/18 9:44 AM Priority: Normal Reporter: Pat Riehecky The official puppetlabs puppetdb module https://forge.puppet.com/modules/puppetlabs/puppetdb/ uses whitelist/blacklist rather than the new terminology. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Jira (PDB-5579) puppet module to install and configure puppetdb_cli
Title: Message Title Pat Riehecky created an issue PuppetDB / PDB-5579 puppet module to install and configure puppetdb_cli Issue Type: New Feature Assignee: Unassigned Created: 2023/01/18 9:25 AM Priority: Normal Reporter: Pat Riehecky The puppetdb_cli tools are handy for spot checking and quick queries. Having the official puppetdb module add this tool to the puppetdb server would be a great way for folks to test connectivity issues. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Jira (PUP-11719) ModuleDataProvider::validate_data_hash does not prune hash as advertised
Title: Message Title
Paul Gale created an issue
Puppet / PUP-11719
ModuleDataProvider::validate_data_hash does not prune hash as advertised
Issue Type:
Bug
Affects Versions:
PUP 7.20.0
Assignee:
Unassigned
Components:
Hiera & Lookup
Created:
2023/01/18 8:27 AM
Priority:
Normal
Reporter:
Paul Gale
Puppet Version: 7.20 Puppet Server Version: OS Name/Version: The function ModuleDataProvider::validate_data_hash is supposed to prune all hiera keys that are not prefixed with the configured module_name. It does not. Instead it returns the hash that it was called with unchanged. All pruning is done on a cloned version of the supplied hash that’s discarded. https://github.com/puppetlabs/puppet/blob/main/lib/puppet/pops/lookup/module_data_provider.rb#L46 Desired Behavior:
It should prune all hiera keys that are not prefixed with the configured module name.
It should include the name of any offending key(s) in the warning message that it prints. The warning message as currently implemented doesn't provide the developer with any meaningful actionable information.
https://github.com/puppetlabs/puppet/blob/main/lib/puppet/pops/lookup/module_data_provider.rb#L54 should be modified to be something like: Puppet.warning("Module '#{module_name}': #{msg}, key=#{k}") to help identify the offending key(s). Actual Behavior: Hiera keys not prefixed with the module name are not pruned from the supplied hash. No warning advising on the offending key(s) is printed. Fix: Delete this line and the pruned hash is returned:
Jira (FACT-3176) Facter long key breaks YAML formatter
Title: Message Title Tomas Barton commented on FACT-3176 Re: Facter long key breaks YAML formatter Sorry, mine fault, the yaml seems to be valid. I just haven't seen this syntax. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478605.1673529425000.1945.1674033120019%40Atlassian.JIRA.
