Jira (PDB-5613) Drop PSON or at least don't call it by default

2023-03-17 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5613  
 
 
  Drop PSON or at least don't call it by default   
 

  
 
 
 
 

 
Issue Type: 
  Task  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/03/17 2:36 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 See https://github.com/puppetlabs/puppet/wiki/Puppet-8-Compatibility#pson When we unvendor PSON, then it won't monkey patch core Ruby classes like Hash#to_pson. The terminus should be modified to call Hash#to_json instead. I'm not sure if we want to keep the PSON code paths in the terminus as a configurable option in case someone needs PSON for something and installs the puppet-pson gem in puppetserver/agent?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira 

Jira (PUP-11784) Running `puppet epp render` on a template fails subtemplates

2023-03-17 Thread Anthony Vitacco (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Anthony Vitacco updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11784  
 
 
  Running `puppet epp render` on a template fails subtemplates   
 

  
 
 
 
 

 
Change By: 
 Anthony Vitacco  
 

  
 
 
 
 

 
 *Puppet Version:* 7.23.0*Puppet Server Version:* N/A*OS Name/Version:* Arch LinuxWhen running {{puppet epp render template.epp}} against a template that contains an {{epp()}} call, puppet is unable to locate the sub-template.*Desired Behavior:*The template render to correctly locate the referenced templates.*Actual Behavior:*Running puppet epp render templates/main_template.hcl.epp yields the following output:{{Error: Evaluation Error: Error while evaluating a Function Call, Could not find template 'module/elements/sub_template.hcl.epp' (file: /home/user/Projects/puppet/module/templates/main_template.hcl.epp, line: 51, column: 5)}}{{Error: error while rendering epp}}{{Error: Try 'puppet help epp render' for usage}}   However, rendering the main_template in a file resource in a puppet module does work correctly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

Jira (PUP-11784) Running `puppet epp render` on a template fails subtemplates

2023-03-17 Thread Anthony Vitacco (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Anthony Vitacco created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11784  
 
 
  Running `puppet epp render` on a template fails subtemplates   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 PUP 7.23.0  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/03/17 10:31 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Anthony Vitacco  
 

  
 
 
 
 

 
 Puppet Version: 7.23.0 Puppet Server Version: N/A OS Name/Version: Arch Linux When running puppet epp render template.epp against a template that contains an epp() call, puppet is unable to locate the sub-template. Desired Behavior: The template render to correctly locate the referenced templates. Actual Behavior: Running puppet epp render templates/main_template.hcl.epp yields the following output: Error: Evaluation Error: Error while evaluating a Function Call, Could not find template 'module/elements/sub_template.hcl.epp' (file: /home/user/Projects/puppet/module/templates/main_template.hcl.epp, line: 51, column: 5) Error: error while rendering epp Error: Try 'puppet help epp render' for usage    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 
   

Jira (PUP-11119) Remove "extra" cli option

2023-03-17 Thread Michael Hashizume (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Hashizume assigned an issue to Michael Hashizume  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9  
 
 
  Remove "extra" cli option   
 

  
 
 
 
 

 
Change By: 
 Michael Hashizume  
 
 
Assignee: 
 Michael Hashizume  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.403600.1623857807000.1489.1679072940225%40Atlassian.JIRA.


Jira (PUP-10928) Puppet falls back to non-rich data if there is binary data in the catalog

2023-03-17 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-10928  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet falls back to non-rich data if there is binary data in the catalog   
 

  
 
 
 
 

 
 In Puppet 8, we are going to drop PSON, but make it possible to install a puppet pson gem, like we do for msgpack. This will prevent accidental downgrading to PSON. However, we may still want to add a setting to puppet 7.x to prevent downgrading.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.388074.1613713885000.1483.1679072820021%40Atlassian.JIRA.


Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-17 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11659  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483146.1679060554000.1471.1679072520088%40Atlassian.JIRA.


Jira (FACT-3165) facter --debug reports wrong location of a resolved fact.

2023-03-17 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3165  
 
 
  facter --debug reports wrong location of a resolved fact.   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11659  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.473610.1666921663000.1467.1679072160021%40Atlassian.JIRA.


Jira (PUP-11723) Revisit Concurrent::RubyThreadLocalVar

2023-03-17 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11723  
 
 
  Revisit Concurrent::RubyThreadLocalVar   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11659  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479493.1674511008000.1466.1679072100297%40Atlassian.JIRA.


Jira (PUP-11716) Require JRuby 9.4 and MRI 3.1

2023-03-17 Thread Tony Vu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu assigned an issue to Tony Vu  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11716  
 
 
  Require JRuby 9.4 and MRI 3.1   
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Assignee: 
 Tony Vu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.479162.1673918589000.1451.1679068800093%40Atlassian.JIRA.


Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-17 Thread Charmaine Pritchett (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Charmaine Pritchett updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
Change By: 
 Charmaine Pritchett  
 
 
Zendesk Ticket Count: 
 1  
 
 
Zendesk Ticket IDs: 
 51387  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.483146.1679060554000.1430.1679061300023%40Atlassian.JIRA.


Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-17 Thread Gavin Didrichsen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gavin Didrichsen updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
Change By: 
 Gavin Didrichsen  
 

  
 
 
 
 

 
 A customer is seeing some unexpected behaviours when using facter as follows: * Using``{*}-p-{*}`` and ``{*}-no-external-facts{*}`` together produces an error ``{*}ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one{*}`` and no facts are returned * Other variations of facter options fail to return the expected custom factI have been able to replicate what the customer is seeing on my lab of   {code}root@pe-server-238c28-1 development (development)$ facter --version  4.2.14root@pe-server-238c28-1 development (development)$   {code} More detail of my lab setup:  * I  have a custom fact defined on my PE, e.g., my environment containse the custom fact here *site-modules/bigbird/lib/facter/bigbird.rb* * I  can see my ``bigbird`` custom fact as expected: {code}root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p bigbird{  role => "role::replica",  sshkey => {    identifier => "pe-server-238c28-1.us-west1-b.c.customer-support-scratchpad.internal",    key => "LONGLONGLONGPUBLICKEY",    type => "ssh-rsa"  }}root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p | grep bigbirdbigbird => {root@pe-server-238c28-1 pe_curl_requests (development)$ {code}  * However, when I introduce other flags I see expected results: {code}# these workroot@pe-server-238c28-1 development (development)$ facter -p --json | grep -E "(oslogin|[^/]bigbird)"  "bigbird": {    "oslogin": {root@pe-server-238c28-1 development (development)$ facter -p bigbird --json | grep -E "(oslogin|[^/]bigbird)"  "bigbird": {root@pe-server-238c28-1 development (development)$ # these don't work# custom fact 'bigbird' is not returned unexpectedlyroot@pe-server-238c28-1 development (development)$ facter --json | grep -E "(oslogin|[^/]bigbird)"    "oslogin": {root@pe-server-238c28-1 development (development)$ # no facts returned AND an error is thrownroot@pe-server-238c28-1 development (development)$ facter -p --no-external-facts | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:08.334765 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$ facter -p --no-external-facts --json | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:15.077332 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$ facter -p bigbird --no-external-facts | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:21.438824 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$ facter -p bigbird --no-external-facts --json | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:28.317694 ] ERROR Facter::OptionsValidator - 

Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-17 Thread Gavin Didrichsen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gavin Didrichsen updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
Change By: 
 Gavin Didrichsen  
 

  
 
 
 
 

 
    * I can see my ``bigbird`` custom fact as expected:   {code}  root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p bigbird  { }}}{{{}{{}}}{{    role => "role::replica", }}{{{}    sshkey =>{ }}}{{{}{       identifier => "pe-server-238c28-1.us-west1-b.c.customer-support-scratchpad.internal",       key => "LONGLONGLONGPUBLICKEY",       type => "ssh-rsa"     } {}}}{{{}}{}}}  {{{ }  root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p | grep bigbird {}}}{{{}  bigbird => { {}}}{{{}  root@pe-server-238c28-1 pe_curl_requests (development)${ }}}{ code}    * However, when I introduce other flags I see expected results:   {code}   # these work  root@pe-server-238c28-1 development (development)$ facter -p --json | grep -E "(oslogin|[^/]bigbird)"    "bigbird": {      "oslogin": {  root@pe-server-238c28-1 development (development)$ facter -p bigbird --json | grep -E "(oslogin|[^/]bigbird)"    "bigbird": {  root@pe-server-238c28-1 development (development)$        # these don't work   # custom fact 'bigbird' is not returned unexpectedly  root@pe-server-238c28-1 development (development)$ facter --json | grep -E "(oslogin|[^/]bigbird)"      "oslogin": {  root@pe-server-238c28-1 development (development)$        # no facts returned AND an error is thrown  root@pe-server-238c28-1 development (development)$ facter -p --no-external-facts | grep -E "(oslogin|[^/]bigbird)"  [2023-03-17 13:28:08.334765 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one   root@pe-server-238c28-1 development (development)$ facter -p --no-external-facts --json | grep -E "(oslogin|[^/]bigbird)"  [2023-03-17 13:28:15.077332 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one   root@pe-server-238c28-1 development (development)$ facter -p bigbird --no-external-facts | grep -E "(oslogin|[^/]bigbird)"  [2023-03-17 13:28:21.438824 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one   root@pe-server-238c28-1 development (development)$ facter -p bigbird --no-external-facts --json | grep -E "(oslogin|[^/]bigbird)"  [2023-03-17 13:28:28.317694 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one   root@pe-server-238c28-1 development (development)$   {code}     
 

  
 
 
 
 

 
 
   

Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-17 Thread Gavin Didrichsen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gavin Didrichsen updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
Change By: 
 Gavin Didrichsen  
 

  
 
 
 
 

 
     * I can see my ``bigbird`` custom fact as expected:  ``` {code}   root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p bigbird  {  }}}{{{}{{}}}{{   role => "role::replica",  }}{{{}   sshkey => {  }}}{{{}{     identifier => "pe-server-238c28-1.us-west1-b.c.customer-support-scratchpad.internal",      key => "LONGLONGLONGPUBLICKEY",      type => "ssh-rsa"    }  { } }}{{{}}{}}}    {{{} root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p | grep bigbird  {}}}{{{} bigbird => {  {}}}{{{} root@pe-server-238c28-1 pe_curl_requests (development)$ {}}}  {code}  ```      * However, when I introduce other flags I see expected results:  ```bash {code}   # these workroot@pe-server-238c28-1 development (development)$ facter -p --json | grep -E "(oslogin|[^/]bigbird)"  "bigbird": {    "oslogin": {root@pe-server-238c28-1 development (development)$ facter -p bigbird --json | grep -E "(oslogin|[^/]bigbird)"  "bigbird": {root@pe-server-238c28-1 development (development)$     # these don't work# custom fact 'bigbird' is not returned unexpectedlyroot@pe-server-238c28-1 development (development)$ facter --json | grep -E "(oslogin|[^/]bigbird)"    "oslogin": {root@pe-server-238c28-1 development (development)$     # no facts returned AND an error is thrownroot@pe-server-238c28-1 development (development)$ facter -p --no-external-facts | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:08.334765 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$ facter -p --no-external-facts --json | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:15.077332 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$ facter -p bigbird --no-external-facts | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:21.438824 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$ facter -p bigbird --no-external-facts --json | grep -E "(oslogin|[^/]bigbird)"[2023-03-17 13:28:28.317694 ] ERROR Facter::OptionsValidator - no-external-facts and external-dir options conflict: please specify only one root@pe-server-238c28-1 development (development)$  {code}  ```      
 

  
 
 
 
 

 
 
   

Jira (FACT-3192) Custom fact fails to appear when using some options like --json

2023-03-17 Thread Gavin Didrichsen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gavin Didrichsen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3192  
 
 
  Custom fact fails to appear when using some options like --json   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/03/17 6:42 AM  
 
 
Labels: 
 jira_escalated  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Gavin Didrichsen  
 

  
 
 
 
 

 
     
 
I can see my ``bigbird`` custom fact as expected: 
   ``` root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p bigbird {   role => "role::replica",   sshkey =>  {     identifier => "pe-server-238c28-1.us-west1-b.c.customer-support-scratchpad.internal",     key => "LONGLONGLONGPUBLICKEY",     type => "ssh-rsa"   } }   root@pe-server-238c28-1 pe_curl_requests (development)$ facter -p | grep bigbird bigbird => { root@pe-server-238c28-1 pe_curl_requests (development)$ ```   
 
However, when I introduce other flags I see expected results: 
   ```bash 
 
these work 
 root@pe-server-238c28-1 development (development)$ facter -p --json | grep -E "(oslogin|[^/]bigbird)"   "bigbird": {     "oslogin": { root@pe-server-238c28-1 development (development)$ facter -p bigbird --json | grep -E "(oslogin|[^/]bigbird)"   "bigbird": { root@pe-server-238c28-1 development (development)$      
 
these don't work