Jira (FACT-3186) facter 4.2.13: bug "facter partitions"

2023-05-03 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3186  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: facter 4.2.13: bug "facter partitions"   
 

  
 
 
 
 

 
 Diana Scannicchio could you run this script and attach the output (scrubbed) Also can you describe how you're setting up the mountpoints and partitions?  
 
 
 
 
 require 'facter'  
 
 
 require 'pp'  
 
 
    
 
 
 pp Facter::Resolvers::Mountpoints.resolve(:mountpoints)
  
 
 
 
  Then run: /opt/puppetlabs/puppet/bin/ruby test.rb  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  

Jira (PDB-5643) PQL parsing of OR clauses can result in OOM errors

2023-05-03 Thread Joshua Partlow (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Joshua Partlow created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5643  
 
 
  PQL parsing of OR clauses can result in OOM errors   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 PDB 7.12.1  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/05/03 1:26 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Joshua Partlow  
 

  
 
 
 
 

 
 There seems to be enough inefficiency in instaparse such that large(ish) sets of OR clauses can eat up available memory. In a 2021.7.2 e2-custom-4-10240 GCP test instance with 1G allocated to puppetdb's heap, this query was enough to oom in ~3m:  
 
 
 
 
 reports {  
 
 
   latest_report? = true and (  
 
 
 certname = "foo22" or  
 
 
 certname = "foo21" or  
 
 
 certname = "foo20" or  
 
 

Jira (FACT-3199) facts with regular expression matching characters in the name of the fact cause facter 4 to crash

2023-05-03 Thread Patrick Grant (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Patrick Grant updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3199  
 
 
  facts with regular _expression_ matching characters in the name of the fact cause facter 4 to crash   
 

  
 
 
 
 

 
Change By: 
 Patrick Grant  
 

  
 
 
 
 

 
 Customer A customer  noticed this after the move from facter 3 to facter 4, using the following code,  i  I  have reproduced this locally: {code:java}Facter.add("hello(there") do  setcode do"greetings"  endend{code}Results in:{code:java}$ facter -pTraceback (most recent call last):31: from /opt/puppetlabs/puppet/bin/facter:10:in `'30: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/cli/cli_launcher.rb:23:in `start'29: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.2.1/lib/thor/base.rb:485:in `start'28: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'27: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'26: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'25: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/cli/cli.rb:124:in `query'24: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:454:in `to_user_output'23: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:521:in `resolve_facts_for_user_query'22: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact_manager.rb:24:in `resolve_facts'21: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:7:in `resolve_facts'20: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:19:in `external_facts'19: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:19:in `each'18: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:21:in `block in external_facts'17: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:127:in `value'16: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:177:in `searching'15: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:137:in `block in value'14: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:161:in `resolve_value'13: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:134:in `core_value'12: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact_manager.rb:67:in `resolve_core'11: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact_manager.rb:83:in `core_fact'10: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/parsers/query_parser.rb:31:in `parse' 9: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/parsers/query_parser.rb:31:in `each' 8: from 

Jira (FACT-3199) facts with regular expression matching characters in the name of the fact cause facter 4 to crash

2023-05-03 Thread Patrick Grant (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Patrick Grant updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3199  
 
 
  facts with regular _expression_ matching characters in the name of the fact cause facter 4 to crash   
 

  
 
 
 
 

 
Change By: 
 Patrick Grant  
 
 
Zendesk Ticket Count: 
 1  
 
 
Zendesk Ticket IDs: 
 51837  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.485170.1683128012000.10640.1683128100030%40Atlassian.JIRA.


Jira (FACT-3199) facts with regular expression matching characters in the name of the fact cause facter 4 to crash

2023-05-03 Thread Charmaine Pritchett (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Patrick Grant created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3199  
 
 
  facts with regular _expression_ matching characters in the name of the fact cause facter 4 to crash   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/05/03 8:33 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Patrick Grant  
 

  
 
 
 
 

 
 Customer noticed this after the move from facter 3 to facter 4, using the following code, i have reproduced this locally: * Please see Zendesk Support tab for further comments and attachments.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

   

Jira (FACT-3199) facts with regular expression matching characters in the name of the fact cause facter 4 to crash

2023-05-03 Thread Charmaine Pritchett (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Charmaine Pritchett updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3199  
 
 
  facts with regular _expression_ matching characters in the name of the fact cause facter 4 to crash   
 

  
 
 
 
 

 
Change By: 
 Charmaine Pritchett  
 
 
Labels: 
 jira_escalated  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.485170.1683128012000.10639.1683128040104%40Atlassian.JIRA.