Jira (FACT-3083) Add wwn and sn to disk fact

2021-11-11 Thread Boris (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3083  
 
 
  Add wwn and sn to disk fact   
 

  
 
 
 
 

 
Change By: 
 Boris  
 

  
 
 
 
 

 
 h2. What is changing?This PR adds WWN and SN to the disks fact.Because there is currently no reliable way to get the wwn and sn via file output, I fall back to the usage of lsblk.I manually tested this on centos7/8 and ubuntu 18/20.04I would like if people can help me to write a test for it.  [ https://github.com/puppetlabs/facter/pull/ 2297 2461] Edit: Updated the pull request URL  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.420812.163498016.4938.1636641840104%40Atlassian.JIRA.


Jira (FACT-3083) Add wwn and sn to disk fact

2021-10-23 Thread Boris (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3083  
 
 
  Add wwn and sn to disk fact   
 

  
 
 
 
 

 
Issue Type: 
  New Feature  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Community, Facter 4  
 
 
Created: 
 2021/10/23 2:09 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Boris  
 

  
 
 
 
 

 
 What is changing? This PR adds WWN and SN to the disks fact. Because there is currently no reliable way to get the wwn and sn via file output, I fall back to the usage of lsblk. I manually tested this on centos7/8 and ubuntu 18/20.04 I would like if people can help me to write a test for it.   https://github.com/puppetlabs/facter/pull/2297  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2020-08-25 Thread Boris (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Boris  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:java}  #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = "">  packages: {}}def parse_redhat  packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endendif osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debianendputs @data.to_json{code}    I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]  {quote} "@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?" {quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira 

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2020-08-25 Thread Boris (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Boris  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `opt/puppetlabs/facter/facts.d/` recurses into oblivion  {code:java} #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no- custom-fact --no- external-facts os.family).strip@data = "">  packages: {}}def parse_redhat  packagelist = %x(rpm -qa --qf '% \ {NAME};% \ {VERSION}-% \ {RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endendif osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debianendputs @data.to_json {code}  I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira 

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2020-08-25 Thread Boris (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2020/08/25 1:35 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Boris  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `opt/puppetlabs/facter/facts.d/` recurses into oblivion   #!/usr/bin/env ruby require 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-external-facts os.family).strip @data = ""> packages: {} }def parse_redhat packagelist = %x(rpm qa --qf '%{NAME};%{VERSION}%{RELEASE}\n').split("\n") packagelist.each do |package| pname = package.split(';').first version = package.split(';').last @data[:packages][pname] = version.strip end end def parse_debian packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n") packagelist.each do |package| pname = package.split(';').first version = package.split(';').last @data[:packages][pname] = version.strip end endif osfamily == 'RedHat' parse_redhat end if osfamily == 'Debian' parse_debian endputs @data.to_json   I created this ticket after I talked to the slack community puppet guy Josh (https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500) "@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"  
 

  
 
 
 
 

 
 
 

 
 
 

Jira (FACT-1888) 'os.release' values not correct for VZ7

2019-06-10 Thread Boris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris commented on  FACT-1888  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: 'os.release' values not correct for VZ7   
 

  
 
 
 
 

 
 Looks good. I would think that family should be rh and don’t miss package provider should be yum.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.278967.1538669961000.39640.1560174840918%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1888) 'os.release' values not correct for VZ7

2019-05-17 Thread Boris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris commented on  FACT-1888  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: 'os.release' values not correct for VZ7   
 

  
 
 
 
 

 
 Hi, will this get fixed someday? We really like to update our nodes to puppet6, because we really want to use the [Puppet Server: Intermediate CA|https://puppet.com/docs/puppetserver/6.3/intermediate_ca.html] and it looks like this is only supported for puppet6.   Cheers  Boris  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.278967.1538669961000.10396.1558079100178%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1888) 'os.release' values not correct for VZ7

2019-03-06 Thread Boris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris commented on  FACT-1888  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: 'os.release' values not correct for VZ7   
 

  
 
 
 
 

 
 We also stumbled across this issue. This issue results in other issues like: 
 
pip3 gets the default package provider 
templated repo files break because of os.release.major 
monitoring that is depending on these entries wont work 
 This issue breaks our whole automated infrastructure so we rolled back  to puppet5 with facter version 3.11.7 (commit efb78024806a461a4b0c46819979085362790520)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1909) facter os prints family linux when it's VirtuozzoLinux

2019-03-05 Thread Boris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris commented on  FACT-1909  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: facter os prints family linux when it's VirtuozzoLinux   
 

  
 
 
 
 

 
 It also looks like the default provider got set to pip3.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1909) facter os prints family linux when it's VirtuozzoLinux

2019-03-05 Thread Boris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1909  
 
 
  facter os prints family linux when it's VirtuozzoLinux   
 

  
 
 
 
 

 
Change By: 
 Boris  
 

  
 
 
 
 

 
 Hi,we are currently ongoing to migrate from Puppet5 to Puppet6 an ran into the issue that the os family is printed as "Linux" instead of "RedHat".I get why you changed os name, but why os family?   { { noformat} # facter os }} { {{}}  {{  architecture => "x86_64", }}  {{  family => "Linux", }}  {{  hardware => "x86_64", }}  {{  name => "VirtuozzoLinux", }}  {{  release => { }}  {{  full => "3.10.0-862.9.1.vz7.63.3", }}  {{  major => "3", }}  {{  minor => "10" }}  {{  }, }}  {{  selinux => { }}  {{  enabled => false }}  {{  } }}  } { { noformat } }}   Cheers Boris  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this 

Jira (FACT-1909) facter os prints family linux when it's VirtuozzoLinux

2019-03-05 Thread Boris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Boris created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1909  
 
 
  facter os prints family linux when it's VirtuozzoLinux   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 FACT 3.13.0  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2019/03/05 6:18 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Boris  
 

  
 
 
 
 

 
 Hi, we are currently ongoing to migrate from Puppet5 to Puppet6 an ran into the issue that the os family is printed as "Linux" instead of "RedHat". I get why you changed os name, but why os family?   # facter os {{{}} {{ architecture => "x86_64",}} {{ family => "Linux",}} {{ hardware => "x86_64",}} {{ name => "VirtuozzoLinux",}} {{ release => {}} {{ full => "3.10.0-862.9.1.vz7.63.3",}} {{ major => "3",}} {{ minor => "10"}} {{ },}} {{ selinux => {}} {{ enabled => false}} {{ }}} } Cheers  Boris  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment