Jira (FACT-1797) Amazon EC2 C5 Instances not detected as is_virtual causing ec2_metadata fact data not to resolve
Title: Message Title Maksym Melnychok commented on FACT-1797 Re: Amazon EC2 C5 Instances not detected as is_virtual causing ec2_metadata fact data not to resolve is there a corresponding ticket for Linux? because linux c5 instances are also missing ec2_* facts. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Maksym Melnychok commented on PUP-6767 Re: Interpolation within Data Provider should respect strict variables setting I think the case is quite clear - it's actually the same case for which `strict_variables` setting itself was introduced. Single typo in variable name interpolated within data provider path can completely change the dataset catalog is working with when doing hiera lookups. Referring to inexistent puppet variables or facts yields an error. So do `hiera` and `lookup` functions when asked for a key that can't be looked-up and no explicit default value is provided. I don't see why should exception be made about interpolation. While backward compatibility is valid issue, introducing a breaking change that reliably generates an error in ambiguous situation is (in my opinion) one of the best ways to introduce such changes, and if this error points out previously unknown problematic code - that is a pure win without any drawbacks. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Maksym Melnychok created an issue Puppet / PUP-6767 Interpolation within Data Provider should respect strict variables setting Issue Type: Bug Affects Versions: PUP 4.5.3 Assignee: Unassigned Components: Breaking Change Created: 2016/09/30 11:48 PM Priority: Normal Reporter: Maksym Melnychok followup to this comment thread: https://github.com/Yelp/puppet/commit/087312f99e1e45733bec09f5a61f9fa7f1b70874#commitcomment-19242530 Add Comment
Jira (PUP-6408) Cache environment config for as long as environment
Title: Message Title Maksym Melnychok created an issue Puppet / PUP-6408 Cache environment config for as long as environment Issue Type: Improvement Assignee: Unassigned Components: Performance Created: 2016/06/15 1:29 AM Priority: Normal Reporter: Maksym Melnychok Environment config is not cached which generates unnecessary io during compilation phase. Add Comment This message was sent by Atlassian
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on PUP-3038 Re: Typemanager wastes CPU cycles with global scope defined types Kylo Ginsberg i've added some numbers to the pr: https://github.com/puppetlabs/puppet/pull/2952#issuecomment-71187343 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types Felix Frank it is related, but condition implemented here: https://github.com/puppetlabs/puppet/pull/2373/files#diff-6627686db762825631d8127e59483137R146 is too weak, any type defined in global scope will still have performance problems Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types what if defined type has the name of the module and is defined in init.pp? i'm not sure if that goes against best practices but even if it does - it shouldn't just silently hit people with huge performance degradation. having a warning against such use-case is an option but so is fixing the performance issue? Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title
Maksym Melnychok commented on an issue
Re: FileUtils implementation broke compare_stream
Adrien Thebo Joshua Partlow thanks for sorting this out!
Add Comment
Puppet / PUP-2946
FileUtils implementation broke compare_stream
{{FileUtils.compare_stream}} implementation in ruby 1.9.3 was doing something along the lines of {code:ruby} a = b = nil while something a = as.read size b = bs.read size return false if a != b end {code} {{FileUtils.compare_stream}} in 2.0 instead does this: {code:ruby} a = b = while some...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok created an issue Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Issue Type: Bug Assignee: Kylo Ginsberg Components: Client, Server Created: 08/Aug/14 5:32 AM Priority: Normal Reporter: Maksym Melnychok Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. Add Comment
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types no i haven't, i tested against 3.6.2. were there any related changes done to master? Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types relevant PRs: https://github.com/puppetlabs/puppet/pull/2951 https://github.com/puppetlabs/puppet/pull/2952 Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title
Maksym Melnychok commented on an issue
Re: FileUtils implementation broke compare_stream
Adrien Thebo i don't have windows machine to run specs, could you share spec output please?
Add Comment
Puppet / PUP-2946
FileUtils implementation broke compare_stream
{{FileUtils.compare_stream}} implementation in ruby 1.9.3 was doing something along the lines of {code:ruby} a = b = nil while something a = as.read size b = bs.read size return false if a != b end {code} {{FileUtils.compare_stream}} in 2.0 instead does this: {code:ruby} a = b = while some...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title
Maksym Melnychok commented on an issue
Re: FileUtils implementation broke compare_stream
code improvement pushed, thanks
Add Comment
Puppet / PUP-2946
FileUtils implementation broke compare_stream
{{FileUtils.compare_stream}} implementation in ruby 1.9.3 was doing something along the lines of {code:ruby} a = b = nil while something a = as.read size b = bs.read size return false if a != b end {code} {{FileUtils.compare_stream}} in 2.0 instead does this: {code:ruby} a = b = while some...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title
Maksym Melnychok created an issue
Puppet / PUP-2946
FileUtils implementation broke compare_stream
Issue Type:
Bug
Affects Versions:
3.6.2
Assignee:
Kylo Ginsberg
Components:
Client
Created:
17/Jul/14 7:37 AM
Priority:
Normal
Reporter:
Maksym Melnychok
FileUtils#compare_stream implementation in ruby 1.9.3 was doing something along the lines of
a = b = nil while something a = as.read size b = bs.read size return false if a != b end
FileUtils#compare_stream in 2.0 instead does this:
a = b = while something as.read size, a bs.read size, b return false if a != b end
which is a problem since default encoding for strings is UTF-8 and when `File#read` reads into UTF-8 string it remains UTF-8 but when `StringIO#read` reads into UTF-8 string it becomes encoding of StringIO source string, which is ASCII for FileBucket::File contents.
This leads to problems with backing up files and under certain conditions gives errors like:
Error: Could not back up /bin/whatever.pyc: Got passed new contents for sum {md5}
ca60cf7b168557fb8c34be106b8c4ae8
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title Maksym Melnychok commented on an issue Re: FileUtils implementation broke compare_stream PR here: https://github.com/puppetlabs/puppet/pull/2881 Add Comment Puppet / PUP-2946 FileUtils implementation broke compare_stream FileUtils#compare_stream implementation in ruby 1.9.3 was doing something along the lines of a = b = nil while something a = as.read size b = bs.read size return false if a != b end FileUtils#compare_stream in 2.0 instead does this: a = b = while something as.read size, a bs.rea... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title
Maksym Melnychok updated an issue
Puppet / PUP-2946
FileUtils implementation broke compare_stream
Change By:
Maksym Melnychok
{{ FileUtils # . compare_stream }} implementationinruby1.9.3wasdoingsomethingalongthelinesof {code:ruby} a=b=nilwhilesomethinga=as.readsizeb=bs.readsizereturnfalseifa!=bend {code} {{ FileUtils # . compare_stream }} in2.0insteaddoesthis: {code:ruby} a=b=whilesomethingas.readsize,abs.readsize,breturnfalseifa!=bend {code} whichisaproblemsincedefaultencodingforstringsisUTF-8andwhen ` {{ File#read ` }} readsintoUTF-8stringitremainsUTF-8butwhen ` {{ StringIO#read ` }} readsintoUTF-8stringitbecomesencodingofStringIOsourcestring,whichisASCIIfor {{ FileBucket::File }} contents.Thisleadstoproblemswithbackingupfilesandundercertainconditionsgiveserrorslike: {{ Error:Couldnotbackup/bin/whatever.pyc:Gotpassednewcontentsforsum{md5}ca60cf7b168557fb8c34be106b8c4ae8 }}
Add Comment
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title
Maksym Melnychok updated an issue
Puppet / PUP-2946
FileUtils implementation broke compare_stream
Change By:
Maksym Melnychok
{{FileUtils.compare_stream}}implementationinruby1.9.3wasdoingsomethingalongthelinesof{code:ruby}a=b=nilwhilesomethinga=as.readsizeb=bs.readsizereturnfalseifa!=bend{code}{{FileUtils.compare_stream}}in2.0insteaddoesthis:{code:ruby}a=b=whilesomethingas.readsize,abs.readsize,breturnfalseifa!=bend{code}whichisaproblemsincedefaultencodingforstringsisUTF-8andwhen{{File#read}}readsintoUTF-8stringitremainsUTF-8butwhen{{StringIO#read}}readsintoUTF-8stringitbecomesencodingofStringIOsourcestring,whichisASCIIfor{{FileBucket::File}}contents.Thisleadstoproblemswithbackingupfilesandundercertainconditionsgiveserrorslike:{{Error:Couldnotbackup/bin/whatever.pyc:Gotpassednewcontentsforsum \ {md5 \ }ca60cf7b168557fb8c34be106b8c4ae8}}
Add Comment
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
