Jira (PUP-3529) --genconfig generates deprecated settings
Title: Message Title Robert Hyerle created an issue Puppet / PUP-3529 --genconfig generates deprecated settings Issue Type: Bug Affects Versions: PUP 3.7.1 Assignee: Kylo Ginsberg Attachments: puppet.agent.out, puppet.conf Components: Client, Puppet Server Created: 24/Oct/14 2:20 AM Environment: Darwin 13.4.0, Ubuntu 14.04 Priority: Minor Reporter: Robert Hyerle Use of the --genconfig command line option generates several settings for options that have been deprecated (even the generated puppet.conf file notes in the comments that the option has been deprecated). Running puppet (server or client) then emits deprecation warnings. These generated option settings are not needed (the generated values are the defaults). Fix: comment out the generated settings. I.e. the --genconfig output should prepend each deprecated option
Jira (PUP-3531) --genconf generates options that are error prone to configure manually using defaults
Title: Message Title Robert Hyerle created an issue Puppet / PUP-3531 --genconf generates options that are error prone to configure manually using defaults Issue Type: Bug Affects Versions: PUP 3.7.1 Assignee: Kylo Ginsberg Attachments: client_yaml.grep, puppet.conf, vardir.grep Components: Client, Puppet Server Created: 24/Oct/14 3:01 AM Environment: Ubuntu 14.04, Darwin 13.4.0, all? Priority: Minor Reporter: Robert Hyerle The puppet configuration logic with its systems of defaults works fairly well. The scheme of important and safe to change options as explained on https://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.html is a good way to approach the multitude of possible settings. In particular, settings such server and vardir have potential impacts for many other settings because these root
Jira (PUP-3531) --genconf generates options that are error prone to configure manually using defaults
Title: Message Title Robert Hyerle updated an issue Puppet / PUP-3531 --genconf generates options that are error prone to configure manually using defaults Change By: Robert Hyerle Thepuppetconfigurationlogicwithitssystemsofdefaultsworksfairlywell.Theschemeofimportantandsafetochangeoptionsasexplainedonhttps://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.htmlisagoodwaytoapproachthemultitudeofpossiblesettings.Inparticular,settingssuchserverandvardirhavepotentialimpactsformanyothersettingsbecausetheserootsettingspropagatedownasdefaultsforothersettings.Itisimportanttopreservethispropagation/inheritanceandoverridethesubsequentoptionsonlywhentheydon'tfollowthedefaultrule.Otherwise,achangeatthetoplevelwillnotbepropagatedasexpected:inthebestcase,theadminwillhavetocarefullyandmanuallycheckalltheothersettingsinpuppet.conftoinsurecorrectbehavior.Notethatthegeneratedpuppet.conffileisverylong.Unfortunately,thegeneratedpuppet.conf*doesnot*followtheabovelogic:itexplicitlysetsseveraloptions(10's)tothedefaultvaluemeaningthatwhensomeonechangesahigherlevelsetting(e.g.vardirorserver),thedefaultsdonotpropagate.Oneexample:vardirisregularlyusedasadefaultstartingpointformanyotherdirectories(seetheattachedfilevardir.greptoseehowmanytimesitappearsinthegeneratedpuppet.conffile.However,changingitmay,ormaynot,changethesubsequentvalues(thegeneratedpuppet.conffileisinconsistentinthismanneraswell).Here,theclientyamldirsettingwouldnotbeimpacted(seeattachedclient_yaml.grep)asonemightexpect.Theadminneedstosearchthroughandfindeveryplacewherethingsshould(normally)change.Explicitoverridesshouldbejustthat:explicitandoverrides.Fix:--genconfoutputshouldnotexplicitlysetvaluesthathavereasonabledefaults.Thesepotentialsettingsshouldremainintheconffileascomments.E.g.theclient_yamlsettingshouldbecome:#Thedefaultvalueis'$vardir/client_yaml'.#clientyamldir=/var/lib/puppet/client_yaml Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-3531) --genconf generates options that are error prone to configure manually using defaults
Title: Message Title Robert Hyerle updated an issue Puppet / PUP-3531 --genconf generates options that are error prone to configure manually using defaults Change By: Robert Hyerle Thepuppetconfigurationlogicwithitssystemsofdefaultsworksfairlywell.Theschemeofimportantandsafetochangeoptionsasexplainedonhttps://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.htmlisagoodwaytoapproachthemultitudeofpossiblesettings.Inparticular,settingssuchserverandvardirhavepotentialimpactsformanyothersettingsbecausetheserootsettingspropagatedownasdefaultsforothersettings.Itisimportanttopreservethispropagation/inheritanceandoverridethesubsequentoptionsonlywhentheydon'tfollowthedefaultrule.Otherwise,achangeatthetoplevelwillnotbepropagatedasexpected:inthebestcase,theadminwillhavetocarefullyandmanuallycheckalltheothersettingsinpuppet.conftoinsurecorrectbehavior.Notethatthegeneratedpuppet.conffileisverylong.Unfortunately,thegeneratedpuppet.conf*doesnot*followtheabovelogic:itexplicitlysetsseveraloptions(10's)tothedefaultvaluemeaningthatwhensomeonechangesahigherlevelsetting(e.g.vardirorserver),thedefaultsdonotpropagate.Oneexample:vardirisregularlyusedasadefaultstartingpointformanyotherdirectories(seetheattachedfilevardir.greptoseehowmanytimesitappearsinthegeneratedpuppet.conffile.However,changingitmay -- , ormaynot -- , changethesubsequentvalues(thegeneratedpuppet.conffileisinconsistentinthismanneraswell).Here,theclientyamldirsettingwouldnotbeimpacted(seeattachedclient_yaml.grep)asonemightexpect.Theadminneedstosearchthroughandfindeveryplacewherethingsshould(normally)change.Explicitoverridesshouldbejustthat:explicitandoverrides.Fix:--genconfoutputshouldnotexplicitlysetvaluesthathavereasonabledefaults.Thesepotentialsettingsshouldremainintheconffileascomments.E.g.theclient_yamlsettingshouldbecome:#Thedefaultvalueis'$vardir/client_yaml'.#clientyamldir=/var/lib/puppet/client_yaml Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-3531) --genconf generates options that are error prone to configure manually using defaults
Title: Message Title Robert Hyerle updated an issue Puppet / PUP-3531 --genconf generates options that are error prone to configure manually using defaults Change By: Robert Hyerle Thepuppetconfigurationlogicwithitssystemsofdefaultsworksfairlywell.Theschemeofimportantandsafetochangeoptionsasexplainedonhttps://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.htmlisagoodwaytoapproachthemultitudeofpossiblesettings.Inparticular,settingssuchserverandvardirhavepotentialimpactsformanyothersettingsbecausetheserootsettingspropagatedownasdefaultsforothersettings.Itisimportanttopreservethispropagation/inheritanceandoverridethesubsequentoptionsonlywhentheydon'tfollowthedefaultrule.Otherwise,achangeatthetoplevelwillnotbepropagatedasexpected:inthebestcase,theadminwillhavetocarefullyandmanuallycheckalltheothersettingsinpuppet.conftoinsurecorrectbehavior.Notethatthegeneratedpuppet.conffileisverylong.Unfortunately,thegeneratedpuppet.conf*doesnot*followtheabovelogic:itexplicitlysetsseveraloptions(10's)tothedefaultvaluemeaningthatwhensomeonechangesahigherlevelsetting(e.g.vardirorserver),thedefaultsdonotpropagate.Oneexample:vardirisregularlyusedasadefaultstartingpointformanyotherdirectories(seetheattachedfilevardir.greptoseehowmanytimesitappearsinthegeneratedpuppet.conffile.However,changingitmay,ormaynot,changethesubsequentvalues(thegeneratedpuppet.conffileisinconsistentinthismanneraswell).Here,theclientyamldirsettingwouldnotbeimpacted(seeattachedclient_yaml.grep)asonemightexpect.Theadminneedstosearchthroughandfindeveryplacewherethingsshould(normally)change.Explicitoverridesshouldbejustthat:explicitandoverrides.Fix:--genconfoutputshouldnotexplicitlysetvaluesthathavereasonabledefaults.Thesepotentialsettingsshouldremainintheconffileascomments.E.g.theclient_yamlsettingshouldbecome: #Thedefaultvalueis'$vardir/client_yaml'.#clientyamldir=/var/lib/puppet/client_yaml Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
