Jira (PUP-7444) Regex match integer silently fails
Title: Message Title Tom De Vylder commented on PUP-7444 Re: Regex match integer silently fails Catalog Preview (or GH's Octocatalog) isn't something I've spent too much time looking into because . I usually rely heavily on rspec-puppet and/or Beaker mostly due to prior experience with both. They both have saved my hide countless times in the past for which I've very grateful. If I hadn't read about the regex change in the changelog I would have had a hard time figuring out why a particular test failed. Any new code I write does get data typed. I try to enforce this as much as possible, it's just not always feasible for old code. In the past I used stdlib validate_*() but that has been deprecated in recent versions. However I've just run into stdlib is_a today, so that should probably cover the edge cases where I can't data type the input for a variety of reasons beyond my control. Hadn't heard of puppet-debugger before. After a quick glance I hope to one day see a Puppet supported version of or alternative to this as part of the SDK. Definitely something to look into along with Catalog Preview! Changing the language isn't necessary nor is it expected. My sole request was to make some of the changes (more) visible to users. It's pretty clear now that in this case it's not as feasible as I'd have hoped it to be. Thank you for taking the time to explain it as clear as you have! I'll go ahead and close this ticket. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7444) Regex match integer silently fails
Title: Message Title Tom De Vylder commented on PUP-7444 Re: Regex match integer silently fails While I do agree with the points you made. I still think it would be beneficial for users to at least be informed why their code used to work but now no longer does. Being a consultant I run into profiles and other manifests like this all the time. Given Puppet DSL's target audience I wouldn't expect the majority of users to be able to write any such contortions not to mention know what a splat operator is. Nor should they have to if only they know what they're doing is wrong. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7444) Regex match integer silently fails
Title: Message Title
Tom De Vylder commented on PUP-7444
Re: Regex match integer silently fails
Referring to d): it's quite the contrary. It doesn't match at all if the input is Numeric or if it's not converted to a String.
Took me a while to find it but at least it's documented: https://docs.puppet.com/puppet/4.9/lang_updating_manifests.html#regular-expressions-against-non-strings
According to said documentation it shoud raise an error: "Matching a value that is not a string with a regular _expression_ now raises an error.". However it doesn't raise anything at all.
This fails silently and goes straight to default:
$some_id = 1
$json_file = $some_id ? {
/^1$|^2$|^3$|^4$|^5$|^8$|^9$|^10$|^14$/ => ${some_id}.json",
default => "fallback-b${some_id}.json"
}
Result: fallback-b1.json, user expected it to have been 1.json but should have raised an error instead.
Albeit very ugly this works fine:
$some_id = 1
$json_file = "${some_id}" ? {
Jira (PUP-7444) Regex match integer silently fails
Title: Message Title Tom De Vylder commented on PUP-7444 Re: Regex match integer silently fails I don't mind the current behaviour. It's just that when trying to match an integer without converting it to a string it should be more clear that it's never going to match anything at all. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7444) Regex match integer silently fails
Title: Message Title
Tom De Vylder created an issue
Puppet / PUP-7444
Regex match integer silently fails
Issue Type:
Bug
Assignee:
Unassigned
Created:
2017/04/12 2:47 AM
Environment:
Any AIO package with Ruby 2.x.
Priority:
Normal
Reporter:
Tom De Vylder
TL;DR
Please consider throwing a warning or error to raise awareness.
Long version
Please consider following snippet...
$json_file = $some_id ? {
/^1$|^2$|^3$|^4$|^5$|^8$|^9$|^10$|^14$/ => ${some_id}.json",
default => "fallback-b${some_id}.json"
Jira (PUP-7312) Confine systemd provider to /lib/systemd/system
Title: Message Title Tom De Vylder created an issue Puppet / PUP-7312 Confine systemd provider to /lib/systemd/system Issue Type: Bug Assignee: Unassigned Created: 2017/03/07 5:38 AM Priority: Normal Reporter: Tom De Vylder I've created a PR to allow systemd provider to work in a chrooted environment. /run/systemd/system does not exist when running Puppet in a chroot environment /lib/systemd/system is always available irregardless of the environment and is therefore a safe alternative https://github.com/puppetlabs/puppet/pull/5693 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (PUP-7273) Hiera 5: error unless data_hash is defined
Title: Message Title Tom De Vylder commented on PUP-7273 Re: Hiera 5: error unless data_hash is defined For sake of completeness in case anyone googling ends up here: the missing suffix was indeed what caused my config not to work as expected. I'll leave this ticket open for the bug as described by Henrik Lindberg. Thank you Henrik Lindberg and Thomas Hallgren! Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-557) Hiera 5: error unless data_hash is defined
Title: Message Title
Tom De Vylder updated an issue
Hiera / HI-557
Hiera 5: error unless data_hash is defined
Change By:
Tom De Vylder
Potential bug filed as requested by [~henrik.lindberg] on slack. Please consider following snippet:{code:java}---version: 5defaults: datadir: hieradata data_hash: yaml_datahierarchy: - name: 'Nodes'data_hash: yaml_datapath: "nodes/%{::trusted.certname}" - name: 'Common'data_hash: yaml_datapath: common.yaml{code}Unless "data_hash: yaml_data" is provided for each level I get the following error: " {code:java} Error while evaluating a Function Call, 'yaml_data' parameter 'options' expects size to be 1, got 0 " {code}
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (HI-557) Hiera 5:
Title: Message Title Tom De Vylder created an issue Hiera / HI-557 Hiera 5: Issue Type: Bug Assignee: Unassigned Created: 2017/02/27 2:23 AM Environment: # facter -p operatingsystem operatingsystemrelease operatingsystem => Ubuntu operatingsystemrelease => 16.04 # dpkg -l | grep -i puppetserver ii puppetserver 2.7.2-1puppetlabs1all Puppet Labs puppetserver
Jira (HI-557) Hiera 5: error unless data_hash is defined
Title: Message Title Tom De Vylder updated an issue Hiera / HI-557 Hiera 5: error unless data_hash is defined Change By: Tom De Vylder Summary: Hiera 5: error unless data_hash is defined Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-539) Hierarchies are being ignored
Title: Message Title
Tom De Vylder commented on HI-539
Re: Hierarchies are being ignored
The particular data I was testing with is stored in $ {environment}
/hieradata only. It shouldn't match in global Hiera nor in modules.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (HI-539) Hierarchies are being ignored
Title: Message Title Tom De Vylder commented on HI-539 Re: Hierarchies are being ignored Apparently it makes a rather big difference whether or not the value of "--node" is known to Puppet. I've been testing mostly with just 'node01' instead of an actual hostname because it's just way faster to run 'puppet lookup' than it is to have an agent run. And typing 'node01' requires less keystrokes than an actual hostname. Even though I wasn't using anything that matches $trusted.certname it still wouldn't find very generic data in f.i. hieradata/common.yaml. Whether or not the node is known to Puppet it should still match fall-back hierarchies. Or throw an error. So I think that part is a bug. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-539) Hierarchies are being ignored
Title: Message Title Tom De Vylder commented on HI-539 Re: Hierarchies are being ignored Individual environments in my case, it's indeed set to 'environment_data_provider = hiera'. I have a mix of old hiera_*() and lookup() functions thought the code. As long as I don't need anything other than common.yaml or nodes/$node.yaml things work just as expected. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-539) Hierarchies are being ignored
Title: Message Title Tom De Vylder created an issue Hiera / HI-539 Hierarchies are being ignored Issue Type: Bug Affects Versions: HI 3.2.1 Assignee: Unassigned Created: 2016/10/12 4:25 AM Environment: Ubuntu 16.04 Puppetserver 2.6.0 Puppet-agent 1.6.2 Priority: Normal Reporter: Tom De Vylder Please consider the snippets below. cat /etc/puppetlabs/code/environments/production/hiera.yaml --- version: 4
Jira (PUP-5655) Puppet master --compile does not hand over hiera() lookup value to local variables
Title: Message Title Tom De Vylder commented on PUP-5655 Re: Puppet master --compile does not hand over hiera() lookup value to local variables Hi Thomas Hallgren, thank you for looking into it. Apparently hiera-erbyaml was the cause. It must have slipped my mind that it wasn't disabled. Disabling that I no longer get the error. I'll have to look into that (dead) project and see if I can fix the issue. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5655) Puppet master --compile does not hand over hiera() lookup value to local variables
Title: Message Title
Tom De Vylder created an issue
Puppet / PUP-5655
Puppet master --compile does not hand over hiera() lookup value to local variables
Issue Type:
Bug
Affects Versions:
PUP 4.3.1, PUP 3.8.4
Assignee:
Unassigned
Created:
2016/01/06 8:29 AM
Priority:
Normal
Reporter:
Tom De Vylder
Please consider following snippets:
site.pp
$foo = hiera('classes')
notice($foo)
Jira (PUP-5650) $::hostname, $::fqdn not available when using puppet master compile
Title: Message Title Tom De Vylder commented on PUP-5650 Re: $::hostname, $::fqdn not available when using puppet master compile Finally managed to resolve this undocumented feature. For future reference and anyone who ends up here googling the same problem: The location to store (custom) facts for "puppet master compile" is $vardir/yaml/facts/$certname.yaml. The expected format is this: --- !ruby/object:Puppet::Node::Facts values: hostname: test01 fqdn: test01.example.org certname: test01 ipaddress: "172.0.0.1" Add Comment
Jira (PUP-5650) $::hostname, $::fqdn not available when using puppet master compile
Title: Message Title
Tom De Vylder created an issue
Puppet / PUP-5650
$::hostname, $::fqdn not available when using puppet master compile
Issue Type:
Bug
Affects Versions:
PUP 4.3.1, PUP 3.8.4
Assignee:
Unassigned
Created:
2016/01/05 5:13 AM
Environment:
puppet 3.8.4 puppet 4.3.1
Priority:
Normal
Reporter:
Tom De Vylder
Consider following snippet:
$ cat /etc/puppet/manifests/site.pp
notice("hostname: ${::hostname}")
Jira (PUP-5650) $::hostname, $::fqdn not available when using puppet master compile
Title: Message Title
Tom De Vylder updated an issue
Puppet / PUP-5650
$::hostname, $::fqdn not available when using puppet master compile
Change By:
Tom De Vylder
*Consider following snippet:*{code}$ cat /etc/puppet/manifests/site.ppnotice("hostname: ${::hostname}")notice("fqdn: ${::fqdn}") notice("certname: ${::certname}") $ puppet master \ --hiera_config /etc/puppet/hiera.yaml \ --manifest /etc/puppet/manifests/site.pp \ --modulepath /etc/puppet/modules \ --compile test01 --debug{code}*Output on Puppet 3.8.4:*{code}Info: Caching node for test01Notice: Scope(Class[main]): hostname:Notice: Scope(Class[main]): fqdn:Notice: Scope(Class[main]): certname:{code}*Output on Puppet 4.3.1*{code}Info: Caching node for test01Warning: Scope(Class[main]): Could not look up qualified variable '::hostname';Notice: Scope(Class[main]): hostname:Warning: Scope(Class[main]): Could not look up qualified variable '::fqdn';Notice: Scope(Class[main]): fqdn:Warning: Scope(Class[main]): Could not look up qualified variable '::certname';Notice: Scope(Class[main]): certname:{code}*Question:*According to "puppet help master" it uses facts contained in $vardir/yaml/ to compile the catalog. However custom facts (hostname, fqdn, ...) added to "~/.puppet/var/yaml/node/test01.yaml" are never used by "puppet master compile". Aftwards said file is cleared to default.What's the advised way to provide a number of facts to "puppet master compile"?
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups
Jira (PDB-881) Resources endpoint should include defined type resources
Title: Message Title Tom De Vylder created an issue PuppetDB / PDB-881 Resources endpoint should include defined type resources Issue Type: New Feature Assignee: Unassigned Created: 17/Sep/14 2:20 PM Labels: puppetdb Priority: Normal Reporter: Tom De Vylder Much like resources.txt (https://tickets.puppetlabs.com/browse/PUP-1102) PuppetDB's Resources endpoint should include defined type resources. If anyone would find the time to include this, that'd be great. Add Comment
Jira (PUP-1515) Invalid parameter provider for custom types/providers
Title: Message Title Tom De Vylder commented on an issue Re: Invalid parameter provider for custom types/providers I'm running into the same behavior with: 3.6.2-1puppetlabs1 3.6.1-1puppetlabs1 3.5.1-1puppetlabs1 (from apt.puppetlabs.com) ... using puppet apply on Puppetlabs' current Debian 7 Vagrant box (http://puppet-vagrant-boxes.puppetlabs.com/debian-73-x64-virtualbox-puppet.box). Add Comment Puppet / PUP-1515 Invalid parameter provider for custom types/providers In Puppet 3 I am getting an error on all definitions for custom types. It says Error 400 on SERVER: Invalid parameter provider Provider should be a given parameter for custom types because otherwise there is no way to specify which provider should be used with it. This is potentially a very major bug. Please let me know how I can help so you're ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails
