[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Melissa Stone.


Released in Puppet 3.4.0-rc1


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-100866

* Author: Nick Chappell
* Status: Closed
* Priority: High
* Assignee: Kylo Ginsberg
* Category: file
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows customer
* Branch: https://github.com/puppetlabs/puppet/pull/2087

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Melissa Stone.


Released in Puppet 3.4.0-rc1


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-100720

* Author: Nick Chappell
* Status: Closed
* Priority: High
* Assignee: Kylo Ginsberg
* Category: file
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows customer
* Branch: https://github.com/puppetlabs/puppet/pull/2087

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Melissa Stone.


Released in Puppet 3.4.0-rc1


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-100623

* Author: Nick Chappell
* Status: Closed
* Priority: High
* Assignee: Kylo Ginsberg
* Category: file
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows customer
* Branch: https://github.com/puppetlabs/puppet/pull/2087

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Melissa Stone.


Released in Puppet 3.4.0-rc1


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-100517

* Author: Nick Chappell
* Status: Closed
* Priority: High
* Assignee: Kylo Ginsberg
* Category: file
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows customer
* Branch: https://github.com/puppetlabs/puppet/pull/2087

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Melissa Stone.


Released in Puppet 3.4.0-rc1


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-100427

* Author: Nick Chappell
* Status: Closed
* Priority: High
* Assignee: Kylo Ginsberg
* Category: file
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows customer
* Branch: https://github.com/puppetlabs/puppet/pull/2087

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Josh Cooper.

Affected Puppet version set to 2.7.6

Commits merged in 
[653895b1](https://github.com/puppetlabs/puppet/commit/653895b13531e4dcffd1cef4cdba589382ff3a77),
 [2572d9b5](https://github.com/puppetlabs/puppet/commit/2572d9b5ad19d5) and 
[2de376a](https://github.com/puppetlabs/puppet/commit/2de376a).

These commits add a new file parameter, `source_permissions` for specifying how 
owner, group, and/or mode are applied to the file resource from its `source`. 
It applies to both local and remote file sources.

* The default is `use`, which is puppet's current behavior. This behavior is 
deprecated on windows and will be changed to `ignore` in a future release, e.g. 
Puppet 4.
* The value `use_when_creating` will only copy owner/group/mode when creating 
the file, but not when managing an existing file/dir
* The value `ignore` will prevent puppet from applying owner/group/mode from 
the source.



Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-100171

* Author: Nick Chappell
* Status: Merged - Pending Release
* Priority: High
* Assignee: Kylo Ginsberg
* Category: file
* Target version: 3.4.0
* Affected Puppet version: 2.7.6
* Keywords: windows customer
* Branch: https://github.com/puppetlabs/puppet/pull/2087

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Josh Cooper.

Priority changed from Normal to High

More discussion here 



Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-97690

* Author: Nick Chappell
* Status: Accepted
* Priority: High
* Assignee: Charlie Sharpsteen
* Category: file
* Target version: 
* Affected Puppet version: 
* Keywords: windows customer
* Branch: 

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Charlie Sharpsteen.

Keywords changed from windows to windows customer


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-88184

* Author: Nick Chappell
* Status: Accepted
* Priority: Normal
* Assignee: Charlie Sharpsteen
* Category: file
* Target version: 
* Affected Puppet version: 
* Keywords: windows customer
* Branch: 

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Charlie Sharpsteen.

Assignee set to Charlie Sharpsteen


Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-87343

* Author: Nick Chappell
* Status: Accepted
* Priority: Normal
* Assignee: Charlie Sharpsteen
* Category: file
* Target version: 
* Affected Puppet version: 
* Keywords: windows
* Branch: 

Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Josh Cooper.


This ticket resulted from the discussion on puppet-dev: 
. Also 
see discussion on #5240.

The current behavior breaks file inheritance, without any way to "not do that". 
But puppet windows agents behave the same as unix agents, and people may be 
relying on the current behavior, so we cannot change the behavior in a dot 
release.

I think we will need to add a puppet setting to control which file properties 
from copied from the remote file to the local one. On Unix, we currently copy 
owner, group and mode. On Windows, we copy mode, but only if the file is 
remote. 

>From the method `copy_source_values` in `lib/puppet/type/file/source.rb`:


if Puppet.features.microsoft_windows?
  next if [:owner, :group].include?(metadata_method) and !local?
end


Simply changing that to the following, will ensure puppet on windows never 
applies the owner, group, or mode from the source file.


if Puppet.features.microsoft_windows?
  next if [:owner, :group, :mode].include?(metadata_method)
end



Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-82672

Author: Nick Chappell
Status: Accepted
Priority: Normal
Assignee: 
Category: file
Target version: 
Affected Puppet version: 
Keywords: windows
Branch: 


Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[Puppet - Feature #18931] Don't set mode on existing Windows folders when none is specified

[tickets]

Issue #18931 has been updated by Nick Chappell.


Some more specific desired behaviors that may help:

Newly created folders: inherit perms of parent folder
Existing folder that has contents changed: perms should stay the same (inherit 
those of the parent folder)
New file created in existing folder: inherit folder perms
Existing file with changed content: inherit folder perms

Feature #18931: Don't set mode on existing Windows folders when none is 
specified 
https://projects.puppetlabs.com/issues/18931#change-82144

Author: Nick Chappell
Status: Accepted
Priority: Normal
Assignee: 
Category: file
Target version: 
Affected Puppet version: 
Keywords: windows
Branch: 


Current behavior: If a folder resource is declared with a source => parameter 
but no mode specified, the mode of the source folder on the master is applied 
to it.

On Windows, this means that the mode is converted from POSIX to an equivalent 
set of Windows file permissions, which can break existing ACLs and inheritance.

Desired behavior: If a folder already exists on the node and is merely having 
files placed in it by Puppet, the mode shouldn't be changed if none is 
specified in the manifest.

A more complete solution would be the ability to specify NTFS ACLs directly, 
but this should alleviate problems caused by unexpected behavior in the mean 
time.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.