Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title David Kramer updated an issue Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Change By: David Kramer Team: Direct Change Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title David Kramer assigned an issue to David Kramer Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Change By: David Kramer Assignee: David Kramer Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title David Kramer updated an issue Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Change By: David Kramer Sub-team: Bolt Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title Henrik Lindberg commented on BOLT-396 Re: Plans should return undef without an explicit return To do this Puppet needs to be modified - the puppet_plan_instantiator.rb needs to change so that it creates a subtype of Puppet::Pops::Functions::Function that performs the return of nil in its call method as the result of an "end of block" result. Creating a Function here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/loader/puppet_plan_instantiator.rb#L73-L81 Function being called here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/functions/function.rb#L45-L48 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Change By: Alex Dreyer Since we can log intermediate results and error on failure returning the entirety of the last line often clutters and obscures meaningful output. Some users have reported returning static strings to prevent this. Plans that called from other plans may expose an unintentional and unstable API due to this as well.Solution:The result of a plan should be undef unless there is an explicit return statement in the plan.Questions:Is it useful in simple plans to return the last value? No, simple plans can rely on logging and default error handling. Is this too much of a differentiation from puppet functions? No, Plans are not functions and are usually run for side effects whereas functions are usually run for their return value in the plan language . Making this difference explicit makes it's clearer to users when to write a sub-plan vs a dsl function. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Change By: Alex Dreyer Sprint: Bolt Ready for Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Change By: Alex Dreyer Since we can log intermediate results and error on failure returning the entirety of the last line often clutters and obscures meaningful output. Some users have reported returning static strings to prevent this. Plans that called from other plans may expose an unintentional and unstable API due to this as well.Solution:The result of a plan should be undef unless there is an explicit return statement in the plan. Questions:Is it useful in simple plans to return the last value? No, simple plans can rely on logging and default error handling.Is this too much of a differentiation from puppet functions? No, Plans are not functions and are usually run for side effects. Making this difference explicit makes it's clearer to users when to write a sub-plan vs a dsl function. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You
Jira (BOLT-396) Plans should return undef without an explicit return
Title: Message Title Alex Dreyer created an issue Puppet Task Runner / BOLT-396 Plans should return undef without an explicit return Issue Type: New Feature Assignee: Unassigned Created: 2018/03/20 8:32 AM Priority: Normal Reporter: Alex Dreyer Since we can log intermediate results and error on failure returning the entirety of the last line often clutters and obscures meaningful output. Some users have reported returning static strings to prevent this. Plans that called from other plans may expose an unintentional and unstable API due to this as well. Solution: The result of a plan should be undef unless there is an explicit return statement in the plan. Add Comment This message was sent by
