Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Hailee Kenney assigned an issue to qa Facter / FACT- deprecation of 'facter --puppet' removes critically necessary functionality Change By: Hailee Kenney Status: Readyfor CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Also failed CI on Windows Server 2003. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality This was incorrectly put into master instead of stable, wait on verifying until I cherry-pick up to stable. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith assigned an issue to Michael Smith Facter / FACT- deprecation of 'facter --puppet' removes critically necessary functionality Change By: Michael Smith Assignee: MichaelSmith Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title
Michael Smith updated an issue
Facter / FACT-
deprecation of 'facter --puppet' removes critically necessary functionality
Change By:
Michael Smith
SowhileIunderstandthegoalbehindFACT-96.there'sasignificantlossoffunctionalitythere.Iseenomethodofretrievingasinglevalue,whichisveryhighlyusedwithinexternalscriptswhichmakeuseofpuppetplugin-syncedfacts.{code}$factersystem_uptime{seconds=532,hours=0,days=0,uptime=0:08hours}{code}Noteinthiscontext,justfrommypersonalsourcearchivesIfoundmorethan1000usesofthisexactfunctionality,andIcanattesttotensofthousandsmoreusesatcompanieswhereIamnotallowedtotaketheirsourceoffsiteonmylaptop. Resolution:we'rerestoring`facter-p`inFacter3.0.2,withplanstoaddressFACT-96morecompletelyinthefuture.
Add Comment
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Branan Riley commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Kylo Ginsberg Currently we reset libdir. If somebody had (for some reason) set both libdir and plugindest to the same value (even though plugindest defaults to libdir), we'd be causing breakages in the upgrade process. Given it's a one-liner to fix plugindest where we fixup libdir, it seems a worthwhile just in case... but def is unrelated to this ticket. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Facts that rely on things like Puppet::Util would work with facter -p, because Facter actually does require 'puppet'. So this still breaks some facts that would've worked with facter -p, but in a fairly trivial way. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Branan Riley commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality I'm fine with saying that those facts need to explicitly 'require puppet'. We probably do need to make sure that puppet is in our $LOAD_PATH, though. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Kylo Ginsberg commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Agreed on gracefully handling failures to load custom facts. As for log level, I'd incline the other way, i.e. to making it a warning or error if custom facts fail to load - that is something that the admin should fix. Otoh, it may be that it's super common and we don't want to spam people who've been blithely living with custom fact load failures for years. Perhaps we should look at what facter 2 does as input to the log level question. As for resetting plugin*dest, IIRC Josh Cooper suggested that those two settings couldn't be productively or correctly set in puppet anyway, meaning maybe no one is doing so. Not sure if I got that right, or how to validate that though. So it couldn't hurt to reset those settings in puppet_agent. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Peter Huene commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality re: custom facts failing to load, currently we log an error in factor along with any exception message; --trace will cause the output to include the back trace, like we would have from Ruby Facter. I think that's sufficient and desirable. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Josh Cooper commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality re: plugindest, if plugindest is changed from the default, then puppet agent won't be able to load pluginsynced code: see https://projects.puppetlabs.com/issues/18459. The reason is because libdir is not also updated to reflect the new location, and the hook for that setting is what changes puppet's $LOAD_PATH. So tl; dr, puppet agent will not work if you change the default plugindest. The other thing to consider is pluginfactsdest for pluginsync'ed external facts. If that value was changed, I think puppet will still work (could tell facter to load those external facts). But I'm not sure if facter -p would have worked previously. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Josh Cooper commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality re:pluginfactsdest, was ticketed as FACT-696 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Peter Huene commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality From Michael's link, it doesn't look like Facter 2.x added pluginfactsdest to the external search paths, so I don't think pluginsync'd external facts worked even with -p in 2.x. Still, that's something we should get working in 3.0.2, even if it's for the default location only. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Jo Rhett commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Peter: that is completely untrue. Not only have I written dozens of modules which sync down facts that are used in bash scripts on the host, but I've found that dozens of community modules I depend on do similar things, pushing down facts to be used for cron jobs, etc. That is why I opened this issue. This did and does today work with Facter 2. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Josh Cooper commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Jo Rhett you are confusing pluginsynced custom vs pluginsynced external facts. The former did work previously in 2.x, the latter did not (see FACT-696 ). Unfortunately we don't have great names for the three variations of facts: pluginsynced custom vs pluginsynced external vs non-pluginsynced external... Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality To summarize a short in-person conversation with Branan Riley: To have Facter use Puppet's libdir for custom facts, we need to add libdir to the Ruby $LOAD_PATH when Facter initializes Ruby (before https://github.com/puppetlabs/facter/blob/stable/lib/src/ruby/module.cc#L756) Adding Puppet's pluginfactdest for external facts adds them to https://github.com/puppetlabs/facter/blob/stable/lib/src/facts/windows/collection.cc#L34 and https://github.com/puppetlabs/facter/blob/stable/lib/src/facts/posix/collection.cc#L19. In response to my own comment yesterday, we need to gracefully handle failures to load custom facts (pretty sure we already do, but worth verifying) and move people to modules to requiring Puppet explicitly if they need it and want to be usable. Tempted to make this an INFO level message, rather than a warning. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality Current modules that expect Puppet to be set puppetlabs-apache-0.3.0/spec/fixtures/modules/stdlib/lib/facter/puppet_vardir.rb puppetlabs-concat-1.0.0/lib/facter/concat_basedir.rb puppetlabs-concat-1.0.0-rc1/lib/facter/concat_basedir.rb puppetlabs-concat-1.0.1/lib/facter/concat_basedir.rb puppetlabs-concat-1.0.2/lib/facter/concat_basedir.rb puppetlabs-concat-1.0.3/lib/facter/concat_basedir.rb puppetlabs-concat-1.0.4/lib/facter/concat_basedir.rb puppetlabs-concat-1.1.0/lib/facter/concat_basedir.rb puppetlabs-concat-1.1.0-rc1/lib/facter/concat_basedir.rb puppetlabs-concat-1.1.1/lib/facter/concat_basedir.rb puppetlabs-concat-1.1.2/lib/facter/concat_basedir.rb puppetlabs-concat-1.2.0/lib/facter/concat_basedir.rb puppetlabs-concat-1.2.1/lib/facter/concat_basedir.rb puppetlabs-concat-1.2.2/lib/facter/concat_basedir.rb puppetlabs-firewall-1.4.0/lib/facter/iptables_persistent_version.rb puppetlabs-firewall-1.5.0/lib/facter/iptables_persistent_version.rb puppetlabs-keystone-2.1.0/spec/fixtures/modules/stdlib/lib/facter/puppet_vardir.rb puppetlabs-mysql-2.2.0/spec/fixtures/modules/stdlib/lib/facter/puppet_vardir.rb puppetlabs-nodejs-0.1.1/spec/fixtures/modules/stdlib/lib/facter/puppet_vardir.rb puppetlabs-nodejs-0.2.0/spec/fixtures/modules/stdlib/lib/facter/puppet_vardir.rb puppetlabs-pe_upgrade-1.0.0/spec/fixtures/modules/stdlib/lib/facter/puppet_vardir.rb puppetlabs-policy_engine-0.0.1/lib/facter/policy_engine.rb puppetlabs-policy_engine-0.0.1/lib/facter/puppet_vardir.rb puppetlabs-policy_engine-0.0.2/lib/facter/policy_engine.rb puppetlabs-policy_engine-0.0.2/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.3.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.3.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.3.2/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.3.3/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.4.0/lib/facter/facter_dot_d.rb puppetlabs-stdlib-2.4.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.5.0/lib/facter/facter_dot_d.rb puppetlabs-stdlib-2.5.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.5.1/lib/facter/facter_dot_d.rb puppetlabs-stdlib-2.5.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-2.6.0/lib/facter/facter_dot_d.rb puppetlabs-stdlib-2.6.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.0.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.0.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.1.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.1.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.2.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.2.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-3.2.2/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.1.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.2.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.2.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.2.2/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.3.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.3.2/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.4.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.5.0/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.5.1/lib/facter/facter_dot_d.rb puppetlabs-stdlib-4.5.1/lib/facter/puppet_vardir.rb puppetlabs-stdlib-4.6.0/lib/facter/facter_dot_d.rb puppetlabs-stdlib-4.6.0/lib/facter/puppet_vardir.rb Looks like just a few we'd have to patch up.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Kylo Ginsberg moved an issue Facter / FACT- deprecation of 'facter --puppet' removes critically necessary functionality Change By: Kylo Ginsberg Fix Version/s: PUP4.2.1 Fix Version/s: FACT3.0.2 Key: PUP FACT - 4798 Project: Puppet Facter Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Michael Smith commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality We should also take into account that some module custom facts assume Puppet is initialized, see https://github.com/puppetlabs/puppetlabs-firewall/blob/master/lib/facter/iptables_persistent_version.rb#L8. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Jo Rhett commented on FACT- Re: deprecation of 'facter --puppet' removes critically necessary functionality look into a config file for facter (again, treating facter as the owner of facts) and have facter tell puppet where to put them Short-term, that would break the circular dependency concern of fact-96, but wouldn't address usage of 'facter -p' at sites that override the plugin sync directories. These two sentences seem pretty obviously related. Have facter check the puppet configuration for the plugin sync directories? Or, document that if you override the plugin sync directories you must also set facter's load path? Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1111) deprecation of 'facter --puppet' removes critically necessary functionality
Title: Message Title Eric Thompson updated an issue Facter / FACT- deprecation of 'facter --puppet' removes critically necessary functionality Change By: Eric Thompson QA Risk Severity: High QA Risk Severity Reason: escalation-ish.needpluginsync'dfactsfromfacter QA Risk Assessment: High Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
