Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title
Jeff Sparrow commented on FACT-1158
Re: Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Let me run the above reproduction, but it sure seems to be the same:
Looks like it tries to expand the program name by PATH, causing it to fail:
Facter::Core::Execution.exec('quacli')
executing command: C:\Windows\system32\cmd.exe /c "C:\Program Files\QLogic Corporation\QConvergeConsoleCLI\qaucli.exe"
which then fails because it expands the file path and then comes back with:
'C:\Program' is not recognized as an internal or external command
%PATH%
C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\ProgramData\chocolatey\bin;C:\Program Files\QLogic Corporation\QConvergeConsoleCLI\;C:\PROGRA~1\Emulex\Util\OCManager;C:\Program Files (x86)\Dell\Enterprise Manager\msagui;c:\Program Files\Puppet Labs\Puppet\bin;C:\Users\Administrator\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Nmap
I did notice that
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Michael Smith commented on FACT-1158 Re: Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Is it the same issue, or something similar? If it's exactly the same, we should re-open this as a regression, otherwise a new ticket makes sense. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Jeff Sparrow commented on FACT-1158 Re: Facter::Util::Resolution.exec on Windows fails to exec paths with spaces I realize this ticket is long closed, however I am running in to this issue on Facter 3.6.7 - should I create a new ticket? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Shaigy Nixon assigned an issue to Shaigy Nixon Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Shaigy Nixon Assignee: qa ShaigyNixon Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Shaigy Nixon updated an issue Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Shaigy Nixon QA Risk Assessment Reason: breakscustomfactsinmodule QA Highest Test Level: Unit QA Risk Assessment: Medium QA Risk Probability: Low QA Risk Severity: Medium QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Shaigy Nixon commented on FACT-1158 Re: Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Validated on Windows-2012r2-x86_64: Steps to reproduce: 1) On windows, install git using a browser 2) Install puppetlabs/git module puppet module install puppetlabs/git 3) copy C:\ProgramData\PuppetLabs\Puppet\code\environment\production\modules\git\lib\facter\git_version.rb C:\tmp 4) Check for custom fact git_version facter --custom-dir=c:\tmp git_version c:\tmpfacter --version 3.0.2 (commit 0e5cf30f6a565b08da9ef926302059aeb0b9e2b8) c:\tmpfacter --custom-dir=c:\tmp git_version 2.5.0.windows.1 c:\tmpfacter -p git_version 2.5.0.windows.1
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Peter Huene updated an issue Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Peter Huene Release Notes Summary: Expandingcommandspassedto`Facter::Util::Resolution#exec`(andtheotherexecutemethods)didnotproperlyhandlespacesintheexecutablepathwhenexecutingcommands.ThiswasaregressionfromFacter2.x.Thefixistoproperlyquotetheexecutablepathwhencreatingthechildprocess. Release Notes: BugFix Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Michael Smith assigned an issue to qa Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Michael Smith Status: Readyfor CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Peter Huene assigned an issue to Peter Huene Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Peter Huene Assignee: PeterHuene Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Peter Huene updated an issue Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Peter Huene Story Points: 1 Scrum Team: ClientPlatform Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Steve Barlow updated an issue Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Steve Barlow Sprint: Client2015-09-02 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Peter Huene updated an issue Facter / FACT-1158 Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Change By: Peter Huene Affects Version/s: FACT3.0.2 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Michael Smith commented on FACT-1158 Re: Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Fix for this is probably making leatherman::execution::expand_command smarter, to quote the path returned by which if needed. Windows attempts to handle arguments in execute when they're passed in as a vector, but Ruby passes the arguments as a single string. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title Michael Smith commented on FACT-1158 Re: Facter::Util::Resolution.exec on Windows fails to exec paths with spaces Verified this definitely worked in 2.x with $env:FACTERLIB=$pwd\tmp bundle exec facter git_version --debug Found no suitable resolves of 1 for ec2_metadata value for ec2_metadata is still nil 1.9.5.msysgit.1 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title
Reid Vandewiele created an issue
Facter / FACT-1158
Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Issue Type:
Bug
Assignee:
Unassigned
Created:
2015/08/11 3:55 PM
Priority:
Normal
Reporter:
Reid Vandewiele
Consider the following fact, from the puppetlabs/git module.
Facter.add('git_version') do
setcode do
if Facter::Util::Resolution.which('git')
git_version_cmd = 'git --version 21'
Jira (FACT-1158) Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Title: Message Title
Reid Vandewiele updated an issue
Facter / FACT-1158
Facter::Util::Resolution.exec on Windows fails to exec paths with spaces
Change By:
Reid Vandewiele
Considerthefollowingfact,fromthe[puppetlabs/git|https://forge.puppetlabs.com/puppetlabs/git/0.4.0]module.{code :ruby }Facter.add('git_version')dosetcodedoifFacter::Util::Resolution.which('git')git_version_cmd='git--version21'git_version_result=Facter::Util::Resolution.exec(git_version_cmd)git_version_result.to_s.lines.first.strip.split(/version/)[1].stripendendend{code}ThisfactfailstosuccessfullyexecuteonWindowsrunningPE2015.2.0,withgitinstalledin{{C:\ProgramFiles(x86)\Git\bin\git.exe}}.Investigationshowserrorsbeingreturnedbytheexeccallbeginningwith'C:\Program'isnotrecognizedasaninternalorexternalcommand.Reproduction:Ona2015.2.0Puppetmasterinstallthepuppet/gitmodule,version0.4.0.OnaWindowsclient,installGit.RunPuppet.Thefactwillfail.
Add Comment
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
