Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Branan Riley updated an issue Facter / FACT-1589 Need to rethink behavior of specifying facter directory's or not allowing facts Change By: Branan Riley Labels: Easy triaged Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1589 Need to rethink behavior of specifying facter directory's or not allowing facts Change By: Geoff Nichols Sprint: Agent Accepted Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Eric Delaney commented on FACT-1589 Re: Need to rethink behavior of specifying facter directory's or not allowing facts I was working on the acceptance tests and here is essentially the list from above, but with the TestRail numbers for tests that already exist. So the ones without the TestRail numbers are the tests that would need to be created to help test the new behavior. CLI == Command line Interface CF == configuration file C99974 - CLI external-dir - external facts found C8 - CLI external-dir + external_dir - external facts found C99961 - CLI no-external-facts - NO external facts found C12 - CLI no-external-facts + CLI external-dir - ERROR conflicting options C98142 - CF external-dir - external facts found C5 - CF external-dir list - external facts found C100016 - CF external-dir /cf_dir + CLI external-dir /cli_dir - use CLI /cli_dir only for external facts CF external-dir + CLI no-external-facts - NO external facts found
Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1589 Need to rethink behavior of specifying facter directory's or not allowing facts Change By: Geoff Nichols Sprint: Agent Triage Accepted Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Eric Delaney commented on FACT-1589 Re: Need to rethink behavior of specifying facter directory's or not allowing facts So a proposed solution would be to apply the configuration files options, and then allow the command line options to override them. For example if the config file said "external-dir" is set to "/tmp/external", and then on the command line we had the option "--no-exter nal-facts" then we would drop the added external directories. The only failure cases would be if conflicting options where configured at the same level, say for example if you used the options --no-external-facts and a --external-dir on the command line, this should cause a conflict error. CLI == Command line Interface CF == configuration file CLI external-dir - external facts found CLI no-external-facts - NO external facts found CLI no-external-facts + CLI external-dir - ERROR conflicting options CF external-dir - external facts found CF external-dir + CLI external-dir - external facts from both directories CF external-dir + CLI no-external-facts - NO external facts found CF no-external-facts - no external facts found CF no-external-facts + CLI external-dir - allow external-dir to be found CF no-external-facts + CLI no-external-facts - NO external facts found CF no-external-facts + CF external-dir - ERROR conflicting options CLI custom-dir - custom facts found CLI no-custom-facts - NO custom facts found CLI no-custom-facts - NO FACTERLIB used CLI no-custom-facts + CLI custom-dir - ERROR conflicting options CF custom-dir - custom facts found CF custom-dir + CLI custom-dir - custom facts from both CF custom-dir + CLI no-custom-facts - NO custom facts found CF no-custom-facts - NO custom facts found CF no-custom-facts - NO FACTERLIB used CF no-custom-facts + CLI custom-dir - custom facts found CF no-custom-facts + CLI no-custom-facts - NO custom facts found CF no-custom-facts + CF custom-dir - ERROR conflicting options Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Maggie Dreyer commented on FACT-1589 Re: Need to rethink behavior of specifying facter directory's or not allowing facts It seems that we should have the no-XXX-facts options conflict with specifying directories within any one format (CLI or config), but not across them. And the command line should always override what's in the config file. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1589) Need to rethink behavior of specifying facter directory's or not allowing facts
Title: Message Title Eric Delaney created an issue Facter / FACT-1589 Need to rethink behavior of specifying facter directory's or not allowing facts Issue Type: Bug Affects Versions: FACT 3.6.2 Assignee: Unassigned Created: 2017/03/14 9:08 AM Priority: Normal Reporter: Eric Delaney We need to take a good look at how custom and external fact directories are allowed or not alowed in facter. Here are the possible options: config file: external-dir : [ list ] config file: no-external-facts : true --external-dir directory --no-external-facts config file: custom-dir : [ list ] config file: no-custom-facts : true --custom-dir directory --no-custom-facts Currently what happens in facter 3.6.1 is that you are not allowed to specific ANY combination a directory to look for facts and specify that no facts of that type are allowed. For example you can specify in your configuration file that external-dir's are in /external-facts and then when you run facter say "facter --no-external-facts". This produces an error root@ee5fy4iwljtzoh2:~# facter --config /tmp/t.conf --no-external-facts error: no-external-facts and external-dir options conflict: please specify only one. This makes the --no-external-facts and --no-custom-facts kind of pointless except to ensure that nothing is set in the configuration file. The only real benefit would be for --no-custom-facts and being able to avoid the inclusion of the
