Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-08-20 Thread Michelle Fredette (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michelle Fredette updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Michelle Fredette  
 
 
Labels: 
 amazon amazon_linux aws  docs_reviewed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-13 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Kenn Hussey  
 
 
Flagged: 
 Impediment  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-13 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 Casey Williams did this get through CI yet?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-10 Thread Casey Williams (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Casey Williams updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Casey Williams  
 
 
Release Notes Summary: 
 Updates facter to correctly read the format of /etc/system-release under Amazon Linux 2. This corrects the os release fact, which previously fell back to the kernel version.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-10 Thread Casey Williams (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Casey Williams updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Casey Williams  
 
 
Release Notes: 
 Bug Fix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-10 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
  Casey Williams please add release notes for this issue, if needed. Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-09 Thread Casey Williams (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Casey Williams assigned an issue to Casey Williams  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Casey Williams  
 
 
Assignee: 
 Casey Williams  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-09 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Kenn Hussey  
 
 
Flagged: 
 Impediment  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-07-03 Thread Geoff Nichols (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Geoff Nichols updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Change By: 
 Geoff Nichols  
 
 
Sprint: 
 Platform OS Kanban  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 Looks like the removal of the word "release" from the file is what broke us: https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/os_linux.cc#L290  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Mate Farkas (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mate Farkas commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 The Docker container image is affected too: amazonlinux:2, amazonlinux:latest The VirtualBox image linked from https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/amazon-linux-2-virtual-machine.html#amazon-linux-2-virtual-machine-download is still reporting Amazon Linux release 2 (2017.12) LTS Release Candidate and unaffected.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Mate Farkas (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mate Farkas commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 My estimation was way off, I don't have better things to do at home. /etc/os-release on the affected node:  
 
 
 
 
    
 
 
 NAME="Amazon Linux"  
 
 
 VERSION="2"  
 
 
 ID="amzn"  
 
 
 ID_LIKE="centos rhel fedora"  
 
 
 VERSION_ID="2"  
 
 
 PRETTY_NAME="Amazon Linux 2"  
 
 
 ANSI_COLOR="0;33"  
 
 
 CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"  
 
 
 HOME_URL="https://amazonlinux.com/"  
 
 
 
  
 
 
 
    The working one, RC for comparison:  
 
 
 
 
    
 
 

Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Mate Farkas (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mate Farkas commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 Sorry Branan Riley, I can only do that in the morning. They are closing the office on me. Will share after 10 AM BST.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 A lot of this horribly logic in facter should be replaced by checking for /etc/os-release first whenever possible. Our distro detection logic dates back to well before that was a standard, and it's not pretty.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 I've been able to reproduce this locally, more or less, on a centos 7.2 machine by messing with various release files. First, I removed /etc/redhat-release, Facter stopped being able to detect it as a CentOS node, and actually called it Amazon linux (our heuristic for Amazon linux is "has a system-release file but not a redhat-release file"). It was still able to pull the correct os release from /etc/system-release, calling this "Amazon 7.2" Next, I removed /etc/system-release, Facter completely gives up and reports the os as "Linux", with the kernel version. Finallyl, I created an empty /etc/system-release. This reproduced the behavior you've reported. Do you mind sharing the contents of /etc/system-release from an affected node?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Mate Farkas (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mate Farkas commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 Confirmed, AWS changed something between the RC and the final release which broke the version recognition. All AMI ids are from the eu-west-1 (Ireland) region: ami-921423eb amzn2-ami-hvm-2017.12.0.20180509-x86_64-gp2 released on May 10, 2018 at 1:16:51 AM UTC+1 Full release is not 2.0 as expected, but works (systemd is used as default service provider).  
 
 
 
 
 "operatingsystem": "Amazon",  
 
 
 "operatingsystemmajrelease": "2",  
 
 
 "operatingsystemrelease": "2",  
 
 
 "os": {  
 
 
   "architecture": "x86_64",  
 
 
   "family": "RedHat",  
 
 
   "hardware": "x86_64",  
 
 
   "name": "Amazon",  
 
 
   "release": {  
 
 
 "full": "2",  
 
 
 "major": "2"  
 
 
   },  
 
 
   "selinux": {  
 

Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1865  
 
 
  Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 FACT 3.11.2  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/06/28 10:11 AM  
 
 
Fix Versions: 
 FACT 3.11.3  
 
 
Labels: 
 amazon amazon_linux aws  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Branan Riley  
 

  
 
 
 
 

 
 Facter 3.11.2 shipped with puppet-agent-5.5.3-1.el7 is reporting the following facts:  
 
 
 
 
 "operatingsystem": "Amazon",  
 
 
 "operatingsystemmajrelease": "4", <- Note this  
 
 
 "operatingsystemrelease": "4.14.47-64.38.amzn2.x86_64",  
 
 
 "os": {  
 
   

Jira (FACT-1865) Amazon Linux 2 is reported as 4

2018-06-28 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley commented on  FACT-1865  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Amazon Linux 2 is reported as 4   
 

  
 
 
 
 

 
 Originally reported by Mate Farkas in PA-2103  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.