Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2023-04-06 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Flagged: 
 Impediment  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.3473.1680796320021%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2023-04-05 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Priority: 
 Normal Major  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.3274.1680722400022%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2023-04-05 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3000  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
 The facter 3 code for looking up a fact value is in https://github.com/puppetlabs/facter/blob/6d7ffc6efdfbc3b1fc79311cdeb4581ac2098d9c/lib/src/facts/collection.cc#L466-L510. Note how dots can be escaped by double quoting the segment. Facter 4 splits on dots https://github.com/puppetlabs/facter/blob/ba325b14ea302c6d90b692219be3468bd2b1426c/lib/facter/util/utils.rb#L16 which is incorrect.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.3273.1680722340022%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2023-04-05 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.3263.1680720420024%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2023-03-03 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Night's Watch Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.2964.1677865380141%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2023-03-03 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 FACT PUP - 3051 11659  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.2963.1677865380093%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-12-15 Thread productboard (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 productboard updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 productboard  
 
 
productboard URL: 
 https://puppet.productboard.com/feature-board/planning/features/11160699  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.6097.1639575840037%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-09-07 Thread Ciprian Badescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ciprian Badescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Ciprian Badescu  
 
 
Sprint: 
 Triaged tickets,  NW - 2021-04-14  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.123921.1631001060028%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-06-22 Thread Beth Glenfield (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Beth Glenfield updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Beth Glenfield  
 
 
Epic Link: 
 FACT-3051  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.61954.1624357380031%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-04-14 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 NW - 2021-04-14 Triaged tickets , NW-2021-04- 28 14  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.8643.1618395780083%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-04-14 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 NW - 2021-04-14 , NW-2021-04-28  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.8636.1618395720092%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-04-07 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Fix Version/s: 
 FACT 4.1.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.3162.1617802260358%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-04-06 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Flagged: 
 Impediment  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.2281.1617731280260%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-31 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu assigned an issue to Gheorghe Popescu  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Assignee: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.178196.1617183540027%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-31 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Story Points: 
 5  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.178111.1617178440026%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-30 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 FACT 4.0.53  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.177499.1617120180149%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-30 Thread Nick Walker (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nick Walker updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Nick Walker  
 

  
 
 
 
 

 
 Primary problem:  - There is no way to override, block, or cache facts that contain a dot in the name or sub-key Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem.Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters.The reference implementation for dot-notation is found in Puppet, [here|https://github.com/puppetlabs/puppet/blob/85bd9ed07e3e6c956f1972624a50be914292e1ab/lib/puppet/pops/lookup/sub_lookup.rb#L6-L44].Full dot-notation should be supported everywhere Facter 4 currently evaluates dot-notation strings to segment structured fact names. This includes external fact output (text, json, yaml), as well as {{Facter.add()}}.*Today's behavior*Consider the following plain-text custom fact file:{code}foo.bar._one_=1foo.bar.two=2foo."i.have.dots"=3"me.too"=4{code}Today, Facter 4 returns the following for these facts.{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"\"i": {  "have": {"dots\"": "3"  }}  },  "\"me": {"too\"": "4"  }}{code}This is incorrect.*Correct behavior*Full and correct support for dot-notation SHOULD give:{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"i.have.dots": "3"  },  "me.too": "4"}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
   

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-30 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 NW - 2021-04-14  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.177198.1617112080104%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-30 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Team: 
 Night's Watch  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.177197.1617112080057%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-29 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3000  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
 I'm  on completing dot notation handling in Facter 4. Also we have many cases in the puppet ecosystem where dots are special and must be escaped if you want a literal dot. For example, https://puppet.com/docs/puppet/7.5/hiera_automatic.html#hiera_dotted_notation. So the behavior described here would provide more consistency.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393010.1616788653000.176945.1617079500048%40Atlassian.JIRA.


Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-29 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3000  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
 For comparison, facter3 returns the following with the same external fact (since none of the facts are auto-promoted to structured facts):  
 
 
 
 
 # facter | grep foo  
 
 
 "foo.too" => 4  
 
 
 foo."i.have.dots" => 3  
 
 
 foo.bar._one_ => 1  
 
 
 foo.bar.two => 2  
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-29 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem.Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters.The reference implementation for dot-notation is found in Puppet, [here|https://github.com/puppetlabs/puppet/blob/85bd9ed07e3e6c956f1972624a50be914292e1ab/lib/puppet/pops/lookup/sub_lookup.rb#L6-L44].Full dot-notation should be supported everywhere Facter 4 currently evaluates dot-notation strings to segment structured fact names. This includes external fact output (text, json, yaml), as well as {{Facter.add()}}.*Today's behavior*Consider the following plain-text custom fact file:{code}foo.bar._one_=1foo.bar.two=2foo."i.have.dots"=3"me.too"=4{code}Today, Facter  4  returns the following for these facts.{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"\"i": {  "have": {"dots\"": "3"  }}  },  "\"me": {"too\"": "4"  }}{code}This is incorrect.*Correct behavior*Full and correct support for dot-notation SHOULD give:{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"i.have.dots": "3"  },  "me.too": "4"}{code}   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-26 Thread Reid Vandewiele (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Reid Vandewiele updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Reid Vandewiele  
 

  
 
 
 
 

 
 Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem.Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters.The reference implementation for dot-notation is found in Puppet, [here|https://github.com/puppetlabs/puppet/blob/85bd9ed07e3e6c956f1972624a50be914292e1ab/lib/puppet/pops/lookup/sub_lookup.rb#L6-L44].Full dot-notation should be supported everywhere Facter 4 currently evaluates dot-notation  strings  to segment structured fact names. This includes external fact output (text, json, yaml), as well as {{Facter.add()}}.*Today's behavior*Consider the following plain-text custom fact file:{code}foo.bar._one_=1foo.bar.two=2foo."i.have.dots"=3"me.too"=4{code}Today, Facter returns the following for these facts.{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"\"i": {  "have": {"dots\"": "3"  }}  },  "\"me": {"too\"": "4"  }}{code}This is incorrect.*Correct behavior*Full and correct support for dot-notation SHOULD give:{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"i.have.dots": "3"  },  "me.too": "4"}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
   

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-26 Thread Reid Vandewiele (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Reid Vandewiele updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Reid Vandewiele  
 

  
 
 
 
 

 
 Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem.Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters.The reference implementation for dot-notation is found in Puppet, [here|https://github.com/puppetlabs/puppet/blob/85bd9ed07e3e6c956f1972624a50be914292e1ab/lib/puppet/pops/lookup/sub_lookup.rb#L6-L44]. Full dot-notation should be supported everywhere Facter 4 currently evaluates dot-notation to segment structured fact names. This includes external fact output (text, json, yaml), as well as {{Facter.add()}}. *Today's behavior*Consider the following plain-text custom fact file:{code}foo.bar._one_=1foo.bar.two=2foo."i.have.dots"=3"me.too"=4{code}Today, Facter returns the following for these facts.{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"\"i": {  "have": {"dots\"": "3"  }}  },  "\"me": {"too\"": "4"  }}{code}This is incorrect.*Correct behavior*Full and correct support for dot-notation SHOULD give:{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"i.have.dots": "3"  },  "me.too": "4"}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
   

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-26 Thread Reid Vandewiele (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Reid Vandewiele updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Reid Vandewiele  
 

  
 
 
 
 

 
 Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem.Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters.The reference implementation for dot-notation is found in Puppet, [here|https://github.com/puppetlabs/puppet/blob/85bd9ed07e3e6c956f1972624a50be914292e1ab/lib/puppet/pops/lookup/sub_lookup.rb#L6-L44].*Today's behavior*Consider the following plain-text custom fact file:{code}foo.bar._one_=1foo.bar.two=2foo."i.have.dots"=3"me.too"=4{code}Today, Facter returns the following for these facts.{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"\"i": {  "have": {"dots\"": "3"  }}  },  "\" foo me ": {"too\"": "4"  }}{code}This is incorrect.*Correct behavior*Full and correct support for dot-notation SHOULD give:{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"i.have.dots": "3"  },  "me.too": "4"}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

  

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-26 Thread Reid Vandewiele (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Reid Vandewiele updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Change By: 
 Reid Vandewiele  
 

  
 
 
 
 

 
 Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem.Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters.The reference implementation for dot-notation is found in Puppet, [here|https://github.com/puppetlabs/puppet/blob/85bd9ed07e3e6c956f1972624a50be914292e1ab/lib/puppet/pops/lookup/sub_lookup.rb#L6-L44].*Today's behavior*Consider the following plain-text custom fact file:{code}foo.bar._one_=1foo.bar.two=2foo." I i . Have have . Dots dots "=3"me.too"=4{code}Today, Facter returns the following for these facts.{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"\"i": {  "have": {"dots\"": "3"  }}  },  "\"foo": {"too\"": "4"  }}{code}This is incorrect.*Correct behavior*Full and correct support for dot-notation SHOULD give:{code:json}{  "foo": {"bar": {  "one": "1",  "two": "2"},"i.have.dots": "3"  },  "me.too": "4"}{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 
  

Jira (FACT-3000) Dot notation implemented in Facter 4 is incomplete

2021-03-26 Thread Reid Vandewiele (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Reid Vandewiele created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3000  
 
 
  Dot notation implemented in Facter 4 is incomplete   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/03/26 12:57 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Reid Vandewiele  
 

  
 
 
 
 

 
 Facter 4 introduced compositive fact structuring via dot-notation as a feature. However, the dot-notation implementation used is incomplete, and behaves differently from dot-notation elsewhere in the ecosystem. Specifically, Facter 4 dot-notation splits key segments incorrectly, because it does not recognize the use of double or single quotes to indicate keys which contain literal dot characters. The reference implementation for dot-notation is found in Puppet, here. Today's behavior Consider the following plain-text custom fact file:  
 
 
 
 
 foo.bar._one_=1  
 
 
 foo.bar.two=2  
 
 
 foo."I.Have.Dots"=3  
 
 
 "me.too"=4
  
 
 
 
  Today, Facter returns the following for these facts.