Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo commented on an issue Re: facter-2.0.1.rc2 Solaris lspci command not found In Facter 1.x, it is harmless to execute commands that do not exist because `Facter::Util::Resolution.exec` will check to see if the command exists and returns nil if it does not. Unfortunately this has lead to some sloppy code where all commands would be attempted, which clutters up the executing logic. In Facter 2.0 the behavior of .exec was changed to raise an error if a command did not exist, but this aggravated the situation you've described. As part of FACT-409 we're reverting that behavior change so this issue should be taken care of. You are right though, it's silly to attempt to run lscpi on Solaris in any case, and that code should be refactored. Add Comment Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found The follow error says it all /var/ruby/1.8/gem_home/bin/facter -p Could not load Puppet: can't activate facter (~ 1.6, runtime) for [puppet-3.4.3], already activated facter-2.0.1.rc2 for [] Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolut... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo commented on an issue Re: facter-2.0.1.rc2 Solaris lspci command not found Actually, if I'm reading http://mj.ucw.cz/sw/pciutils/ correctly, lspci can actually be run on Solaris systems. It's just not there on a regular basis. Add Comment Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found The follow error says it all /var/ruby/1.8/gem_home/bin/facter -p Could not load Puppet: can't activate facter (~ 1.6, runtime) for [puppet-3.4.3], already activated facter-2.0.1.rc2 for [] Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolut... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo updated an issue Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found Change By: Adrien Thebo Component/s: Community Story Points: 1 Priority: Critical Major Fix Version/s: 2.0.1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo commented on an issue Re: facter-2.0.1.rc2 Solaris lspci command not found Looking at https://blogs.oracle.com/thebentzone/entry/compiling_pciutils_lspci_on_solaris indicates that lspci can definitely be installed on Solaris. The reason that errors were being raised is the overly aggressive error raising in .exec, but that will be resolved as part of FACT-409. Because the raised exceptions will be resolved by FACT-409 and running lspci isn't strictly a problem, I'm going to mark this issue as closed. If this issue persists after Facter 2.0.1-rc3 or if you have any additional concerns, please reopen this issue and we can continue this conversation. Add Comment Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found The follow error says it all /var/ruby/1.8/gem_home/bin/facter -p Could not load Puppet: can't activate facter (~ 1.6, runtime) for [puppet-3.4.3], already activated facter-2.0.1.rc2 for [] Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolut... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo assigned an issue to Unassigned Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found Change By: Adrien Thebo Assignee: AdrienThebo Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Damon Atkins updated an issue Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found Change By: Damon Atkins Assignee: DamonAtkins AdrienThebo Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Damon Atkins created an issue Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found Issue Type: Bug Affects Versions: 2.0.1 Assignee: Adrien Thebo Components: Community Created: 21/Mar/14 4:59 AM Environment: Solaris 11 Priority: Critical Reporter: Damon Atkins The follow error says it all /var/ruby/1.8/gem_home/bin/facter -p Could not load Puppet: can't activate facter (~ 1.6, runtime) for [puppet-3.4.3], already activated facter-2.0.1.rc2 for [] Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found architecture = i86pc bios_release_date = 07/13/2006 bios_vendor = American Megatrends Inc. bios_version = System Version domain = oz facterversion = 2.0.1-rc2 fqdn = beta.oz hardwareisa = i386 hardwaremodel = i86pc hostname = beta id = root interfaces = lo0,yge0 ipaddress = 192.168.53.1 ipaddress_lo0 = 127.0.0.1 ipaddress_yge0 =
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Damon Atkins updated an issue Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found Change By: Damon Atkins Thefollowerrorsaysitall/var/ruby/1.8/gem_home/bin/facter-pCouldnotloadPuppet:can'tactivatefacter(~1.6,runtime)for[puppet-3.4.3],alreadyactivatedfacter-2.0.1.rc2for[]Couldnotretrievefact='virtual',resolution='anonymous':Couldnotexecute'lspci2/dev/null':commandnotfoundCouldnotretrievefact='virtual',resolution='anonymous':Couldnotexecute'lspci2/dev/null':commandnotfoundCouldnotretrievefact='virtual',resolution='anonymous':Couldnotexecute'lspci2/dev/null':commandnotfoundarchitecture=i86pcbios_release_date=07/13/2006bios_vendor=AmericanMegatrendsInc.bios_version=SystemVersiondomain= oz X facterversion=2.0.1-rc2fqdn= beta X . oz X hardwareisa=i386hardwaremodel=i86pchostname= beta X id=rootinterfaces=lo0,yge0ipaddress=192.168. 53 X .1ipaddress_lo0=127.0.0.1ipaddress_yge0=192.168. 53 X .1is_virtual=truekernel=SunOSkernelmajversion=11.0kernelrelease=5.11kernelversion=11.0macaddress=00:15:f2:39:5e:c4macaddress_yge0=00:15:f2:39:5e:c4manufacturer=Systemmanufacturermemoryfree=221.54MBmemoryfree_mb=221.54memorysize=3.50GBmemorysize_mb=3584.00mtu_lo0=8232mtu_yge0=1500netmask=255.255.255.0netmask_lo0=255.0.0.0netmask_yge0=255.255.255.0network_lo0=127.0.0.0network_yge0=192.168. 53 X .0operatingsystem=Solarisoperatingsystemrelease=5.11osfamily=Solarispath=/usr/sbin:/usr/binphysicalprocessorcount=1processor0=Intel(r)Pentium(r)DCPU2.80GHzprocessor1=Intel(r)Pentium(r)DCPU2.80GHzprocessorcount=2productname=SystemProductNameps=ps-efrubysitedir=/usr/ruby/1.8/lib/ruby/site_ruby/1.8rubyversion=1.8.7serialnumber=SystemSerialNumbersshdsakey=removedsshfp_dsa=removedsshfp_rsa=removedsshrsakey=removedswapfree=1.56GBswapfree_mb=1599.97swapsize=1.75GBswapsize_mb=1791.00timezone=ESTtype=0x3(desktop)uniqueid=removeduptime=133daysuptime_days=133uptime_hours=3214uptime_seconds=11571180uuid=removedzfs_version=5zone_global_brand=solariszone_global_id=0zone_global_iptype=sharedzone_global_name=globalzone_global_path=/zone_global_status=runningzone_global_uuid=zonename=globalzones=1zpool_version=33 Add Comment
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo commented on an issue Re: facter-2.0.1.rc2 Solaris lspci command not found What sort of hardware is this machine running on? Add Comment Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found The follow error says it all /var/ruby/1.8/gem_home/bin/facter -p Could not load Puppet: can't activate facter (~ 1.6, runtime) for [puppet-3.4.3], already activated facter-2.0.1.rc2 for [] Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolut... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title Adrien Thebo updated an issue Facter / FACT-408 facter-2.0.1.rc2 Solaris lspci command not found Change By: Adrien Thebo Assignee: AdrienThebo DamonAtkins Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-408) facter-2.0.1.rc2 Solaris lspci command not found
Title: Message Title
Damon Atkins commented on an issue
Re: facter-2.0.1.rc2 Solaris lspci command not found
It Solaris 11 on direct H/W, no visualisation at all. lspci is a Linux command. It should not be run on a Solaris system at all. Their seems to be a lack of OS checks {Facter.value(:kernel)}
before commands are executed. This should be consider dangerous as puppet runs commands as root.
Their needs to be a lot more of if Facter.value(:kernel) checks in the code before executing commands... You can not guarantee that a command is safe to execute on all OS. It also should contain the full path or set the path before executing.
Is their a check to see if . is in a path... See facter-2.0.1.rc2/lib/facter/util/virtual.rb
Puppet/Factor/etc should be audited to see if it is executing valid commands for an OS.
It might be worth running Solaris x86 in a virtual systems to see this issue as I assume it will happen even if the system is Virtual or Physical. Cheers
Add Comment
Facter / FACT-408
facter-2.0.1.rc2 Solaris lspci command not found
The follow error says it all /var/ruby/1.8/gem_home/bin/facter -p Could not load Puppet: can't activate facter (~ 1.6, runtime) for [puppet-3.4.3], already activated facter-2.0.1.rc2 for [] Could not retrieve fact='virtual', resolution='anonymous': Could not execute 'lspci 2/dev/null': command not found Could not retrieve fact='virtual', resolut...
