Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Please add a separate ticket (if not already added). It is a packaging thing, not something done inside of hiera. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Ethan Brown commented on HI-298 Re: Update FS layout for hiera This has already been done in the Windows MSI as part of PUP-4034 - landed in commit https://github.com/puppetlabs/puppet_for_the_win/commit/5ef5d302f2ccb2c2af1e2158ce6a933e927811c1 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title John Duarte commented on HI-298 Re: Update FS layout for hiera hieradata directory on nix is not created on RHEL 7. Is that expected? All other specified paths pass inspection. # ls /etc/puppetlabs/code/hiera.yaml /etc/puppetlabs/code/hiera.yaml # ls /etc/puppetlabs/code/hieradata ls: cannot access /etc/puppetlabs/code/hieradata: No such file or directory # ls -l /opt/puppetlabs/bin/hiera lrwxrwxrwx. 1 root root 32 Mar 2 07:59 /opt/puppetlabs/bin/hiera - /opt/puppetlabs/puppet/bin/hiera # ls /opt/puppetlabs/puppet/bin/hiera /opt/puppetlabs/puppet/bin/hiera # ls /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera.rb /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/hiera.rb
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Eric Thompson QA Contact: KurtWall EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson commented on HI-298 Re: Update FS layout for hiera the paths spec indicates the hieradata dir, but also indicates that the packages do not create this dir. hiera is very tolerant of missing datadir(s), so i think this is fine. moving to ready for review for good measure... Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Nicholas Fagerlund commented on HI-298 Re: Update FS layout for hiera Docs opinion: The package should really create the hieradata dir. If the directory exists by default, it's discoverable. If it doesn't, it's secret, and you must read documentation to uncover it. Even if you do read the docs, having a pre-existing directory reinforces what you learned, eases the burden on your memory, and shows you that you're on the right track. Leaving it absent is an unnecessary papercut to users. We should create it. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title John Duarte commented on HI-298 Re: Update FS layout for hiera I agree with Nicholas Fagerlund. I am throwing this back into review. We should discuss whether to bump this ticket back on the queue for this change or ticket the hieradir issue separately. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title J.D. Welch commented on HI-298 Re: Update FS layout for hiera Agree with Nick. Create the datadir. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Josh Cooper commented on HI-298 Re: Update FS layout for hiera Hiera specs and acceptance passed in both pipelines, including promoting rhel7 and win2012r2 to nightlies. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson commented on HI-298 Re: Update FS layout for hiera we're blocked on merging PR-255 on this, yes? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Thanks Josh Cooper and Ethan Brown - looks like both PRs are merged now. Moving this to Ready for CI. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Josh Cooper commented on HI-298 Re: Update FS layout for hiera Ethan Brown, Eric Thompson, Henrik Lindberg MSI changes are in, this is ready to be merged, and should probably be merged along with https://github.com/puppetlabs/puppet/pull/3646 I say probably, because we don't currently test hiera acceptance on windows, and the puppet acceptance that use hiera only happen on the master. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Ethan Brown commented on HI-298 Re: Update FS layout for hiera Merged latest Windows related PR #255 to master as https://github.com/puppetlabs/hiera/commit/0efd9276d3ada2c2f65741378a382b8c32a45e0b Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Nicholas Fagerlund updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Nicholas Fagerlund UPDATE---Thisticketwasreopenedafteradecisionwasmadetochangethepaths.ThisdescriptionhasbeenupdatedtoreflectthedecisionmadeinPUP-3809.ThecomingupdatetotheFSlayoutforourprojectsrequiresseveralchangestodefaultpathingandconfigfilestoensurethatthecorrectdirectoriesareused.Offthetopofmyheadthisincludesdefaultdatadirforhieradata.Thenewlayoutisdescribedhere:https://confluence.puppetlabs.com/display/DEL/Unified+Puppet+Agent+Layout SpecificallytoHiera,thepathsshouldbe: * Defaultconfigfileonposixis/etc/puppetlabs/code/hiera.yaml*Defaultdatadironposixis/etc/puppetlabs//code/hieradata/*Defaultsaresame Lookinthespec when usedfromPuppet doingafinaldocsupdate , Rubylibrary,andcmdline. * sincewhatwhatwaspreviouslyrecordedhereasthefinaldecisionhaschanged.Notably, Windows defaultsdonotchange ischangingnowtoo . Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Paths for Windows are being specified https://github.com/puppetlabs/puppet-specifications/pull/25 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Josh Cooper commented on HI-298 Re: Update FS layout for hiera PR submitted https://github.com/puppetlabs/hiera/pull/255 but currently blocked. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera ping Josh Cooper should the paths for windows be changed or not? They are currently unchanged. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Hiera / HI-298 Update FS layout for hiera Change By: Eric Thompson Assignee: EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson assigned an issue to Unassigned Hiera / HI-298 Update FS layout for hiera Change By: Eric Thompson Assignee: EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson commented on HI-298 Re: Update FS layout for hiera verified on ubuntu14 at SHA: 17afe97 root@sprmkcgs2s4k48e:~# cat /etc/puppetlabs/code/hiera.yaml --- :backends: - yaml :hierarchy: - defaults - %{clientcert} - %{environment} - global :yaml: # datadir is empty here, so hiera uses its defaults:
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson commented on HI-298 Re: Update FS layout for hiera FR blocked by two tickets above... Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Thompson updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Eric Thompson Comment: verifiedonubuntu14atSHA:17afe97{code}root@sprmkcgs2s4k48e:~#cat/etc/puppetlabs/code/hiera.yaml---:backends:-yaml:hierarchy:-defaults-%{clientcert}-%{environment}-global:yaml:#datadirisemptyhere,sohierausesitsdefaults:#-/etc/puppetlabs/code/hieradataon*nix#-%CommonAppData%\PuppetLabs\hiera\varonWindows#Whenspecifyingadatadir,makesurethedirectoryexists.:datadir:root@sprmkcgs2s4k48e:~#cat/etc/puppetlabs/code/hieradata/global.yamlfoo:baramuroot@sprmkcgs2s4k48e:~#hierafoobaramu{code} Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Steve Barlow updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Steve Barlow Sprint: Language2015-02-04,Language2015-02-18 ,Language2015-03-04 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Henrik Lindberg Labels: AIO Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Josh Cooper commented on HI-298 Re: Update FS layout for hiera Hiera acceptance is failing in the AIO pipeline because it is using beaker 2.2.0, which thinks AIO installs puppet into /opt/puppetlabs/agent/bin See https://jenkins.puppetlabs.com/view/All%20in%20One%20Agent/view/Integrated%20Acceptance/job/platform_aio-component_intn-sys_master/44/ However, the puppet-agent package now installs puppet, facter, hiera, openssl, etc binaries in /opt/puppetlabs/puppet/bin. This ticket should remain open until beaker is updated, see QENG-1841 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Merged to master at: d2c76ed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Hiera / HI-298 Update FS layout for hiera Change By: Thomas Hallgren Assignee: ThomasHallgren Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Henrik Lindberg UPDATE---Thisticketwasreopenedafteradecisionwasmadetochangethepaths.ThisdescriptionhasbeenupdatedtoreflectthedecisionmadeinPUP-3809. ThecomingupdatetotheFSlayoutforourprojectsrequiresseveralchangestodefaultpathingandconfigfilestoensurethatthecorrectdirectoriesareused.Offthetopofmyheadthisincludesdefaultdatadirforhieradata.Thenewlayoutisdescribedhere:https://confluence.puppetlabs.com/display/DEL/Unified+Puppet+Agent+Layout Finaldecisionislistedinthiscomment SpecificallytoHiera,thepathsshouldbe : https://tickets.puppetlabs.com/browse/HI-298?focusedCommentId=132439page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-132439Summary: *Defaultconfigfileonposixis/etc/puppetlabs/ agent/ code/hiera.yaml*Defaultdatadironposixis/etc/puppetlabs/ agent /code/hieradata/*DefaultsaresamewhenusedfromPuppet,Rubylibrary,andcmdline.*Windowsdefaultsdonotchange. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Reopened, (description in this ticket updated). The paths should change and drop the /agent/ part of the paths. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Henrik Lindberg Sprint: Language2015-02-04 ,Language2015-02-18 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Sorenson commented on HI-298 Re: Update FS layout for hiera to the changes, description matches my expectation. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Nicholas Fagerlund updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Nicholas Fagerlund ThecomingupdatetotheFSlayoutforourprojectsrequiresseveralchangestodefaultpathingandconfigfilestoensurethatthecorrectdirectoriesareused.Offthetopofmyheadthisincludesdefaultdatadirforhieradata.Thenewlayoutisdescribedhere:https://confluence.puppetlabs.com/display/DEL/Unified+Puppet+Agent+Layout Finaldecisionislistedinthiscomment:https://tickets.puppetlabs.com/browse/HI-298?focusedCommentId=132439page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-132439Summary:*Defaultconfigfileonposixis/etc/puppetlabs/agent/code/hiera.yaml*Defaultdatadironposixis/etc/puppetlabs/agent/code/hieradata/*DefaultsaresamewhenusedfromPuppet,Rubylibrary,andcmdline.*Windowsdefaultsdonotchange. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kurt Wall commented on HI-298 Re: Update FS layout for hiera TestRailed as C63188 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kurt Wall updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kurt Wall updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Kurt Wall QA Contact: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kurt Wall commented on HI-298 Re: Update FS layout for hiera Verified in master at SHA=98e6271. Hiera looks /etc/puppetlabs for it's config file: # bundle exec hiera --debug foodata [root@jo1qxf3jbpptriv hiera]# bundle exec hiera --debug foodata DEBUG: 2015-02-02 07:43:04 -0800: Hiera YAML backend starting DEBUG: 2015-02-02 07:43:04 -0800: Looking up foodata in YAML backend DEBUG: 2015-02-02 07:43:04 -0800: Looking for data source common DEBUG: 2015-02-02 07:43:04 -0800: Cannot find datafile /etc/puppetlabs/agent/code/hieradata/common.yaml, skipping nil Add Comment
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kurt Wall assigned an issue to Kurt Wall Hiera / HI-298 Update FS layout for hiera Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title John Duarte commented on HI-298 Re: Update FS layout for hiera Testing path change for hiera.yaml is still needed. I have resubmitted https://github.com/puppetlabs/hiera/pull/238 to fix the tests. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera merged to master: 625837a Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Merged to hiera master at https://github.com/puppetlabs/hiera/commit/4d8351bd3e8a82b8e473c8b724c70878f620de5c Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title John Duarte commented on HI-298 Re: Update FS layout for hiera The changes to the expected path of the hiera.yaml file break the acceptance tests. I have submitted https://github.com/puppetlabs/hiera/pull/237 to fix the tests. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title John Duarte commented on HI-298 Re: Update FS layout for hiera The acceptance testing issue has been addressed by https://github.com/puppetlabs/hiera/pull/235 via Justin Stoller. Waiting on CI now. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Henrik Lindberg Fix Version/s: HI2.0.0 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Hiera / HI-298 Update FS layout for hiera Change By: Thomas Hallgren Assignee: ThomasHallgren Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Thomas Hallgren commented on HI-298 Re: Update FS layout for hiera What about Windows? The current defaults are: config_dir = common appdata\PuppetLabs\hiera\etc var_dir = common appdata\PuppetLabs\hiera\var common appdata is C:\ProgramData Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Yes, no action required - we do not need a new puppet setting for hiera datadir. (Initially I thought that was going to be needed, but we decided on a different approach). Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera What is then really missing is the ability to override the default datadir from puppet (and that we add a setting for that in puppet). With those changes the hiera release can remain at 1.4 if I understand things correctly. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Sorenson commented on HI-298 Re: Update FS layout for hiera does that Unblock it? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Eric Sorenson commented on HI-298 Re: Update FS layout for hiera We bashed this out in a room and I have run it by a few people for validation; consensus is the hiera config file (hiera.yaml) should live alongside puppet's config, and the data directory should default to the root of the 'code' directory described in PUP-3809 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Eric Sorenson yes, if we do this for puppet's use of hiera only; all change is on the puppet side, and the free-standing hiera is unchanged as the AIO is all about changing settings in Puppet. Is this correct? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Justin Stoller commented on HI-298 Re: Update FS layout for hiera yes, if we do this for puppet's use of hiera only Can we please get rid of the distinction between hiera-as-used-by-puppet and hiera-used-from-the-command-line. A major bump would be a great time to merge those configs. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera So - decisions have been made: The next hiera release is HI 2.0.0 since we are changing the paths in a non compatible way (i.e. there will be no HI-1 .4.0 release) hiera's lib/hiera/util.rb should be changed so that: hiera's config_dir should be /etc/puppetlabs/agent/code where hiera will load a hiera.yaml if it exists. (Notably, the hiera.yaml should not be under .../agent/config) hiera's var_dir (a.k.a the default datadir) should be a directory named hieradata under the code directory in the AIO packaging i.e. /etc/puppetlabs/agent/code/hieradata. (The data itself cannot be directly in code as the other content in that directory then accidentaly may look like a data directory to hiera). Since the hiera datadir can be modified in hiera.yaml, there is no need to also have an override in puppet (there is no such setting in puppet now). The current puppet setting hiera_config remains as is (reference to $confdir/hiera.yaml which after the fix in PUP-3809 will refer to the AIO config directory). Ensure that hiera's defaults and fallback when hiera.yaml is missing ends up using the paths as documented here If during the cause of implementing this we find we need to prioritize between options, we should optimize on a solution that: makes hiera tooling operate with the same settings as when using puppet prioritize use cases involving combined use of puppet and hiera over those that may install hiera outside of the AIO packaging
Jira (HI-298) Update FS layout for hiera
Title: Message Title John Duarte commented on HI-298 Re: Update FS layout for hiera Henrik Lindberg this decision is currently blocked by the higher level path decision under review in PUP-3809. I have set the PUP ticket as a blocker to this one. cc: Kylo Ginsberg, Matthaus Owens, Justin Stoller, Eric Sorenson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kylo Ginsberg commented on HI-298 Re: Update FS layout for hiera We had some hallway agreement that if the FS layout change is implemented in a non backwards compatible way: a) that is fine, and b) we should call the release 2.0. /cc John Duarte, Matthaus Owens, Justin Stoller, Eric Sorenson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Kylo GinsbergEric Sorenson Matthaus Owens Input on the above question(s) needed - where is hiera supposed to have a the default datadir in AIO ? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera Marked this as blocked as someone must decide what the hiera paths should be in AIO. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Steve Barlow updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Steve Barlow Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Steve Barlow updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Steve Barlow Sprint: Language2015-02-04 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Steve Barlow updated an issue Hiera / HI-298 Update FS layout for hiera Change By: Steve Barlow Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kylo Ginsberg commented on HI-298 Re: Update FS layout for hiera This is a blocker for AIO. Heads up Steve Barlow and Henrik Lindberg. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Henrik Lindberg commented on HI-298 Re: Update FS layout for hiera This seems to mean that we need a release of hiera as well for AIO packaging. The default datadir is hiera's var_dir, and the default configuration is hiera's config_dir. Both are defined in hiera's lib/hiera/util.rb and are currently /etc for config_dir, and /var/lib/hiera for var_dir. Puppet has a setting to override the config_dir in the Puppet setting hiera_config which refers to $confdir/hiera.yaml. I cannot find a similar default in Puppet for hiera backend datadir - it seems to get its default from the values in hiera's util.rb. If I read the confluence page correctly, I think hiera's config_dir should be changed to /etc/puppetlabs/agent/hiera.conf/. For hiera's var_dir, which is not a vardir in the same sense as puppet's vardir (stored under ...agent/cache, the confluence page for AIO does not specify where data should be. Should it be /etc/puppetlabs/hiera/something, or /etc/puppetlabs/agent/hiera/something, or some other place? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Kylo Ginsberg commented on HI-298 Re: Update FS layout for hiera Steve Barlow Henrik Lindberg this is needed for the AIO work so we should see if we can do this in the next sprint. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-298) Update FS layout for hiera
Title: Message Title Matthaus Owens created an issue Hiera / HI-298 Update FS layout for hiera Issue Type: Task Assignee: Unassigned Created: 2014/11/06 3:16 PM Priority: Normal Reporter: Matthaus Owens The coming update to the FS layout for our projects requires several changes to default pathing and config files to ensure that the correct directories are used. Off the top of my head this includes default datadir for hiera data. The new layout is described here: https://confluence.puppetlabs.com/display/DEL/Unified+Puppet+Agent+Layout Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)