Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Phong Ly assigned an issue to qa Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Phong Ly Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Phong Ly assigned an issue to Phong Ly Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Phong Ly Assignee: qa Phong Ly Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Eric Thompson updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Eric Thompson QA Risk Assessment: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Eric Thompson updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Eric Thompson Hiera will silently drops drop malformed hierarchy sources (Those matching /(^\/|\/\/|\/$)/).There should be some notification when this happens. e.g. see attached patch for an example of this. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title John Duarte updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: John Duarte Sprint: Language 2016-08-24 , Language 2016-09-07 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Henrik Lindberg Fix Version/s: HI 3.2.1 Fix Version/s: HI 3.2.2 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg commented on HI-530 Re: Hiera silently drops malformed hierarchy sources Rich tea Thanks for the contribution. I did some housekeeping on the ticket. Once something has been merged, the next state is "Ready for CI", which means that there needs to be a complete acceptance test run with the version in question before the ticket progresses to "Ready for Test" - this is manual testing and a review that the test coverage is suitable (in this case it should be quick). Finally, the ticket goes to Resolved, and it is finally closed/done when the release goes out (In this case the next Hiera release). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Henrik Lindberg Story Points: 1 Sprint: Language 2016-08-24 Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Henrik Lindberg Assignee: Rich tea Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Henrik Lindberg Fix Version/s: HI 3.2.1 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Rich tea commented on HI-530 Re: Hiera silently drops malformed hierarchy sources resolved by Pull #360 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title R.I.Pienaar commented on HI-530 Re: Hiera silently drops malformed hierarchy sources missing sources is normal yes - you might have 100 hosts and only 10 have certname specific files, this should not produce errors/warnings it will be very noisy. badly formed ones should produce errors, though the feedback cycle available to hiera is limited but yeah I think if there's actually a set documented known good thing it should error when a known not good thing is given to it. I suspect the rules arent defined though so ultimately this might just end up as design feedback for lookup rather than fixes to hiera given the place in hieras life cycle. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg commented on HI-530 Re: Hiera silently drops malformed hierarchy sources Rich tea Thanks. I asked about the rules because there is no specification that says why it is doing what it is doing, and there is also no specification of what should happen when using relative paths. For instance, it could be that the skipping is a feature - such that if you have an undefined variable that is used to interpolate a path, and it therefore ends up starting with a slash is actually a feature, and those entries are to be skipped by design. Ping R.I.Pienaar - any input here? While logging warnings is fine, making it a hard error may in practice be disruptive. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title
Rich tea commented on HI-530
Re: Hiera silently drops malformed hierarchy sources
Henrik Lindberg I have created https://github.com/puppetlabs/hiera/pull/360 PR360
As to why, I can see why in the current code the restriction is required the method "datafile_in(datadir, source, extension)" returns the full path and name of the file (if it exists) by adding together a "base directory" (datadir), the "hierarchy source" (source) and extension. Since the source is the middle part of a full file name / path it can not have those pattens. e.g. datadir = " /etc/puppetlabs/code/environments/production/hieradata/" source = "os/${::operatingsystem}" extension = ".json" making the full file path "/etc/hieradata/os/RedHat.json"
It was my original understanding that if a "source" started with a "/" that "datadir" would be skipped, but that is not so.
looking at this now i wonder what would happen if source was something like "../../${::operatingsystem}"
I guess the method "datafile_in" could be modified to check if "source" started with a "/" and not join basedir in if so.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg assigned an issue to Rich tea Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Henrik Lindberg Assignee: Rich tea Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg updated an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Change By: Henrik Lindberg Scrum Team: Language Issue Type: Bug Improvement Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Henrik Lindberg commented on HI-530 Re: Hiera silently drops malformed hierarchy sources Rich tea A PR against the hiera project at github would be appreciated. It is unclear to me why hierarchy sources matching the pattern in question are illegal and ignored in the first place. If you happen to know why that is being done it would also help. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-530) Hiera silently drops malformed hierarchy sources
Title: Message Title Rich tea created an issue Hiera / HI-530 Hiera silently drops malformed hierarchy sources Issue Type: Bug Affects Versions: HI 3.2.0 Assignee: Unassigned Attachments: backend.rb.patch Components: CLI Created: 2016/08/09 10:39 AM Priority: Normal Reporter: Rich tea Hiera will silently drops malformed hierarchy sources (Those matching /(^\/|\/\/|\/$)/). There should be some notification when this happens. e.g. see attached patch for an example of this.
