Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2015-03-06 Thread Anderson Mills (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Anderson Mills commented on  PUP-1046 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: puppet module generate should produce a skeleton spec test  
 
 
 
 
 
 
 
 
 
 
PR 2253 was added in 265290b 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-10-29 Thread Brice Ruth (JIRA)
Title: Message Title










 

 Brice Ruth commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Just a heads up - using puppet 3.7.2, I'm able to get a Gemfile now, and ``bundle install`` works fine, followed by ``bundle exec rake spec``, which fails because some symlinks aren't created for the fixtures. Looking at the rspec-puppet tutorial, it seems like this step isn't completed:

In order for Puppet’s manifest autoloader to work correctly, it expects to find your manifests under modulepath/your module name/manifests/. If we just set the modulepath to the root of your module, it will be missing your module name from the path, so we work around this by creating a directory under spec/fixtures/modules and symlinking your module contents into it







$ mkdir spec/fixtures/modules/your module name




$ cd spec/fixtures/modules/your module name




$ for i in files lib manifests templates; do ln -s ../../../../$i $i; done




$ cd ../../../../







Once I completed these steps, things seem to work as expected. The error I saw before completing this was:






mymodule




  with defaults for all parameters




example at ./spec/classes/init_spec.rb:5 (FAILED - 1)
 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-10-29 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Running `rake spec_prep` handles that for you. This is available since we use puppetlabs_spec_helper https://github.com/puppetlabs/puppet/blob/master/lib/puppet/module_tool/skeleton/templates/generator/Rakefile#L2
When running `rake spec` it should run the equivalent `rake spec_prep  rake spec_standalone  rake spec_clean`. If it is not, that seems like a separate issue.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-10-29 Thread Brice Ruth (JIRA)
Title: Message Title










 

 Brice Ruth commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Fair enough, then it looks like we have a separate issue. I was following the steps from Josh Cooper's comment and that's where I got the error. Should I create an issue for this?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-10-29 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










If you are getting that error only after applying the patch in the aforementioned PR, then this would be the correct forum, else a separate issue would be the place.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-10-29 Thread Brice Ruth (JIRA)
Title: Message Title










 

 Brice Ruth commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










garrett honeycutt - I'm not sure I'm following ... is there a PR in-flight that fixes this but isn't in 3.7.2? The only ones I've seen have been merged as far as I can tell. Last reference was to #2612 for 

PUP-2432
, but that made it into 3.7.0 if I'm reading the comments correctly?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-10-29 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Brice, you've got me confused. How can I reproduce your issue?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-08-19 Thread Anderson Mills (JIRA)
Title: Message Title










 

 Anderson Mills updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Anderson Mills




Assignee:

 PietervandeBruggen AndersonMills












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-08-18 Thread Eric Sorenson (JIRA)
Title: Message Title










 

 Eric Sorenson commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










ping Pieter van de Bruggen, I'm going to remove this from 3.7.0 so it's not blocking the release, but could this get some attention?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-08-18 Thread Eric Sorenson (JIRA)
Title: Message Title










 

 Eric Sorenson updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Eric Sorenson




Fix Version/s:

 3.7.0












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-08-18 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Anything you need from me to help get this merged?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-06-18 Thread Kenn Hussey (JIRA)
Title: Message Title










 

 Kenn Hussey updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Kenn Hussey




Sprint:

 Week2014-6-18to2014-6-25












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-06-17 Thread Kenn Hussey (JIRA)
Title: Message Title










 

 Kenn Hussey updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Kenn Hussey




Sprint:

 Week2014-7-2to2014-7-9












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-06-17 Thread Kenn Hussey (JIRA)
Title: Message Title










 

 Kenn Hussey updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Kenn Hussey




Sprint:

 Week2014- 7 6 - 2 18 to2014- 7 6 - 9 25












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-06-08 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Kylo Ginsberg




Component/s:

 PMT












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-06-03 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Pieter van de Bruggen I was not able to get the skeleton spec test to work correctly. Can you take a look at this?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-06-03 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Joshua Cooper




Assignee:

 JoshuaCooper PietervandeBruggen












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Andy Parker




Sprint:

 Week2014-5-14to2014-5-21












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Andy Parker




Sprint:

 Week2014-5-14to2014-5-21












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Kylo Ginsberg




Fix Version/s:

 3.6.1




Fix Version/s:

 3.7.0












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread Eric Sorenson (JIRA)
Title: Message Title










 

 Eric Sorenson commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










kicking this over because the code is still in flight; Garrett if you can help get the code polished up and it gets merged in the next week or so it can be in 3.6.1 but I'm targeting it at 3.7.0.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread Eric Sorenson (JIRA)
Title: Message Title










 

 Eric Sorenson updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Eric Sorenson




Assignee:

 JoshuaCooper












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Eric Sorenson Happy to help, what do you need from me? As I understand it, this ticket is waiting on PUP-2432 which has an open PR - https://github.com/puppetlabs/puppet/pull/2612 - that is waiting on being merged.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-14 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










garrett honeycutt I added a comment to PR 2612 for PUP-2432. In the meantime, it would be great if you could add a Gemfile as part of this PR, to pull in the dependencies that the skeleton requires:


puppetlabs_spec_helper
puppet-lint
puppet
rake
rspec



that way it should be possible to test the module with:


$ gem install bundler
$ bundle install
$ bundle exec rake spec















   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)


 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-05 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds updated an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Change By:

 Rob Reynolds




Fix Version/s:

 3.6.0




Fix Version/s:

 3.6.1












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-02 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










It generates a spec file, but doesn't generate a Gemfile. So if you don't have puppetlabs_spec_helper, puppet-lint, and puppet (and its dependencies) installed, the rake task blows up:


$ rake spec
/Users/josh/.rbenv/versions/1.9.3-p392/bin/ruby -S rspec spec/classes/init_spec.rb --color
/Users/josh/.rbenv/versions/1.9.3-p392/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- puppet (LoadError)
	from /Users/josh/.rbenv/versions/1.9.3-p392/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:55:in `require'
/Users/josh/.rbenv/versions/1.9.3-p392/bin/ruby -S rspec spec/classes/init_spec.rb --color failed



But it still fails after manually installing necessary gems (not sure about which versions the skeleton Rakefile is expecting):


$ gem install puppetlabs_spec_helper
$ gem install puppet-lint
$ gem install puppet
$ gem install autorun
$ gem install rake rspec



it still fails due to require 'spec/autorun':


$ rake spec
...
/Users/josh/.rbenv/versions/1.9.3-p392/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_require.rb:126:in `require': cannot load such file -- spec/autorun (LoadError)



If I comment that require out from the spec_helper.rb, it generates deprecation warnings along with a hard NameError


$ rake spec
...
DEPRECATION: Spec::Runner.configure is deprecated. Use RSpec.configure instead. Called from /Users/josh/work/puppet/foo-bar/spec/spec_helper.rb:9:in `top (required)'.
/Users/josh/work/puppet/foo-bar/spec/spec_helper.rb:16:in `class:Object': undefined method `should' for class `Object' (NameError)















   

 Add Comment

















  

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-02 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Looks like Thebo already merged my code for this https://github.com/puppetlabs/puppet/pull/2253 and it did not include autorun. Not sure where you are getting that from as the errors above do not reference what code you are testing with.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-02 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










Do you want a PR for a Gemfile?












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-02 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 











and it did not include autorun. Not sure where you are getting that from as the errors above do not reference what code you are testing with.

It's coming from the spec_helper skeleton
It's also calling the deprecated method for configuring rspec

Do you want a PR for a Gemfile?

Yes, please open a separate ticket and PR for that.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 



 

Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-02 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










https://github.com/puppetlabs/puppet/pull/2611












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-05-02 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










sorry @josh created a new ticket PUP-2432 for this.












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2014-01-13 Thread garrett honeycutt (JIRA)
Title: Message Title










 

 garrett honeycutt commented on an issue


















  Re: puppet module generate should produce a skeleton spec test 










PR - https://github.com/puppetlabs/puppet/pull/2253












   

 Add Comment

























 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 







 # Overview #   In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.   I think the example could simply add the class to the catalog and make sure it got added.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


Jira (PUP-1046) puppet module generate should produce a skeleton spec test

2013-12-16 Thread redmine.exporter (JIRA)
Title: Message Title










 

 redmine.exporter created an issue


















 Puppet /  PUP-1046



  puppet module generate should produce a skeleton spec test 










Issue Type:

  New Feature




Assignee:


 Unassigned




Created:


 16/Dec/13 4:00 AM




Labels:


 redmine




Priority:

  Normal




Reporter:

 redmine.exporter












Overview #


In order to make `rake spec` give meaningful feedback with a module generated using `puppet module generate` once #11285 is implemented, the generate action should produce an example rspec-puppet based spec test for the module.
I think the example could simply add the class to the catalog and make sure it got added.












   

 Add Comment