Jira (PUP-10723) Shadow fact / plan variable collisions in PAL catalog compiler
Title: Message Title Tom Beech updated an issue Puppet / PUP-10723 Shadow fact / plan variable collisions in PAL catalog compiler Shadow fact/variable collisions in PAL catalog compiler. Change By: Tom Beech Release Notes: Bug Fix Release Notes Summary: Shadow fact/variable collisions in PAL catalog compiler. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-10723) Shadow fact / plan variable collisions in PAL catalog compiler
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10723 Shadow fact / plan variable collisions in PAL catalog compiler Change By: Josh Cooper Fix Version/s: PUP 7.0.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.375600.1603318914000.114351.1610558460139%40Atlassian.JIRA.
Jira (PUP-10723) Shadow fact / plan variable collisions in PAL catalog compiler
Title: Message Title Josh Cooper commented on PUP-10723 Re: Shadow fact / plan variable collisions in PAL catalog compiler Looks like was merged to master in https://github.com/puppetlabs/puppet/commit/faed64577d7c39b384cb8330f117d30e988af4c7 and was first released in 7.0, and is now being released in 6.20. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.375600.1603318914000.114350.1610558460096%40Atlassian.JIRA.
Jira (PUP-10723) Shadow fact / plan variable collisions in PAL catalog compiler
Title: Message Title Gheorghe Popescu commented on PUP-10723 Re: Shadow fact / plan variable collisions in PAL catalog compiler Tom Beech is the work here done? Can you please add release notes and close the ticket if so? Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.375600.1603318914000.114152.1610547480075%40Atlassian.JIRA.
Jira (PUP-10723) Shadow fact / plan variable collisions in PAL catalog compiler
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10723 Shadow fact / plan variable collisions in PAL catalog compiler Change By: Gheorghe Popescu Fix Version/s: PUP 6.20.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.375600.1603318914000.114126.1610546940107%40Atlassian.JIRA.
Jira (PUP-10723) Shadow fact / plan variable collisions in PAL catalog compiler
Title: Message Title Tom Beech created an issue Puppet / PUP-10723 Shadow fact / plan variable collisions in PAL catalog compiler Issue Type: Improvement Assignee: Tom Beech Created: 2020/10/21 3:21 PM Priority: Normal Reporter: Tom Beech Current Behavior **When Bolt runs an apply block in a plan, it uses PAL to compile a catalog. Before calling PAL.with_catalog_compiler, Bolt detects any collisions between facts, target vars, and plan vars, and shadows them as needed (see https://github.com/puppetlabs/bolt/blob/main/lib/bolt/catalog.rb#L71-L88) . However, this can cause a potential problem when plan variables are using local references. If plan variable $bar has a reference to plan variable $foo, and the target has a fact foo, Bolt will shadow the plan variable $foo. When the variables are passed on to the catalog compiler, PAL will be unable to deserialize the plan variables as the local reference for $bar is no longer valid (see https://github.com/puppetlabs/bolt/issues/2111). Desired Behavior Shadowing variables that collide with facts of the same name should not result in PAL being unable to deserialize plan variables due to a missing local reference. Because FromDataConverter assumes that the data it receives comes directly from ToDataConverter, the serialized plan variables should be passed as-is to the catalog compiler where they can be deserialized. After the plan variables are deserialized, PAL should then shadow any variables that collide with facts of the same name (and warn when this happens).
