Jira (PUP-10781) If file resource content changes during puppet run, it uses original file checksum although content is retrieved several times

2020-11-17 Thread Patrick Grant (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Patrick Grant commented on  PUP-10781  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: If file resource content changes during puppet run, it uses original file checksum although content is retrieved several times   
 

  
 
 
 
 

 
 Closing this in favor of PUP-3916, will add the support case there for traction  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.378054.1605178578000.80958.1605614580027%40Atlassian.JIRA.


Jira (PUP-10781) If file resource content changes during puppet run, it uses original file checksum although content is retrieved several times

2020-11-12 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-10781  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: If file resource content changes during puppet run, it uses original file checksum although content is retrieved several times   
 

  
 
 
 
 

 
 The downloading twice issue is PUP-3916 and is due to the way puppet determines if a resource is insync and if so, enforces compliance. The file diff is calculated in the first step, because we want to show what would happen when running in noop mode, as step 2 never happens. Puppet has always worked this way, but is only a hard failure due to PUP-10368, as puppet strictly enforces that the file it is about to commit matches the desired checksum, either specified in the manifest or retrieved from the source via file_metadata. Previously puppet was "lenient". Since puppet makes two requests for metadata and content, there is always a race condition where the content can change in between. I'd argue that setting the checksum type to mtime is probably the correct thing here, since you can't definitively say what the md5/sha256 checksum is.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.378054.1605178578000.78073.1605209460034%40Atlassian.JIRA.


Jira (PUP-10781) If file resource content changes during puppet run, it uses original file checksum although content is retrieved several times

2020-11-12 Thread Patrick Grant (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Patrick Grant created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10781  
 
 
  If file resource content changes during puppet run, it uses original file checksum although content is retrieved several times   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2020/11/12 2:56 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Patrick Grant  
 

  
 
 
 
 

 
 Puppet Version: 6.17.0 Puppet Server Version: 6.12.1 OS Name/Version: Rhel7 If file resource content changes during a puppet run, although content of the file is retrieved several times, its continues to use the first retrievals checksum Steps from customer testing: 
 
Starting with empty file (checksum d41d8) 
  
 
 
 
 
 2020-11-05 12:57:34 +0100 Puppet (debug): HTTP GET https://testmaster:8140/puppet/v3/file_metadata/skv_files/bigfile?links=manage_type=md5_permissions=ignore=che_mini returned 200 OK  
 
 
 2020-11-05 12:57:34 +0100 Puppet (debug): Caching connection for https://testmaster:8140  
 
 
 2020-11-05 12:57:34 +0100 Puppet (debug): Using cached connection for https://testmaster:8140  
 
 
 2020-11-05 12:57:34 +0100 Puppet (debug): HTTP GET