Jira (PUP-10890) empty lookup_options

2021-08-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10890  
 
 
  empty lookup_options   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.111492.1629316560100%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-08-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10890  
 
 
  empty lookup_options   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.25.0  
 
 
Fix Version/s: 
 PUP 7.11.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.111493.1629316560145%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-08-18 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-10890  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: empty lookup_options   
 

  
 
 
 
 

 
 ah yeah I can reproduce, I created a simple module mytest containing: ./manifests/init.pp  
 
 
 
 
 class mytest {  
 
 
   notice(lookup('key'))  
 
 
 }
  
 
 
 
  ./data/common.yaml  
 
 
 
 
 ---  
 
 
 lookup_options:  
 
 
 mytest::key: from module
  
 
 
 
  ./hiera.yaml  
 
 
 
 
 [root@sized-ballerina mytest]# cat  hiera.yaml   
 
 
 ---  
 
 
 version: 5  
 
 
    
 
 
 hierarchy:  
 
   

Jira (PUP-10890) empty lookup_options

2021-06-03 Thread Beth Glenfield (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Beth Glenfield updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10890  
 
 
  empty lookup_options   
 

  
 
 
 
 

 
Change By: 
 Beth Glenfield  
 
 
Labels: 
 community  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.47122.1622709780036%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-02-06 Thread Chris Denneen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Chris Denneen commented on  PUP-10890  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: empty lookup_options   
 

  
 
 
 
 

 
 @Josh Cooper the issue is seen when the module has empty hash (I had the old keys actually commented out) and you run a “pdk test unit”. Should be pretty straight forward to reproduce?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.135095.1612614960030%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-02-06 Thread Henrik Lindberg (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-10890  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: empty lookup_options   
 

  
 
 
 
 

 
 line 288 is weird with two trailing unless - I think it errors as it should if value is neither nil nor a hash. Then it returns options as is if modulename is not given. Then it will fail if options are nil on line 292. The correct thing is probably to change line 293 to read:   
 
 
 
 
 return options if module_name.nil? || options.nil?
  
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.135094.1612612980050%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-02-05 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-10890  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: empty lookup_options   
 

  
 
 
 
 

 
 That's odd. That line is https://github.com/puppetlabs/puppet/blob/901a6296a8f0a19849ef35575a78b7ad3dd377f4/lib/puppet/pops/lookup/lookup_adapter.rb#L292, but we check for a nil options above on line 288 and those lines haven't changed for several years. Going to need more information on how to reproduce this.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.386484.1612558652000.134964.1612563300157%40Atlassian.JIRA.


Jira (PUP-10890) empty lookup_options

2021-02-05 Thread Chris Denneen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Chris Denneen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10890  
 
 
  empty lookup_options   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/02/05 12:57 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Chris Denneen  
 

  
 
 
 
 

 
 Doing a test on a module with hiera that has an empty `lookup_options:` will result in errors during unit tests like    
 
— Caused by: — 
NoMethodError: 
undefined method `each_pair' for nil:NilClass 
/opt/puppetlabs/pdk/private/puppet/ruby/2.4.0/gems/puppet-5.5.21/lib/puppet/pops/lookup/lookup_adapter.rb:292:in `validate_lookup_options' 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment