Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-10-06 Thread Parker Leach (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Parker Leach updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Parker Leach  
 
 
Labels: 
 docs_reviewed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.42829.1665092400094%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-10-05 Thread Michael Hashizume (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Hashizume updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Michael Hashizume  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 Puppet no longer errors when loading an empty task metadata file.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.42354.1665011340034%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-10-04 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-11629  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
 Verified a task with empty metadata is treated as though the file was missing:    
 
 
 
 
 root@irritating-yell:~# cat test.rb   
 
 
 require 'puppet'  
 
 
    
 
 
 Puppet.initialize_settings  
 
 
    
 
 
 environmentpath = Puppet[:environmentpath]  
 
 
 basemodulepath = Puppet::Node::Environment.split_path(Puppet[:basemodulepath])  
 
 
 directories = Puppet::Environments::Directories.from_path(environmentpath, basemodulepath)  
 
 
 loaders = Puppet::Environments::Cached.new(  
 
 
   Puppet::Environments::Combined.new(*directories)  
 
 
 )  
 
 
 env = loaders.get!(Puppet[:environment])  
 
 
 mod = env.module('test')  
 
 

Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-10-04 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.29.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.41501.1664921640030%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-10-03 Thread Michael Hashizume (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Hashizume assigned an issue to Michael Hashizume  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Michael Hashizume  
 
 
Assignee: 
 Michael Hashizume  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.39903.1664817840036%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-30 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-11629  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
 The JSON spec says: 

A string is a sequence of zero or more Unicode characters
 Ruby's default JSON gem, accepts empty string, but multi_json does not, even when using default JSON gem as the multi_json backend. I filed a bug upstream https://github.com/intridea/multi_json/issues/206. For puppet, I think we want to accept empty strings and return nil.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.39308.1664564700038%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-22 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Epic Link: 
 PUP- 11618 11619  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.35579.1663867080028%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-22 Thread Morgan Rhodes (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Morgan Rhodes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Morgan Rhodes  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.35556.166380068%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11618  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.34852.1663789980038%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 6.29.0  
 
 
Fix Version/s: 
 PUP 7.20.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.34607.1663779120085%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Phoenix 2022-10-12  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.34605.1663779060140%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.468437.1663778931000.34602.166377997%40Atlassian.JIRA.


Jira (PUP-11629) Puppet::Util::Json raises when reading an empty file

2022-09-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11629  
 
 
  Puppet::Util::Json raises when reading an empty file   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2022/09/21 9:48 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 See details in PE-34535, a portion of the stack trace is below:  
 
 
 
 
 2022-09-08T15:05:11.285-04:00 ERROR [qtp2123677471-318634] [p.r.core] Internal Server Error: org.jruby.exceptions.RuntimeError: (InvalidMetadata) JSON::ParserError  
 
 
 at opt.puppetlabs.puppet.lib.ruby.vendor_ruby.puppet.module.task.read_metadata(/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/module/task.rb:240)  
 
 
 at opt.puppetlabs.puppet.lib.ruby.vendor_ruby.puppet.module.task.metadata(/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/module/task.rb:244)  
 
 
 at opt.puppetlabs.puppet.lib.ruby.vendor_ruby.puppet.info_service.task_information_service.tasks_per_environment(/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/info_service/task_information_service.rb:9)
  
 
 
 
  Puppet