Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title Bjoern Lippert commented on an issue Re: Type exec is executed, although required type failed Hello Charlie, exactly, the seen behaviour could be led back to PUP-1106. So in my special case, each exec in the called define get a refresh event due to the define calling routine in the surrounding define (aka. the calling define) has a subscribe to another resource. I guess I've got no other choice than finding a workaround for me. However in my opinion the current behaviour is logically wrong and should be changed. Regards Bjoern Add Comment Puppet / PUP-1456 Type exec is executed, although required type failed An exec-type is executed although a required type (an exec, too) has failed. The strange thing is, that when doing an agent run ,the output of puppet agent --test says Skipping because of failed dependency. The output is correct (as expected), but nevertheless the exec-type gets executed. As I have problems in my productive code, that woul... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you
Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-1456 Type exec is executed, although required type failed Change By: Charlie Sharpsteen Assignee: BjoernLippert Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title Charlie Sharpsteen commented on an issue Re: Type exec is executed, although required type failed So, one issue that is contributing here is PUP-1106. Basically, failed dependencies are not taken into account when resources process refresh events. So, it doesn't matter if any require = [...] or subscribe = [...] resources failed. When a resource receives a refresh event, it will refresh. As far as I can tell, this has been the behavior in all of 2.7.x and 3.x. It has possibly been the behavior since the dawn of time. Additionally, failed refreshes don't count as failed when dependencies are checked. So, the failure of a refreshonly won't halt the syncing of a dependency chain (PUP-2280). Bjoern: Do either of these issues seem like the cause of the behavior you were seeing? Add Comment Puppet / PUP-1456 Type exec is executed, although required type failed An exec-type is executed although a required type (an exec, too) has failed. The strange thing is, that when doing an agent run ,the output of puppet agent --test says Skipping because of failed dependency. The output is correct (as expected), but nevertheless the exec-type gets executed. As I have problems in my productive code, that woul... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title Trevor Vaughan commented on an issue Re: Type exec is executed, although required type failed I had a similar issue where puppet agent would not honor both 'unless' and 'onlyif' in the same exec. Puppet apply handled it properly making for an exciting time tracking down the issue. This is in 2.7.24. I'm not sure if it still happens in 3.X but it seems like it might be relevant. Add Comment Puppet / PUP-1456 Type exec is executed, although required type failed An exec-type is executed although a required type (an exec, too) has failed. The strange thing is, that when doing an agent run ,the output of puppet agent --test says Skipping because of failed dependency. The output is correct (as expected), but nevertheless the exec-type gets executed. As I have problems in my productive code, that woul... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving
Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title
Bjoern Lippert created an issue
Puppet / PUP-1456
Type exec is executed, although required type failed
Issue Type:
Bug
Affects Versions:
3.2.3, 3.4.2
Assignee:
Unassigned
Created:
16/Jan/14 8:42 AM
Environment:
master and agent running on Ubuntu 10.04.4 LTS 64bit
Priority:
Major
Reporter:
Bjoern Lippert
An exec-type is executed although a required type (an exec, too) has failed. The strange thing is, that when doing an agent run ,the output of puppet agent --test says Skipping because of failed dependency. The output is correct (as expected), but nevertheless the exec-type gets executed.
As I have problems in my productive code, that would be to complex to post it here, I use pseudo/abstract code to describe the problem. Mention that the strange behaving code is included in a separate puppet define (not a class) in a separate file.
module::path::to::the_strange_define { uniqueName: ... some parameters ... require = ... }
remark: When running puppet and the define is called, I see the output Scheduling refresh of Exec[...] for each puppet-type within the define.
Now the code of the_strange_define itself:
[...] $condition = a bash test condition used in all exec-types below # is always
Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title
Bjoern Lippert updated an issue
Puppet / PUP-1456
Type exec is executed, although required type failed
Change By:
Bjoern Lippert
Anexec-typeisexecutedalthougharequiredtype(anexec,too)hasfailed.Thestrangethingis,thatwhendoinganagentrun,theoutputofpuppetagent--testsaysSkippingbecauseoffaileddependency.Theoutputiscorrect(asexpected),butneverthelesstheexec-typegetsexecuted.AsIhaveproblemsinmyproductivecode,thatwouldbetocomplextopostithere,Iusepseudo/abstractcodetodescribetheproblem.Mentionthatthestrangebehavingcodeisincludedinaseparatepuppetdefine(notaclass)inaseparatefile. {code:title=thecallingdefine} module::path::to:: the_calling_define(...){ #...lotsofcode module::path::to:: the_strange_define{uniqueName: ...someparameters... require=... , } #...lotsofcode }{code} remark:Whenrunningpuppetandthedefineiscalled,Iseetheoutput {color:green} SchedulingrefreshofExec \ [... \ ] {color} foreachpuppet-typewithinthe called define. Nowthecodeofthe_strange_defineitself: {code:title=thecalleddefinewiththeexec-typeproblem} [...]$condition=abashtestconditionusedinallexec-typesbelow#isalwaystrueexec{e1:[...]onlyif=$condition,#conditionisok,e1commandgetsexecutedcommand=somebashscriptcallinggeneratingafile,#thatscriptFAILSreturning1(asaresultthefilewasn'tgenerated,too);Output frompuppet :...returned1insteadofoneof[0]}exec{e2:[...]onlyif=$condition,#conditionstillok,e2commandwouldbeexecuted,ifrequirewouldbeok,butitisnot:require= Exec[e1] ,#requirefails...leadstodebugoutputSkippingbecauseoffaileddependencycommand=anotherbashinstructionmovingawaytheine1createdfile,#isnotexecuted,becauserequirefailed}Herecomesthestrangething:exec{e6:[...]onlyif=$condition,#conditionstillok,e3commandwouldbeexecuted,ifrequirewouldbeok(isnot)require= Exec[e2] ,#requirefails...leadstodebugoutputSkippingbecauseoffaileddependency#require= [Exec[e1],Exec[e2]] ,#I'vetriedthis,butitmakesnodifferencetolinebeforecommand=againanotherbashcommandunzippingfiles,#shouldnotbeexecuted,becauserequirefailed,BUTitisexecuted} {code} Thedebugoutputsays(inorder): \ [... \ ]Notice:...Exec \ [e3 \ ]:DependencyExec \ [e1 \ ]hasfailures:true {color:red} Warning:...Exec \ [e3 \ ]:Skippingbecauseoffaileddependencies {color} Notice:...Exec \ [e3 \ ]:Triggered'refresh'from1events {color:green} Info:...Exec \ [e3 \ ]:SchedulingrefreshofExec \ [e7 \ ] {color} #Exec \ [e7 \ ]subscribesExec \ [e6 \ ].AsExec \ [e7 \ ]isscheduledforrefresh,thisisanindicatorthatExec \ [e6 \ ]wasexecutedsuccessfully \ [... \ ]Tosumitup:Exece1fails,that'swhye2isskipped(Icheckedthat).Allotherexecs(e3,e4,e5)requiree2andwereskipped,EXCEPTofe6althoughpuppetsaysskipping.Exece7subscribese6,andgetsscheduledforrefresh,butisdependency-skippedbecauserequirede6failed.I'veusemycodesincepuppet3.0.xandI'mquitesure,thatitwasworkingcorrectly.ThisissuewasreportedtomesinceI'vebeenusing3.2.xbutevenafterupgradingtodayto3.4.3(masterandagentintestenvironment)theissuestillpersists.MaybeIdidn'tconsideraverybasicpuppetbehaviour,butmaybeitisnot.TutorialsandGoogledidn'thelp.However,Ican'tfigureoutformysel,soIrequestassistance.ThankyouBjoern
Jira (PUP-1456) Type exec is executed, although required type failed
Title: Message Title Bjoern Lippert updated an issue Puppet / PUP-1456 Type exec is executed, although required type failed Change By: Bjoern Lippert Environment: master (passenger) andagentrunningonUbuntu10.04.4LTS64bit Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
