Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Steve Barlow updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Steve Barlow Scope Change Reason: Capacitywasfree Scope Change Category: Adopted Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Eric Thompson commented on PUP-1806 Re: Varargs support for the new function API thanks, Henrik. i hit add too quickly. i'm still working on covering all the bases here... Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Eric Thompson commented on PUP-1806 Re: Varargs support for the new function API verified on rhel7 at SHA: 2458a71 [root@fe3bsczu8tto8hg functions]# puppet apply -e 'notice(varargs(1, 2))' Notice: Scope(Class[main]): 1 Notice: Compiled catalog for fe3bsczu8tto8hg.delivery.puppetlabs.net in environment production in 0.40 seconds Notice: Applied catalog in 0.01 seconds [root@fe3bsczu8tto8hg functions]# cat varargs.rb Puppet::Functions.create_function(:varargs) do dispatch :min do param 'Numeric', :d1 param 'Numeric', :d2 end
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API Eric Thompson it is optional_param and repeated_param that are new Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Eric Thompson updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Eric Thompson updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Eric Thompson QA Contact: KurtWall EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-1806 Varargs support for the new function API Change By: Eric Thompson Assignee: QA EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-1806
Varargs support for the new function API
Change By:
Henrik Lindberg
ThereneedstobesomewayofspecifyvarargsinthenewfunctionAPI,butinawaythatstillletsusdosometypecheckingofthearguments. Update UPDATE Theold{{arg_count}}and{{last_captures_rest}}methodsshouldberemovedandreplacedbyspecificmethods:*{{param}}or{{required_param}}forparametersthatmustbegiven*{{optional_param}}forparametersthatmaybemissing*{{repeated_param}}foraparameterthatmayoccur0-manytimesofthegiventypeAn{{optional_param}}maynotbefollowedbya{{required_param}},theremayonlybeone{{repeated_param}}anditcanonlyappearlast.Consequently,thereshouldbea{{block_param}}methodthatisanaliasfor{{required_block_param}} ForDocumentation:Thelanguagespecificationcontainsthedescriptionofthe4xfunctionapiinthefile'func-api.md'
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API For manual test/functional review, see the https://github.com/puppetlabs/puppet-specifications/blob/master/language/func-api.md specification. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Component/s: DOCS Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg assigned an issue to QA Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Status: Readyfor CI Test Assignee: QA Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API merged to stable: c1135c5 and to master. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API After additional bike shedding we decided on presence and repeated - updating the description. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API We decided to use the term repeated instead of capturing. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-1806
Varargs support for the new function API
Change By:
Henrik Lindberg
ThereneedstobesomewayofspecifyvarargsinthenewfunctionAPI,butinawaythatstillletsusdosometypecheckingofthearguments. UpdateTheold{{arg_count}}methodshouldberemovedandreplacedbyasettingperparameter:*{{required}}forparametersthatmustbegiven*{{optional}}forparametersthatmaybemissing*{{repeated}}foraparameterthatmayoccur0-manytimesofthegiventypeAn{{optional}}maynotbefollowedbya{{required}},theremayonlybeone{{repeated}}anditcanonlyappearlast.
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Comment: Thanks! Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-1806
Varargs support for the new function API
Change By:
Henrik Lindberg
ThereneedstobesomewayofspecifyvarargsinthenewfunctionAPI,butinawaythatstillletsusdosometypecheckingofthearguments.UpdateTheold{{arg_count}} method and{{last_captures_rest}}methods shouldberemovedandreplacedbyasettingperparameter:*{{required}}forparametersthatmustbegiven*{{optional}}forparametersthatmaybemissing*{{repeated}}foraparameterthatmayoccur0-manytimesofthegiventypeAn{{optional}}maynotbefollowedbya{{required}},theremayonlybeone{{repeated}}anditcanonlyappearlast.
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title
Thomas Hallgren updated an issue
Puppet / PUP-1806
Varargs support for the new function API
Change By:
Thomas Hallgren
Comment:
Wedecidedtousetheterm{{repeated}}insteadof{{capturing}}.
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API We ended up with a continued bike shedding discussion, as not of the names we decided on was appealing. When also looking at the methods for defining block parameters we decided that the best was to use specific methods everywhere - specification is now updated as well as the description above. This solution is better as it does not require an extra parameter (that needs to be given, asserted etc.). Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-1806
Varargs support for the new function API
Change By:
Henrik Lindberg
ThereneedstobesomewayofspecifyvarargsinthenewfunctionAPI,butinawaythatstillletsusdosometypecheckingofthearguments.UpdateTheold{{arg_count}}and{{last_captures_rest}}methodsshouldberemovedandreplacedby asettingperparameter specificmethods :*{{ required param }} or{{required_param}} forparametersthatmustbegiven*{{ optional optional_param }}forparametersthatmaybemissing*{{ repeated repeated_param }}foraparameterthatmayoccur0-manytimesofthegiventypeAn{{ optional optional_param }}maynotbefollowedbya{{ required required_param }},theremayonlybeone{{ repeated repeated_param }}anditcanonlyappearlast. Consequently,thereshouldbea{{block_param}}methodthatisanaliasfor{{required_block_param}}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API How about 'presence' ? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API It's killing me trying to come up with a name for this optional third parameter. We have type, name, and ???. The term 'cardinality' seems somewhat correct (:required, :optional, and :capturing implies 1-1, 0-1 or 0-M) but the again, cardinality is all about numbers. The term 'parameter_type' would be OK if it wasn't used in the same context as the 'type' of the parameter. I thought about 'binding_type' (how values are bound to the parameter) but this is not injection. Perhaps 'value_type', 'name', and 'parameter_type' ? Ideas and suggestions welcome. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API How about 'presence' ? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API Thanks! Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API When the term is presence, the variable case should be named captured instead of capturing. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API I can't make sense of this statement: T means Array[T], and if min/max is wanted the type should be given as Array[T]. Do you mean that for a :capturing parameter, T will be converted into Array[T] unless it is already an Array? If so, then I think it's somewhat both confusing and ambiguous. I can't find an explanation for this in the spec. What happens if T is Variant[Array[X],Array[Y]]? Will it too be converted to Array[T]? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Sprint: Language2015-03-04 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API I updated the earlier comment slightly to make it clearer. A :capturing parameter will iff getting a type t such that t.class != PArrayType wrap that into Array[t]. A :capturing parameter will iff getting a type t such that t.class == PArrayType take that as the specification of element type and min/max By applying those rules, the case of t being Variant[Array[X], Array[Y] means that the variant t will be wrapped into Array[t]. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API Given the above, I think it is clearer to specify the element type of the varargs, and adding two additional parameters for min and max. I wish we could do the same in the language but it means adding syntax. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API Alright - decision reached: :required - is the default for a parameter, may be spelled out. The parameter must be given in the call :optional - the parameter may be missing in the call. May not be used on a parameter that is followed by a :required parameter :capturing - the type specifies a repeating type that occurs 0 to infinite number of times. It may only appear last. The rationale for dropping the ability to specify min and max is that max is not needed in practice, and a min is obtained by preceding the :capturing with a required parameter, and then changing how the parameters are used at the receiving end of the dispatch (this is also rarely needed). Not sure if we should simply remove the arg_count method. It is unlikely that there are modules out there with 4x functions using it, but we do not know for sure. We could add a deprecation warning and remove it later. If we keep it, we may need to slightly modify its semantics (ignoring max essentially), and probably error if it is used mixed with the new ability. An outright removal is easier to handle. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API If not :varargs, then I think :splat is a better choice. To me :captures makes good sense together with min/max arguments but not alone. The reason I think min/max is unnecessary is that I don't think anyone ever writes a function that needs 2 - 10 integers. When a specific number of integers is needed they would most likely be declared by name. And even if a use case can be found where min/max would be needed, why pass a type-constrained array as or tuple as one parameter for such cases? I think there's great value in keeping this simple and easy to understand. I spent a fair amount of time trying to grasp the by the arg_count parameter because it was a concept that I'd never seen before in a method signature. Having it on each parameter makes it even harder to understand. Or perhaps you just want it on the last parameter? If so, it's in essence the same thing as the current arg_count. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API We are missing the ability to specify min and max for variable number of arguments. My proposal is exactly what you propose, only that if you want to specify min/max for a varags/captures, you give that as a hash of options instead of separate arguments. We could naturally accept min, max as additional (optional arguments, with min being 0 by default, and max being infinity). Not sure :varags is a relevant name for puppet users / ruby users who may think more like splat make the variable capture the rest - this also because optional arguments also makes it possible to call with a variable number of arguments. This was the reason I choose :captures. i.e. I am fine with this: param 'Integer', :the_rest, :captures, 2, 10 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API I think the suggested arguments with :optional and :required is fine but then it gets too complicated. Why not add a :varargs instead and forget about the more complex ways of defining things. I can't see the benefit in expressing the details. The disadvantage is that the more advanced this concept gets, the harder it will become to document it in a way that is easy to read. So how about just adding a third parameter that is :required, :optional, or :varargs and skip the details? What actual use-case is not covered by doing that? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API The min max should only optionally be allowed on the last :captures variable, the others are implicitly 1:1 for require and 0:1 for optional (and cannot be changed/given). You can naturally not have a min on the capturing parameter if there are optional parameters before it. I don't like the name :splat - it is puppet/ruby-speak for the unary * operator - and it has dual purpose, it means unfold, and capture depending on where it is used. The term :captures is not great as it is on a different form than :optional and :required, it should really be :capturing, or :capturing_rest, but they are kind of heavy. I considered the term :variable but that is really confusing. Thought about a bunch of other names for it that I did not like (on the themes 'array', 'remaining', 'fold', 'spill over', 'excess', 'extra', 'additional', 'zero-many', 'multiple', etc. etc.). Think :capturing is readable both with and without min/max args. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API Why not use a type instead, to describe min/max (and other aspects)? We can then have :required, :optiona, or :unfold. When :unfold is used, the parameter type must be an Array or a Tuple. Simple solution, yet with brings all advantages. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API :unfold should also accept a Variant tree as long as all leafs are of type Array or Tuple. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Thomas Hallgren commented on PUP-1806 Re: Varargs support for the new function API but thinking more about name, we actually need a name that does mean both unfold and capture in order to be varargs. In that respect, I think the term :splat is OK. And it is well known by a large percentage of the users. Both :unfold and :capturing suffers from just catching one aspect. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API We talked about this in chat and decided: to use the name :capturing to let the type specify the min, max the same way as it is specified in the Puppet Language - i.e. T means Array[T], and if min/max is wanted the type should be given as Array[T] - to get a variable number of arrays it is specified as Array[Array[T]] Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Assignee: AndyParker Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title
Henrik Lindberg commented on PUP-1806
Re: Varargs support for the new function API
Adding an extra optional parameter to param is easy to use. This works well for :required (the default), and :optional, but is trickier for the capturing semantics since it can _expression_ minimum and maximum as well. We may also want to expand on the set of options in the future.
Suggest that the third parameter is either a shorthand notation of :optional, :required or :captures or an options hash where the details are spelled out as follows:
min_occurs = 0 for optional, 1 for required, is 1 by default
max_occurs = :default for infinity otherwise integer count, is infinity by default
captures = boolean
This means that the most common cases are obtained with a single symbol, and that the more complex capture with a cap requires a hash with options.
param 'Integer', :the_rest, {:min_occurs = 2, :max_occurs = 10, :captures = true }
We can either deprecate arg_count and make it an error to use at the same time as giving details to each parameter or update all functions that use arg_count to use the new way of specifying optionality and capture.
I would very much like to get this into 3.7.5 as it affects the API and ease of writing 4x functions.
Add Comment
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Story Points: 3 2 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Fix Version/s: PUP4.x Fix Version/s: PUP3.7.5 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on PUP-1806 Re: Varargs support for the new function API Specifying a max_occurs 1 without a captures is an error. Only the last param may have captures. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Assignee: ThomasHallgren Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Steve Barlow updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Steve Barlow Fix Version/s: PUP4.0.0 Fix Version/s: PUP4.x Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on an issue Re: Varargs support for the new function API We cannot change any way we like in 4.x since it is then API. It either has to change in 4.0 or be supported in a friendlier but compatible way during 4x. Add Comment Puppet / PUP-1806 Varargs support for the new function API There needs to be some way of specify varargs in the new function API, but in a way that still lets us do some type checking of the arguments. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Andy Parker updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Andy Parker Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Steve Barlow updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Steve Barlow Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Steve Barlow updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Steve Barlow Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Sprint: 2014-09- 03 17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Joshua Partlow updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Joshua Partlow Sprint: 2014- 08 09 - 20 03 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Kenn Hussey Sprint: Week2014- 7 08 - 23 06 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Henrik Lindberg Sprint: Week2014-7- 9 23 to2014- 7 8 - 23 6 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Andy Parker updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Andy Parker Sprint: Week2014-7-9to2014-7-23 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Andy Parker updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Andy Parker Fix Version/s: 3.7.0 Fix Version/s: 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Andy Parker commented on an issue Re: Varargs support for the new function API Description from PUP-2245 , which is a duplicate of this. Right now the interface for the new function api to specify parameters is (for example): param Integer, 'a' param Integer, 'b' arg_count 1, 2 The param calls are fairly obvious, but the arg_count is hard to understand. We should extend the functionality of param to be able to express required, optional, and last-captures-rest kinds of parameters. Add Comment Puppet / PUP-1806 Varargs support for the new function API There needs to be some way of specify varargs in the new function API, but in a way that still lets us do some type checking of the arguments. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Henrik Lindberg commented on an issue Re: Varargs support for the new function API This is now implemented as part of the first cut of the API in PUP-1799. Suggest we keep this ticket until we are happy with how it works. Otherwise repurpose this ticket to what remains to be fixed. Add Comment Puppet / PUP-1806 Varargs support for the new function API There needs to be some way of specify varargs in the new function API, but in a way that still lets us do some type checking of the arguments. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Andy Parker updated an issue Puppet / PUP-1806 Varargs support for the new function API Change By: Andy Parker Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1806) Varargs support for the new function API
Title: Message Title Andrew Parker created an issue Puppet / PUP-1806 Varargs support for the new function API Issue Type: Improvement Assignee: Andrew Parker Components: DSL Created: 27/Feb/14 5:20 PM Fix Versions: 3.6.0 Priority: Normal Reporter: Andrew Parker There needs to be some way of specify varargs in the new function API, but in a way that still lets us do some type checking of the arguments. Add Comment
