Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title Ethan Brown commented on PUP-1893 Re: ACL module permissions are not formatted correctly Just to add a quick footnote to this - it appears that in Puppet 5, based on some refactorings, that format_value_for_display is no longer called as it was previously. I've left some notes about the some of the differences in https://gist.github.com/Iristyle/d3e50e6add9abe9b8c441528f92551e9 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Joshua Cooper commented on an issue
Re: ACL module permissions are not formatted correctly
If format_value_for_display is only being used for the permissions property, we should be able to use bare words for other parameters/properties like?
ensure = present,
inherit_parent_permissions = false,
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
From what I understand it is being used for all - that's how the formatter works. Or am I missing something?
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
But perhaps we should check it against something else to see how it behaves differently.
puppet resource group
group { 'Performance Monitor Users':
ensure = 'present',
gid= 'S-1-5-32-558',
}
group { 'Power Users':
ensure = 'present',
gid= 'S-1-5-32-547',
}
group { 'Remote Desktop Users':
ensure = 'present',
gid= 'S-1-5-32-555',
}
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
Joshua Cooper I think I see some confusion here. We've overridden format_value_for_display in the permissions property so we can control how permissions look during the application of catalog changes. We have absolutely NO control of how it is formatted from puppet resource acl OTHER than making it appear as a hash or an array. It completely ignores our overrides and uses the one at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/resource.rb#L300 which calls directly to the default Puppet::Parameter.format_value_for_display for every parameter/property. Even if we override those in each of the properties, it will completely ignore those (as it is already doing based on the call in resource.rb).
Another note on that, we can control how it looks, but we'd be monkey patching puppet and the maintainability of that would be very low.
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Joshua Cooper commented on an issue
Re: ACL module permissions are not formatted correctly
Ah, I see Rob Reynolds, thanks for clearing that up. I'm +1
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
Wheee!
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
Still goes back to my comments on how puppet produces booleans when using self.format_value_for_display(value) - specifically https://github.com/puppetlabs/puppet/blob/master/lib/puppet/parameter.rb#L570
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Joshua Cooper commented on an issue
Re: ACL module permissions are not formatted correctly
I'm not sure about this:
C:\work\puppet [pr/2598] bundle exec puppet resource acl c:/ --modulepath=c:/work/modules
acl { 'c:/':
group = 'S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464',
inherit_parent_permissions = 'false',
owner = 'S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464',
permissions= [{'identity' = 'NT AUTHORITY\SYSTEM', 'rights' = ['full']}, {'identity' = 'BUILTIN\Administrators', 'rights' = ['full']}, {'identity' = 'BUILTIN\Users', 'rights' = ['read', 'execute']}, {'child_types' = 'containers', 'identity' = 'BUILTIN\Users', 'mask' = '4', 'rights' = ['mask_specific']}, {'affects' = 'children_only', 'child_types' = 'containers', 'identity' = 'BUILTIN\Users', 'mask' = '2', 'rights' = ['mask_specific']}, {'affects' = 'children_only', 'identity' = 'CREATOR OWNER', 'rights' = ['full']}],
}
Note how boolean and integer values are quoted, that doesn't seem like idiomatic puppet:
inherit_parent_permissions = 'false',
'mask' = '2',
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Ethan Brown commented on an issue
Re: ACL module permissions are not formatted correctly
Is this aesthetic or functional? I know that the mask works as quoted and applies correctly. I agree that if this isn't the correct way to do this in Puppet language, it should be fixed as possible.
The inherit_parent_permissions is a bit tricky as it can't be roundtripped now, and must be removed from the manifest you put it in... since that feature isn't supported in this release of the module.
I'm not sure what we should do to handle that. Rob Reynolds and I went back and forth on whether or not it should be removed altogether. The problem is that with it removed, it doesn't accurately reflect the state. But with it in there, it can't be copy / pasta'd into a manifest.
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Ethan Brown commented on an issue
Re: ACL module permissions are not formatted correctly
I'm seeing something like this now:
acl { 'c:\': group = 'S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464', inherit_parent_permissions = 'false', owner = 'S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464', permissions = [
Unknown macro: {'identity' = 'NT AUTHORITYSYSTEM', 'rights' = ['full']}
,
Unknown macro: {'identity' = 'BUILTINAdministrators', 'rights' = ['full']}
,
Unknown macro: {'identity' = 'BUILTINUsers', 'rights' = ['read', 'execute']}
,
Unknown macro: {'child_types' = 'containers', 'identity' = 'BUILTINUsers', 'mask' = '4', 'rights' = ['mask_specific']}
,
Unknown macro: {'affects' = 'children_only', 'child_types' = 'containers', 'identity' = 'BUILTINUsers', 'mask' = '2', 'rights' = ['mask_specific']}
,
Unknown macro: {'affects' = 'children_only', 'identity' = 'CREATOR OWNER', 'rights' = ['full']}
], }
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
Small amount of formatting applied:
acl { 'c:\':
group = 'S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464',
inherit_parent_permissions = 'false',
owner = 'S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464',
permissions= [
{'identity' = 'NT AUTHORITY\SYSTEM', 'rights' = ['full']},
{'identity' = 'BUILTIN\Administrators', 'rights' = ['full']},
{'identity' = 'BUILTIN\Users', 'rights' = ['read', 'execute']},
{'child_types' = 'containers', 'identity' = 'BUILTIN\Users', 'mask' = '4', 'rights' = ['mask_specific']},
{'affects' = 'children_only', 'child_types' = 'containers', 'identity' = 'BUILTIN\Users', 'mask' = '2', 'rights' = ['mask_specific']},
{'affects' = 'children_only', 'identity' = 'CREATOR OWNER', 'rights' = ['full']}
],
}
This looks technically right. This is due to this: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/resource.rb#L296 (which just uses the default formatter and doesn't allow you to override it like we are doing during the formatting of the resource changes during a puppet run).
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
Additional comment - https://github.com/puppetlabs/puppet/blob/master/lib/puppet/parameter.rb#L564-L566
It sorts the keys in ASCIIbetical order, that's why they are out of order.
We've overridden that here: https://github.com/ferventcoder/puppetlabs-acl/blob/b3f0a43646697fb594949e3b229e123770b90316/lib/puppet/type/acl.rb#L236-L237
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
In other words, the formatting sucks but it is technically correct and the only way we can be correct. To overcome this we need to improve puppet to make the parameter an instance function and make resource smarter about the resource type it is receiving.
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-1893 ACL module permissions are not formatted correctly Change By: Ethan Brown Assignee: EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-1893 ACL module permissions are not formatted correctly Change By: Kenn Hussey Sprint: Week2014-4-09to2014-4-16 ,Week2014-4-16to2014-4-23 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-1893 ACL module permissions are not formatted correctly Change By: Rob Reynolds Sprint: Week2014-4-09to2014-4-16 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
Granted that PR is just a start on the formatting.
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
This might have been something I was doing in my formatting.
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title Joshua Cooper updated an issue Puppet / PUP-1893 ACL module permissions are not formatted correctly Change By: Joshua Cooper Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Rob Reynolds commented on an issue
Re: ACL module permissions are not formatted correctly
I'm confused, there is no comma inside the ACE. Are you saying you want to allow for it?
Add Comment
Puppet / PUP-1893
ACL module permissions are not formatted correctly
The ACL module uses {code} C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\ acl { 'c:\': ensure = 'present', group = 'S-1-5-80-...', inherit_parent_permissions = 'false', owner = 'S-1-5-80-...', permissions = [ '{identity = '...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Joshua Cooper updated an issue
Puppet / PUP-1893
ACL module permissions are not formatted correctly
Change By:
Joshua Cooper
TheACLmoduleuses{code}C:\work\puppet[master+8~0-0!]bundleexecpuppetresourceaclc:\acl{'c:\':ensure='present',group='S-1-5-80-...',inherit_parent_permissions='false',owner='S-1-5-80-...',permissions=['{identity='NTAUTHORITY\SYSTEM',rights=[full],}','{identity='BUILTIN\Administrators',rights=[full],}','{identity='BUILTIN\Users',rights=[read,execute],}','{identity='BUILTIN\Users',rights=[write],child_types='containers',}','{identity='BUILTIN\Users',rights=[write],child_types='containers',affects='children_only',}','{identity='CREATOROWNER',rights=[full],affects='children_only',}'],}{code}NotehoweachACEisastringandhasatrailingcomma,e.g.{code}'{identity='NTAUTHORITY\SYSTEM',rights=[full],}'{code}Ifyoutrytofeedthisbackintopuppetitwill fail toparse,andneedtomodifiedto:{code}{identity='NTAUTHORITY\SYSTEM',rights=[full]}{code}Theproblemcomesfromthe{{Puppet::Parameter.format_value_for_display}}becauseitcanonlyhandleArrayandHashstructures,notanACE.
Add Comment
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title Joshua Cooper updated an issue Puppet / PUP-1893 ACL module permissions are not formatted correctly Change By: Joshua Cooper Fix Version/s: M Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1893) ACL module permissions are not formatted correctly
Title: Message Title
Joshua Cooper created an issue
Puppet / PUP-1893
ACL module permissions are not formatted correctly
Issue Type:
Bug
Assignee:
Unassigned
Created:
07/Mar/14 2:14 PM
Labels:
windows
Priority:
Normal
Reporter:
Joshua Cooper
The ACL module uses
C:\work\puppet [master +8 ~0 -0 !] bundle exec puppet resource acl c:\
acl { 'c:\':
ensure = 'present',
group = 'S-1-5-80-...',
inherit_parent_permissions = 'false',
owner = 'S-1-5-80-...',
permissions= [
'{identity = 'NT AUTHORITY\SYSTEM', rights = [full],}',
'{identity = 'BUILTIN\Administrators', rights = [full],}',
'{identity = 'BUILTIN\Users', rights = [read, execute],}',
'{identity = 'BUILTIN\Users', rights = [write], child_types = 'containers',}',
'{identity = 'BUILTIN\Users', rights = [write], child_types = 'containers', affects = 'children_only',}',
'{identity = 'CREATOR OWNER', rights = [full], affects = 'children_only',}'
],
}
Note how each ACE is a string and has a trailing comma, e.g.
'{identity = 'NT AUTHORITY\SYSTEM', rights = [full],}'
If you try to feed this back into puppet it will to parse, and
