Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Joshua Cooper updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Joshua Cooper Component/s: Client Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Rob Reynolds commented on an issue Re: Standardize existing FFI code and refactor where necessary Merged into master at 130985e to be released in 3.7.0. Add Comment Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary We need to standardize on how windows types, e.g. DWORD, HANDLE, etc are represented in FFI, and refactor places where duplicate methods are defined, e.g. CloseHandle, etc. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Kurt Wall commented on an issue Re: Standardize existing FFI code and refactor where necessary Pre-verified. Ethan Brown and I discussed this in HipChat. I'll grep the installed files to make sure the new codes are there, but that will be it for FR. Testing the negative case isn't feasible here, so we will rely on CI testing that exercises the underlying API calls. After this passes CI, I will auto-resolve and close it. Add Comment Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary We need to standardize on how windows types, e.g. DWORD, HANDLE, etc are represented in FFI, and refactor places where duplicate methods are defined, e.g. CloseHandle, etc. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Joshua Cooper commented on an issue Re: Standardize existing FFI code and refactor where necessary Commit d79d0a11 passed in CI, which includes 52333993e Add Comment Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary We need to standardize on how windows types, e.g. DWORD, HANDLE, etc are represented in FFI, and refactor places where duplicate methods are defined, e.g. CloseHandle, etc. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Ethan Brown updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Ethan Brown Sprint: Week2014-5-7to2014-5-14,Week2014-5- 21 14 to2014-5- 28 21 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Joshua Cooper assigned an issue to Joshua Cooper Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Joshua Cooper Assignee: JoshuaCooper Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Ethan Brown commented on an issue Re: Standardize existing FFI code and refactor where necessary FYI - PR has been cleaned up to contain only commits for this particular issue. Other commits have been moved to their own PRs / tickets have been updated accordingly. Add Comment Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary We need to standardize on how windows types, e.g. DWORD, HANDLE, etc are represented in FFI, and refactor places where duplicate methods are defined, e.g. CloseHandle, etc. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Joshua Cooper commented on an issue Re: Standardize existing FFI code and refactor where necessary Merged into master in 52333993 to be released in 3.7.0 Add Comment Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary We need to standardize on how windows types, e.g. DWORD, HANDLE, etc are represented in FFI, and refactor places where duplicate methods are defined, e.g. CloseHandle, etc. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Kylo Ginsberg Sprint: Week2014-5-7to2014-5-14 ,Week2014-5-14to2014-5-21 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Kylo Ginsberg Sprint: Week2014-5-7to2014-5-14,Week2014-5- 14 21 to2014-5- 21 28 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Kylo Ginsberg Sprint: Week2014-5-7to2014-5-14,Week2014-5-14to2014-5-21 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Kylo Ginsberg Sprint: Week2014-5-7to2014-5-14,Week2014-5-14to2014-5-21 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Ethan Brown commented on an issue Re: Standardize existing FFI code and refactor where necessary I'm not sure yet how we're going to approach the CloseHandle calls. That's the only redundant definition as far as I can tell... so perhaps we end up with a small module that we can mix-in. Add Comment Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary We need to standardize on how windows types, e.g. DWORD, HANDLE, etc are represented in FFI, and refactor places where duplicate methods are defined, e.g. CloseHandle, etc. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Ethan Brown Assignee: EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Kylo Ginsberg Sprint: Week2014-5-7to2014-5-14 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Rob Reynolds assigned an issue to Unassigned Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2382) Standardize existing FFI code and refactor where necessary
Title: Message Title Joshua Cooper updated an issue Puppet / PUP-2382 Standardize existing FFI code and refactor where necessary Change By: Joshua Cooper Summary: FFI Standardizeexisting FFIcode andrefactorwherenecessary Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
