Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Kurt Wall updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Rob Reynolds commented on an issue Re: Deprecate and remove node inheritance Shouldn't FR also verify that --parser future emits an error? Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title
Rob Reynolds commented on an issue
Re: Deprecate and remove node inheritance
site.pp:
node default {
package {'roundhouse':
ensure = latest,
provider = chocolatey,
}
}
node 'common' inherits default {
}
node /win*/ inherits 'common' {
#yup
}
current parser emits warnings:
C:\code\puppetlabs\puppetbundle exec puppet apply c:\vagrantshared\puppet\manifests\site.pp
Warning: Deprecation notice: Node inheritance is not supported in Puppet = 4.0.
0. See http://links.puppetlabs.com/puppet-node-inheritance-deprecation
(at c:/vagrantshared/puppet/manifests/site.pp:9)
Warning: Deprecation notice: Node inheritance is not supported in Puppet = 4.0.
0. See http://links.puppetlabs.com/puppet-node-inheritance-deprecation
(at c:/vagrantshared/puppet/manifests/site.pp:12)
Future parser emits warnings and errors:
C:\code\puppetlabs\puppetbundle exec puppet apply c:\vagrantshared\puppet\manifests\site.pp --parser future
Error: Node inheritance is not supported in Puppet = 4.0.0. See http://links.pu
ppetlabs.com/puppet-node-inheritance-deprecation at c:/vagrantshared/puppet/mani
fests/site.pp:9:24
Error: Node inheritance is not supported in Puppet = 4.0.0. See http://links.pu
ppetlabs.com/puppet-node-inheritance-deprecation at c:/vagrantshared/puppet/mani
fests/site.pp:12:22
Error: Could not parse for environment production: Found 2 errors. Giving up in
c:/vagrantshared/puppet/manifests/site.pp on node win-e5k8tm30719.corp.puppetlab
s.net
Error: Could not parse for environment production: Found 2 errors. Giving up in
c:/vagrantshared/puppet/manifests/site.pp on node win-e5k8tm30719.corp.puppetlab
s.net
The link works (comes to this issue currently)
Add Comment
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Rob Reynolds commented on an issue Re: Deprecate and remove node inheritance Henrik Lindberg Andy Parker is it fine to expect the above (a warning for EACH usage of inherits)? Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance That is how it is implemented - one warning per source location where node ... inherits is used in 'current', and an error when used in 'future'. The deprecation warnings can be squelched like other deprecation warnings. Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker assigned an issue to Andy Parker Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Andy Parker Assignee: AndyParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker commented on an issue Re: Deprecate and remove node inheritance After looking over this, I can sympathize with wanting to make the use of the future parser as easy as possible in puppet 3.7, but it prevents it from being a true preview of what will be available in puppet 4. I'm kicking this back to convert it to being an error in puppet 3.7 when the future parser is enabled. Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker assigned an issue to Henrik Lindberg Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Andy Parker Assignee: HenrikLindberg Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance PR-2788 merged to master: f54911e Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Henrik Lindberg Nodeinheritancecausesalargenumberofcomplicationsandambiguitiesthatmakeunderstandingpuppetcodedifficult.Thereisverylittlereasontouseitsincemuchmoreeffectivereusecanbeachievedusingclassesanddefinedtypes.Onthenext3seriespuppetthatisusingthecurrentparser:thesystemmustissueadeprecationwarningwhenitencountersinheritsinanodestatement.Forthefutureparser(3seriesandin4)inheritsonanodeisanerror. UPDATE:Thefinaldecisionistomake3.7(current)issueawarning,andthat3.7(future)raisesanerror.Thistomakethe3.7futureascloseaspossibletowhatwillbereleasedin4.0. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Kylo Ginsberg Sprint: Week2014-6-11to2014-6-18 ,Week2014-6-18to2014-6-25 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance For functional review: Check that a warning is issued if a node is declared with 'inherits' Check both current and future parser. Visit the URL that is shown in the error - make sure it leads to somewhere (back to the issue currently). Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance Merged to master: 9910fb9 Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Joshua Partlow assigned an issue to Joshua Partlow Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Joshua Partlow Assignee: JoshuaPartlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Andy Parker Sprint: Week2014-6- 4 11 to2014-6- 11 18 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Joshua Cooper updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Joshua Cooper Sprint: Week2014- 5 6 - 28 4 to2014-6- 4 11 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Andy Parker Sprint: Week2014- 6 5 - 4 28 to2014-6- 11 4 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Andy Parker Sprint: Week2014- 5 6 - 28 4 to2014-6- 4 11 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Henrik Lindberg Sprint: Week2014-5-28to2014-6-4 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance I have a very strong suspicion that external tools are using constructs such as inheriting from a default node, and adding constructs to the inherited node. To not prevent future parser from being used I suggest that the deprecation warning is in effect for both parsers in the 3x series, and that it is made into an error in Puppet 4. (The change is then to simply change the configuration of the Issue to be :error, instead of :deprecation). Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance If agreed that this should be a warning in 3.7.0 future, then a new issue is needed for Puppet 4.0.0 to make it an error. Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg commented on an issue Re: Deprecate and remove node inheritance The URL http://links.puppetlabs.com/puppet-node-inheritance-deprecation has been defined for this and it currently points to this issue. Add Comment Puppet / PUP-2557 Deprecate and remove node inheritance Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it en... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-2557 Deprecate and remove node inheritance Change By: Henrik Lindberg Assignee: AndyParker HenrikLindberg Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2557) Deprecate and remove node inheritance
Title: Message Title Andy Parker created an issue Puppet / PUP-2557 Deprecate and remove node inheritance Issue Type: Task Assignee: Andy Parker Components: DOCS, DSL Created: 13/May/14 11:18 AM Fix Versions: 3.7.0 Priority: Normal Reporter: Andy Parker Node inheritance causes a large number of complications and ambiguities that make understanding puppet code difficult. There is very little reason to use it since much more effective reuse can be achieved using classes and defined types. On the next 3 series puppet that is using the current parser: the system must issue a deprecation warning when it encounters inherits in a node statement. For the future parser (3 series and in 4) inherits on a node is an error. Add Comment
