Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Mike Andrewjeski commented on PUP-2752 Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Am seeing this issue when trying to upgrade puppetlabs-stdlib puppetlabs-stdlib (v3.2.2) to puppetlabs-stdlib (v4.5.1). This is on PE 3.3.2. It appears that for stdlib 3.2.2 there is no metadata.json file, instead it has the older Modulefile. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title
John Duarte commented on an issue
Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Anderson Mills I agree with your distinction between the condition defined by this issue and the test I conducted.
I have opened PUP-3093 to reflect the issue of not being able to upgrade a specific module if the previous version of that module has an invalid semver.
I have tested the condition described in this issue against SHA 9953b2c67009013894dcd0 and it PASSES as expected.
I will mark this issue as resolved.
Test:
test_name puppet module upgrade should succeed if a different installed module has an invalid semver
confine :except, :platform = 'solaris-10'
require 'json'
agents.each do |agent|
teardown do
on(agent, rm -rf #{agent['distmoduledir']}/java)
on(agent, rm -rf #{agent['distmoduledir']}/stdlub)
end
step Install older version of module do
stub_forge_on(agent)
on(agent, mkdir -p #{agent['distmoduledir']})
on agent, puppet(module install pmtacceptance-java --version 1.6.0)
end
step Install a different module do
stub_forge_on(agent)
on(agent, mkdir -p #{agent['distmoduledir']})
on agent, puppet(module install pmtacceptance-nginx)
end
step Change 'version' to invalid value in metadata.json of the different module do
metafile = #{agent['distmoduledir']}/nginx/metadata.json
if on(agent, test -f #{metafile}, :acceptable_exit_codes = [0,1]).exit_code == 1
metafile = #{agent['distmoduledir']}/nginx/Modulefile
on(agent, test -f #{metafile})
end
puts metafile
metadata = on(agent, cat #{metafile}).stdout
m = JSON.parse(metadata)
m['version'] = 'hello.world'
create_remote_file(agent, #{agent['distmoduledir']}/nginx/metadata.json, JSON.dump(m))
end
step Upgrade module should succeed and warn that the version is invalid do
on(agent, puppet(module upgrade pmtacceptance-java)) do |res|
assert_match(/Warning: nginx .* has an invalid version number/, res.stderr, Proper warning not displayed)
end
end
end
This test assumes that the environment variable for `forge_host` has been set to a testing forge with access to the module `pmtacceptance-java` with versions 1.6.0 and 1.7.1 as well as access to `pmtacceptance-nginx`.
Results:
t0mis83n4lnx23s 09:10:48$ env PATH=/usr/bin:/opt/puppet-git-repos/hiera/bin:${PATH} RUBYLIB=/opt/puppet-git-repos/hiera/lib:/opt/puppet-git-repos/hiera-p
uppet/lib:${RUBYLIB} puppet module upgrade pmtacceptance-java Notice: Preparing to upgrade 'pmtacceptance-java' ...
Warning: nginx (/etc/puppet/modules/nginx) has an invalid version number (hello.world). The version has been set to 0.0.0. If you are the maintainer for thi module, please update the metadata.json with a valid Semantic Version (http://semver.org).
Warning: vcsrepo (/etc/puppet/modules/vcsrepo) has an invalid version number (white.whale). The version has been set to 0.0.0. If you are the maintainer for
this module, please update the metadata.json with a valid Semantic Version (http://semver.org).
Notice: Found 'pmtacceptance-java' (v1.6.0) in /etc/puppet/modules ...
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Anderson Mills commented on an issue Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format John Duarte I believe the test in the your previous comment tries to upgrade a module which has an incorrect semver. I believe that the case stated in the ticket is install a module when a different installed module has a incorrect semver. I'm not sure what the expected behavior should be in the former case, but I don't think that the former and latter are the same. The latter should probably be tracked in a different ticket. Add Comment Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format. I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f ) How to reproduce problem: * Place a... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Eric Sorenson commented on an issue Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Anderson Mills to follow-up on the regression Duarte noted. Add Comment Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format. I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f ) How to reproduce problem: * Place a... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Eric Sorenson updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Eric Sorenson Assignee: AndersonMills Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title
John Duarte commented on an issue
Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Using puppet on the master branch at SHA=
Applying the following test presents the version warning, but does not perform the upgrade. If the the test is modified not to alter the version number (leaving it a valid semver), then no warning is presented and the upgrade is successful.
Test
test_name puppet module upgrade should succeed if installed version is an invalid semver
require 'json'
agents.each do |agent|
teardown do
on(agent, rm -rf #{agent['distmoduledir']}/java)
on(agent, rm -rf #{agent['distmoduledir']}/stdlub)
end
step Install older version of module do
stub_forge_on(agent)
on(agent, mkdir -p #{agent['distmoduledir']})
on agent, puppet(module install pmtacceptance-java --version 1.6.0)
end
step Change 'version' to invalid value in metadata.json do
metafile = #{agent['distmoduledir']}/java/metadata.json
if on(agent, test -f #{metafile}, :acceptable_exit_codes = [0,1]).exit_code == 1
metafile = #{agent['distmoduledir']}/java/Modulefile
on(agent, test -f #{metafile})
end
puts metafile
metadata = on(agent, cat #{metafile}).stdout
m = JSON.parse(metadata)
m['version'] = 'hello.world'
create_remote_file(agent, #{agent['distmoduledir']}/java/metadata.json, JSON.dump(m))
end
step Upgrade module should succeed and warn that the version is invalid do
on(agent, puppet(module upgrade pmtacceptance-java)) do |res|
assert_match(/Warning: java .* has an invalid version number/, res.stderr, Proper warning not displayed)
end
end
end
This test assumes that the environment variable for `forge_host` has been set to a testing forge with access to the module `pmtacceptance-java` with versions 1.6.0 and 1.7.1.
Results
qw9dvmp4zgwz3qf 13:46:39$ env PATH=/usr/bin:/opt/puppet-git-repos/hiera/bin:${PATH} RUBYLIB=/opt/puppet-git-repos/hiera/lib:/opt/puppet-git-repos/hiera-p
uppet/lib:${RUBYLIB} puppet module upgrade pmtacceptance-java Notice: Preparing to upgrade 'pmtacceptance-java' ...
Warning: java (/etc/puppet/modules/java) has an invalid version number (hello.world). The version has been set to 0.0.0. If you are the maintainer for this
module, please update the metadata.json with a valid Semantic Version (http://semver.org).
Error: Version numbers MUST begin with three dot-separated numbers
/usr/lib/ruby/site_ruby/1.8/puppet/vendor/semantic/lib/semantic/version.rb:29:in `parse'
/usr/lib/ruby/site_ruby/1.8/puppet/module_tool/applications/upgrader.rb:69:in `run'
/usr/lib/ruby/site_ruby/1.8/puppet/face/module/upgrade.rb:68:in `upgrade implementation, required on Ruby 1.8'
/usr/lib/ruby/site_ruby/1.8/puppet/interface/action.rb+eval[wrapper]:242:in `__send__'
/usr/lib/ruby/site_ruby/1.8/puppet/interface/action.rb+eval[wrapper]:242:in `upgrade'
/usr/lib/ruby/site_ruby/1.8/puppet/application/face_base.rb:229:in `send'
/usr/lib/ruby/site_ruby/1.8/puppet/application/face_base.rb:229:in `main'
/usr/lib/ruby/site_ruby/1.8/puppet/application.rb:392:in `run_command'
/usr/lib/ruby/site_ruby/1.8/puppet/application.rb:384:in `run'
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Kurt Wall assigned an issue to Kurt Wall Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Kurt Wall updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Kylo Ginsberg Sprint: Week2014-6-25to2014-7-9,2014-07-23 ,2014-08-06 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Brandon High commented on an issue Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Merged fix to master. New behavior is to warn about invalid semvers, default them to 0.0.0, and point maintainers at the semver docs. Here's example output after following the test case given in the description: Notice: Preparing to install into /Users/highb/.puppet/modules ... Warning: pound (/Users/highb/.puppet/modules/pound) has an invalid version number (0.1). The version has been set to 0.0.0. If you are the maintainer for this module, please update the metadata.json with a valid Semantic Version (http://semver.org). Notice: Downloading from https://forgeapi.puppetlabs.com ... Notice: Installing -- do not interrupt ... /Users/highb/.puppet/modules └── saz-rsyslog (v3.2.0) Add Comment Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format. I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f ) How to reproduce problem: * Place a...
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title John Duarte updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: John Duarte QA Contact: EricThompson JohnDuarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Kylo Ginsberg Sprint: Week2014-6-25to2014-7-9 ,Week2014-7-9to2014-7-23 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Brandon High assigned an issue to Brandon High Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Brandon High Assignee: PietervandeBruggen BrandonHigh Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Brandon High commented on an issue Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format I've started working on a fix for this. Add Comment Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format. I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f ) How to reproduce problem: * Place a... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Anderson Mills updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Anderson Mills Fix Version/s: 3.7.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Brandon High updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Brandon High Sprint: Week2014-6-25to2014-7-9 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Tristan Helmich commented on an issue Re: Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Hey is there some estimation available when this will be fixed? The new behavior makes it impossible to use the current version since my automatic module deployment is now broken. Thanks! Add Comment Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format. I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f ) How to reproduce problem: * Place a... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Pieter van de Bruggen updated an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Change By: Pieter van de Bruggen Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2752) Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format
Title: Message Title Tristan Helmich created an issue Puppet / PUP-2752 Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format Issue Type: Bug Affects Versions: 3.6.2, 3.6.1, 3.6.0 Assignee: Pieter van de Bruggen Components: PMT Created: 11/Jun/14 1:20 AM Labels: moduletool pmt Priority: Critical Reporter: Tristan Helmich Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format. I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f ) How to reproduce problem: Place a module that does not conform with the X.Y.Z version format in your module folder (e.g. https://github.com/mrintegrity/puppet-pound ). To simulate this with another module just edit the metadata.json
