Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-19 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson assigned an issue to Eric Thompson


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




Assignee:

 EricThompson












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-19 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




QA Status:

 Reviewed












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-18 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo assigned an issue to Adrien Thebo


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Adrien Thebo




Assignee:

 AdrienThebo












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-18 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo commented on an issue


















  Re: Puppet searches disk for whit classes 










Merged GH-2979 in 69310a8.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-18 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo assigned an issue to Adrien Thebo


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Adrien Thebo




Assignee:

 AdrienThebo












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-18 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo commented on an issue


















  Re: Puppet searches disk for whit classes 










Verified:
On 3.6.2:


strace -o strace.out -e trace=stat -- bundle exec puppet apply -e 'notify { hello: message = world }'; echo Admissible:; grep -c admissible strace.out ; echo Completed:; grep -c completed strace.out
Unable to open /dev/zfs: Permission denied.
Unable to open /dev/zfs: Permission denied.
Notice: Compiled catalog for grey.somethingsinistral.net in environment production in 0.03 seconds
Notice: world
Notice: /Stage[main]/Main/Notify[hello]/message: defined 'message' as 'world'
Notice: Finished catalog run in 0.18 seconds
Admissible:
648
Completed:
648



On master (dbf3021):


strace -o strace.out -e trace=stat -- bundle exec puppet apply -e 'notify { hello: message = world }'; echo Admissible:; grep -c admissible strace.out ; echo Completed:; grep -c completed strace.out
Unable to open /dev/zfs: Permission denied.
Unable to open /dev/zfs: Permission denied.
Notice: Compiled catalog for grey.somethingsinistral.net in environment production in 0.02 seconds
Notice: world
Notice: /Stage[main]/Main/Notify[hello]/message: defined 'message' as 'world'
Notice: Finished catalog run in 0.13 seconds
Admissible:
0
Completed:
0



For this trivial example it looks like catalog application time is roughly the same.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has 

Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-18 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




QA Contact:

 NarmadhaPerumal EricThompson












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-14 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg commented on an issue


















  Re: Puppet searches disk for whit classes 










Charlie Sharpsteen your last comment sounds like the scope of this has increased. Are you actively working this? Or should we punt it out of 3.7?












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-14 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen commented on an issue


















  Re: Puppet searches disk for whit classes 










Yes I am. I have a decent patch that solves the problem, what is slowing me down is adding documentation around the behavior and arguments passed to Puppet::Resource#initialize. I should have that wrapped up by the end of the week.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.

Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-08 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




Assignee:

 EricThompson CharlieSharpsteen












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-08 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen commented on an issue


















  Re: Puppet searches disk for whit classes 










What happened here is that PR 2492 added a call to resource_type directly to Puppet::Resource#initialize.
So, my patch moved us one step forward and that PR moved us one step back. To completely fix this problem, we'll need to go all the way and re-factor Resource.new .












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to 

Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-07 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson assigned an issue to Eric Thompson


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




Assignee:

 EricThompson












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-07 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




Assignee:

 EricThompson












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-07 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson assigned an issue to Eric Thompson


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Eric Thompson




Assignee:

 EricThompson












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-07 Thread Eric Thompson (JIRA)
Title: Message Title










 

 Eric Thompson commented on an issue


















  Re: Puppet searches disk for whit classes 










via Charlie Sharpsteen there should be no stat() calls looking for files that match the pattern of admissible_.rb or completed_.rb
tried this from centos6 on SHA c6ba27e $ sudo strace -o strace.out puppet apply -e user  { 'erict': ensure=present }
 $ grep -c '^stat.admissible_.\.rb strace.out  96 eg: stat64(/usr/lib/ruby/gems/1.8/gems/bundler-1.6.5/lib/puppet/type/admissible_stage.rb, 0xbf7e9540) = -1 ENOENT (No such file or directory)
i get 9899 total stat calls on above sha and i get 9819 on sha 3471447 (just before cb26e23)












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 




 

Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-05 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo commented on an issue


















  Re: Puppet searches disk for whit classes 










Merged into master in cb26e23; this should be released in 3.7.0.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-08-04 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Kylo Ginsberg




Sprint:

 2014-08-20












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-17 Thread Peter Bakkum (JIRA)
Title: Message Title










 

 Peter Bakkum commented on an issue


















  Re: Puppet searches disk for whit classes 










Tried this out by running 


time puppet apply --verbose --debug oursite.pp


 before and after applying the patch. I ran 5 times and averaged the output, here is the improvement we see.



real  19.9044 - 18.5814 6.6%
user  10.3344 -  9.7594 5.9%
sys3.999  -  3.440816.2%



So system time went from 4s to 3.44s for a 16% improvement. Not a massive win but definitely in the right direction.
What IS nice is the number of stat calls for our instance went from 49,936 before to 39,100 after, so big improvement there. That probably explains why there's so much less system time. This seems like an easy win, hope you guys can release it soon. Thanks for digging in.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage





 

Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-15 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen commented on an issue


















  Re: Puppet searches disk for whit classes 










Thanks for reporting this! There is definitely some wasted effort going on here.
The core of the problem is that we have a very expensive lookup operation that determines the Type associated with a resource: Puppet::Resource#resource_type. Due to the expense, some methods set the resource_type if this information is known and available when a Resource instance is created.
However, when retrieving the state of whits, a Resource instance is created that does not receive available type information:


debug call: load /puppetlabs/puppet/lib/puppet/util/autoload.rb:194
	name = :completed_stage
	env = production
	/puppetlabs/puppet/lib/puppet/util/autoload.rb:194:in `load'
	/puppetlabs/puppet/lib/puppet/metatype/manager.rb:163:in `type'
	/puppetlabs/puppet/lib/puppet/resource.rb:242:in `resource_type'
	/puppetlabs/puppet/lib/puppet/resource.rb:163:in `builtin_type?'
	/puppetlabs/puppet/lib/puppet/resource.rb:475:in `namevar'
	/puppetlabs/puppet/lib/puppet/resource.rb:466:in `parameter_name'
	/puppetlabs/puppet/lib/puppet/resource.rb:140:in `[]='
	/puppetlabs/puppet/lib/puppet/type.rb:1032:in `retrieve'
	/puppetlabs/puppet/lib/puppet/type.rb:1063:in `retrieve_resource'
	/puppetlabs/puppet/lib/puppet/transaction/resource_harness.rb:223:in `from_resource'
	/puppetlabs/puppet/lib/puppet/transaction/resource_harness.rb:19:in `evaluate'
	/puppetlabs/puppet/lib/puppet/transaction.rb:174:in `apply'
	/puppetlabs/puppet/lib/puppet/transaction.rb:187:in `eval_resource'
	/puppetlabs/puppet/lib/puppet/transaction.rb:117:in `call'
	/puppetlabs/puppet/lib/puppet/transaction.rb:117:in `block (2 levels) in evaluate'
	/puppetlabs/puppet/lib/puppet/util.rb:327:in `block in thinmark'
	/opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295:in `realtime'
	/puppetlabs/puppet/lib/puppet/util.rb:326:in `thinmark'
	/puppetlabs/puppet/lib/puppet/transaction.rb:117:in `block in evaluate'
	/puppetlabs/puppet/lib/puppet/graph/relationship_graph.rb:118:in `traverse'
	/puppetlabs/puppet/lib/puppet/transaction.rb:108:in `evaluate'
	/puppetlabs/puppet/lib/puppet/resource/catalog.rb:167:in `block in apply'
	/puppetlabs/puppet/lib/puppet/util/log.rb:149:in `with_destination'
	/puppetlabs/puppet/lib/puppet/transaction/report.rb:112:in `as_logging_destination'
	/puppetlabs/puppet/lib/puppet/resource/catalog.rb:166:in `apply'
	/puppetlabs/puppet/lib/puppet/configurer.rb:117:in `block in apply_catalog'
	/puppetlabs/puppet/lib/puppet/util.rb:161:in `block in benchmark'
	/opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295:in `realtime'
	/puppetlabs/puppet/lib/puppet/util.rb:160:in `benchmark'
	/puppetlabs/puppet/lib/puppet/configurer.rb:116:in `apply_catalog'
	/puppetlabs/puppet/lib/puppet/configurer.rb:191:in `run'
	/puppetlabs/puppet/lib/puppet/agent.rb:47:in `block (4 levels) in run'
	/puppetlabs/puppet/lib/puppet/agent/locker.rb:20:in `lock'
	/puppetlabs/puppet/lib/puppet/agent.rb:47:in `block (3 levels) in run'
	/puppetlabs/puppet/lib/puppet/agent.rb:117:in `with_client'
	/puppetlabs/puppet/lib/puppet/agent.rb:44:in `block (2 levels) in run'
	/puppetlabs/puppet/lib/puppet/agent.rb:82:in `run_in_fork'
	/puppetlabs/puppet/lib/puppet/agent.rb:43:in `block in run'
	/puppetlabs/puppet/lib/puppet/application.rb:179:in `call'
	/puppetlabs/puppet/lib/puppet/application.rb:179:in `controlled_run'
	/puppetlabs/puppet/lib/puppet/agent.rb:41:in `run'
	/puppetlabs/puppet/lib/puppet/application/agent.rb:355:in `onetime'
	/puppetlabs/puppet/lib/puppet/application/agent.rb:321:in `run_command'
	/puppetlabs/puppet/lib/puppet/application.rb:371:in `block (2 levels) in run'
	

Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-15 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Charlie Sharpsteen




Assignee:

 CharlieSharpsteen KyloGinsberg












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-15 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen commented on an issue


















  Re: Puppet searches disk for whit classes 










Kylo Ginsberg: The patch above appears to resolve this issue, however we do pass typing information to Puppet::Resource.new. If we can use that to eliminate the need to set resource_type on instances after creation, it might be a better long term solution.
On a CentOS 6 test box, a vanilla Puppet agent makes 1080 calls to stat caused by 40 erroneous whit lookups for 1 node, 1 class and 1 stage. Eliminating the whit lookups shaves 0.1 seconds off of an empty catalog run. Each Class added to the catalog appears to generate 270 additional stat calls. These numbers will be sensitive to the size of the Ruby LOAD_PATH and, by extension, the Puppet MODULE_PATH.
It seems like there are some good performance gains we could get here, kicking this one to you for a scheduling decision.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)



   

Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-15 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Kylo Ginsberg




Story Points:

 3












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-15 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Kylo Ginsberg




Fix Version/s:

 3.7.0












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-15 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg commented on an issue


















  Re: Puppet searches disk for whit classes 










I'd like to see if we can get this done for 3.7, so I'm optimistically scheduling it for 3.7. That release is running tight though, so no guarantees on that.
Meanwhile Peter Bakkum if you get a chance to try out Charlie's patch that would be nice confirmation.












   

 Add Comment

























 Puppet /  PUP-2924



  Puppet searches disk for whit classes 







 Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:   stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT  stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to 

Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-14 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen updated an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Charlie Sharpsteen




Component/s:

 TypesandProviders




Component/s:

 Client




Affects Version/s:

 3.6.2












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-14 Thread Charlie Sharpsteen (JIRA)
Title: Message Title










 

 Charlie Sharpsteen assigned an issue to Charlie Sharpsteen


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Change By:

 Charlie Sharpsteen




Assignee:

 CharlieSharpsteen












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2924) Puppet searches disk for whit classes

2014-07-10 Thread Peter Bakkum (JIRA)
Title: Message Title










 

 Peter Bakkum created an issue


















 Puppet /  PUP-2924



  Puppet searches disk for whit classes 










Issue Type:

  Bug




Assignee:


 Unassigned




Created:


 10/Jul/14 5:12 PM




Environment:


SmartOS, Puppet 3.6.2




Priority:

  Normal




Reporter:

 Peter Bakkum










Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this:
stat(/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/etc/puppet/modules/admin/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/etc/puppet/modules/percona/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/etc/puppet/shared/modules/apt/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/etc/puppet/shared/modules/puppetlabs-stdlib/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/etc/puppet/external/modules/python/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/etc/puppet/external/modules/yum_puppet_plugin/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/var/lib/puppet/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/opt/local/lib/ruby/gems/2.0.0/gems/bigdecimal-1.2.0/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/opt/local/lib/ruby/gems/2.0.0/gems/bundler-1.5.3/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT stat(/opt/local/lib/ruby/gems/2.0.0/gems/byebug-3.1.2/lib/puppet/type/completed_stage.rb, 0xFD7FFFDFE4A0) Err#2 ENOENT