Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Kylo Ginsberg commented on PUP-3231 Re: Specifying --tags doesn't cause suitability check to be skipped for skipped resources Note that this issue is not related to hpux at all. That was simply a convenient example to use because it is a not suitable provider on any system we typically test against. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Steve Barlow updated an issue Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Steve Barlow Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Eric Thompson Assignee: EricThompson Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Eric Thompson updated an issue Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Eric Thompson QA Contact: EricThompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Joshua Partlow updated an issue Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Joshua Partlow Fix Version/s: 4.0.0 Fix Version/s: 3.7.1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Joshua Partlow updated an issue Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Joshua Partlow Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Joshua Partlow updated an issue Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Joshua Partlow Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Kylo Ginsberg assigned an issue to Kylo Ginsberg Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Kylo Ginsberg Assignee: KyloGinsberg Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title
Kylo Ginsberg commented on an issue
Re: Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Merged to stable in d46b511. Will be released in 3.7.1.
Add Comment
Puppet / PUP-3231
Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Puppet checks that providers are suitable, e.g. see this snippet (expected to fail on a non-hpux install) {code} puppet apply -e 'user { snoopy: ensure = present, provider = hpuxuseradd }' Notice: Compiled catalog for kylo.corp.puppetlabs.net in environment production in 0.23 seconds Error: /User[snoopy]: Provider hpuxuseradd is not functional o...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Joshua Partlow assigned an issue to Unassigned Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Joshua Partlow Assignee: JoshuaPartlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Joshua Partlow assigned an issue to Joshua Partlow Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Joshua Partlow Assignee: JoshuaPartlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Joshua Partlow assigned an issue to Joshua Partlow Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Joshua Partlow Assignee: JoshuaPartlow Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title
Kylo Ginsberg commented on an issue
Re: Specifying --tags doesn't cause suitability check to be skipped for skipped resources
For reference, below is the simplistic patch I tinkered with. I haven't worked through whether it's a good idea or not.
diff --git a/lib/puppet/transaction.rb b/lib/puppet/transaction.rb
index 5311875..6ccadd8 100644
--- a/lib/puppet/transaction.rb
+++ b/lib/puppet/transaction.rb
@@ -105,6 +105,7 @@ class Puppet::Transaction
overly_deferred_resource_handler = lambda do |resource|
# We don't automatically assign unsuitable providers, so if there
# is one, it must have been selected by the user.
+ return if skip?(resource)
if resource.provider
resource.err Provider #{resource.provider.class.name} is not functional on this host
else
Add Comment
Puppet / PUP-3231
Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Puppet checks that providers are suitable, e.g. see this snippet (expected to fail on a non-hpux install) {code} puppet apply -e 'user { snoopy: ensure = present, provider = hpuxuseradd }' Notice: Compiled catalog for kylo.corp.puppetlabs.net in environment production in 0.23 seconds Error: /User[snoopy]: Provider hpuxuseradd is not functional o...
This message was sent by Atlassian JIRA
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title
Kylo Ginsberg created an issue
Puppet / PUP-3231
Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Issue Type:
Improvement
Assignee:
Unassigned
Created:
10/Sep/14 4:38 PM
Priority:
Normal
Reporter:
Kylo Ginsberg
Puppet checks that providers are suitable, e.g. see this snippet (expected to fail on a non-hpux install)
puppet apply -e 'user { snoopy: ensure = present, provider = hpuxuseradd }'
Notice: Compiled catalog for kylo.corp.puppetlabs.net in environment production in 0.23 seconds
Error: /User[snoopy]: Provider hpuxuseradd is not functional on this host
Notice: Finished catalog run in 0.02 seconds
It's reasonable to think that specifying --tags to exclude the resource would skip this suitability check, but that's not the case. Note that the following snippet still fails:
puppet apply -e 'user { snoopy: ensure = present, provider = hpuxuseradd }' --tags do_nothing
Notice: Compiled catalog for kylo.corp.puppetlabs.net in environment production in 0.21 seconds
Error: /User[snoopy]: Provider hpuxuseradd is not functional on this host
Notice: Finished catalog run in 0.02 seconds
Jira (PUP-3231) Specifying --tags doesn't cause suitability check to be skipped for skipped resources
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3231 Specifying --tags doesn't cause suitability check to be skipped for skipped resources Change By: Kylo Ginsberg Fix Version/s: 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
