Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nicholas Fagerlund updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Nicholas Fagerlund Labels: breaking docs_reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nicholas Fagerlund updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Nicholas Fagerlund Component/s: DOCS Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Eric Thompson updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Peter Huene commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Verified in be3d1972379cbd45ee6988d6fe6432d0d201d2f6 with the following: foo type: Puppet::Type.newtype(:foo) do ensurable newparam(:bar) do isnamevar end end bar provider: Puppet::Type.type(:foo).provide(:bar) do def self.prefetch(resources = nil)
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Steve Barlow updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Steve Barlow Sprint: PlatformClient2015-01-21 ,PlatformClient2015-02-04 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Peter Huene assigned an issue to Unassigned Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Peter Huene Assignee: PeterHuene Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Peter Huene assigned an issue to Peter Huene Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Peter Huene Assignee: PeterHuene Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Peter Huene assigned an issue to Peter Huene Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Peter Huene Assignee: PeterHuene Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Kylo Ginsberg Sprint: PlatformClient2015-01-21 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Kylo Ginsberg Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title
Nicholas Fagerlund updated an issue
Puppet / PUP-3656
Prefetch eats all exceptions, there is no way to fail out.
Change By:
Nicholas Fagerlund
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/transaction.rb#L306-L310Thisbugstillexistsinthemasterbranchasoftodayandwasintroducedin2.7.8withthiscommit:https://github.com/puppetlabs/puppet/commit/000a2d811c740f4179a0cd4ced38e886858cf01fTherescueconditionmeansthatanyexceptionraisedbyprovidersduringprefetchgetsloggedbutthenswallowedbyPuppet.Asaresultofthis,anyproviderwhichrelies*only*onprefetchtofindallinstanceswillenduprunningtheresourcecreationregardlessofwhethertheresourceexistsornot.Inordertonegatethisbehaviour,providerauthorswouldneedtocreatechecksforinstanceexistencewhichrunduringthecreationphaseaswell,whichdefeatsthepointofhavingprefetchinthefirstplace.---Notetodocs:moduleauthorswhousethe{{prefetch}}methodmaywanttobeawareofthechangesinthisfix.Twothingstoconsider:#previously,theprefetchmethodcouldthrow*any*exceptionandpuppetwouldcarryon.Asdiscussedabovethisisthewrongbehavioringeneral,howeversomemoduleauthorsmayhavestumbledacrossthis,allowed/encouragedprefetchtothrowexceptions,andletpuppetrunssucceed.Somodulesshouldbeexaminedforthisassumption.#theonlytwolegitimatecausesforprefetchtothrowanexceptionnoware{{LoadError}}and(addedinthispuppet4.0){{Puppet::MissingCommand}} Thisisabreakingchangein4.0.
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nicholas Fagerlund updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Nicholas Fagerlund Labels: breaking Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nicholas Fagerlund commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Kylo Ginsberg Rad, thanks. I added some stuff to be more obvious about this being a breaking change, since that ends up being important for release notes. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nicholas Fagerlund updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Nicholas Fagerlund Component/s: BreakingChange Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Nicholas Fagerlund I took a pass at adding a helpful blurb to the description, but you may want to read through the comments on the linked PR because there was some good discussion there as well. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Kylo Ginsberg Fix Version/s: PUP4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Kylo Ginsberg Component/s: DOCS Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Kylo Ginsberg Scrum Team: ClientPlatform Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title
Kylo Ginsberg updated an issue
Puppet / PUP-3656
Prefetch eats all exceptions, there is no way to fail out.
Change By:
Kylo Ginsberg
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/transaction.rb#L306-L310Thisbugstillexistsinthemasterbranchasoftodayandwasintroducedin2.7.8withthiscommit:https://github.com/puppetlabs/puppet/commit/000a2d811c740f4179a0cd4ced38e886858cf01fTherescueconditionmeansthatanyexceptionraisedbyprovidersduringprefetchgetsloggedbutthenswallowedbyPuppet.Asaresultofthis,anyproviderwhichrelies*only*onprefetchtofindallinstanceswillenduprunningtheresourcecreationregardlessofwhethertheresourceexistsornot.Inordertonegatethisbehaviour,providerauthorswouldneedtocreatechecksforinstanceexistencewhichrunduringthecreationphaseaswell,whichdefeatsthepointofhavingprefetchinthefirstplace.---Notetodocs: moduleauthorswhouse the {{prefetch}}methodmaywanttobeawareofthechangesinthis fix .Twothings to consider:#previously,theprefetchmethodcouldthrow*any*exceptionandpuppetwouldcarryon.Asdiscussedabove this issue isthewrongbehavioringeneral,howeversomemoduleauthorsmayhavestumbledacrossthis,allowed/encouragedprefetchtothrowexceptions,andletpuppetrunssucceed.Somodulesshouldbeexaminedforthisassumption.#theonlytwolegitimatecausesforprefetchtothrowanexceptionnoware{{LoadError}}and(addedinthispuppet4.0){{Puppet::MissingCommand}}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Change By: Kylo Ginsberg https://github.com/puppetlabs/puppet/blob/master/lib/puppet/transaction.rb#L306-L310Thisbugstillexistsinthemasterbranchasoftodayandwasintroducedin2.7.8withthiscommit:https://github.com/puppetlabs/puppet/commit/000a2d811c740f4179a0cd4ced38e886858cf01fTherescueconditionmeansthatanyexceptionraisedbyprovidersduringprefetchgetsloggedbutthenswallowedbyPuppet.Asaresultofthis,anyproviderwhichrelies*only*onprefetchtofindallinstanceswillenduprunningtheresourcecreationregardlessofwhethertheresourceexistsornot.Inordertonegatethisbehaviour,providerauthorswouldneedtocreatechecksforinstanceexistencewhichrunduringthecreationphaseaswell,whichdefeatsthepointofhavingprefetchinthefirstplace. ---Notetodocs:thefixtothisissue Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Nan Liu just catching LoadError and a new command not available exception does sound true to the original intent of the change for #6907. Any concern that this will expose previously swallowed provider prefetch exceptions and thus surprise users? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nan Liu commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Kylo Ginsberg, I would think those are bugs anyhow. I can't imagine anyone want their providers to create resources if prefetch failed which is the current behavior. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Kylo Ginsberg commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Nan Liu that makes sense to me. I'm +1 on your proposal so if you have time to work up a patch, that'd be great! Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Josh Cooper commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Completely agree this is a problem, though puppet does not eat all exceptions in https://github.com/puppetlabs/puppet/blob/master/lib/puppet/transaction.rb#L306-L310, only those exceptions descending from StandardError, which excludes LoadError. On a side note, we made a pass through puppet eliminating places where we really were rescuing all Exceptions, see PUP-3521 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Nan Liu commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. +1, can no longer tell the difference between api failure and resource provider problems. Since #6907 was intended to handle unsuitable providers, there's really only two exceptions to catch: LoadError, gems that are unavailable. Command not available. This is currently a very generic Puppet::Error, and simply need a more specific exception class: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/command.rb#L22 If people are happy with this proposal, I'm happy to write a patch. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Dan Bode commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. +1 to fixing this. This is pretty much a huge issue for all of the openstack providers. It makes it way to easy to create duplicate resources in openstack when there is api unreliability (it actually makes it pretty difficult to use prefetch with anything that uses the network) Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Matt Carroll commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. Just a suggestion here, I think that to create an exception type which will be raised instead of logged on this level if it's rescued would solve this problem - that way provider authors can raise this exception type in the specific case that a failure means that a run should stop. This approach has the benefit that it introduces the required functionality without breaking any old behaviour, and puts the logic for what exceptions should be re-raised as fatal on the provider level. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Gareth Rushgrove commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. +1 from me too. This will likely affect providers that use network based APIs more than other on host providers. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Gavin Williams commented on PUP-3656 Re: Prefetch eats all exceptions, there is no way to fail out. +1 from me. I've been hit by this with my NetApp types/providers before, but never tracked the issue down... So thank's for that Tomas Doran. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3656) Prefetch eats all exceptions, there is no way to fail out.
Title: Message Title Matt Carroll created an issue Puppet / PUP-3656 Prefetch eats all exceptions, there is no way to fail out. Issue Type: Bug Affects Versions: PUP 3.7.3, PUP 2.7.23 Assignee: Kylo Ginsberg Components: Types and Providers Created: 2014/11/11 8:38 AM Priority: Normal Reporter: Matt Carroll https://github.com/puppetlabs/puppet/blob/master/lib/puppet/transaction.rb#L306-L310 This bug still exists in the master branch as of today and was introduced in 2.7.8 with this commit: https://github.com/puppetlabs/puppet/commit/000a2d811c740f4179a0cd4ced38e886858cf01f The rescue condition means that any exception raised by providers during prefetch gets logged but then swallowed by Puppet. As a result of this, any provider which relies only on prefetch to find all instances will end up running the resource creation regardless of whether the resource exists or not. In order to negate this behaviour, provider authors would need to create checks for instance existence which run during the creation phase as well, which defeats the point of having prefetch in the first place.
