Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kurt Wall 
 
 
 

QA Status:
 
 Reviewed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall commented on  PUP-3684 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 
 
Verified in master at SHA=a558d9e. I {{grep}}ped through the sources and through a Puppet installation and did not find the following methods and/or settings: 
 
 
 
 
 
 
has_local_changes 
 
 
 
 
local_changes 
 
 
 
 
setting(name) 
 
 
 
 
shortinclude? 
 
 
 
 
metadata 
 
 
 
 
mkdir 
 
 
 
 
params 
 
 
 
 
sectionlist 
 
 
 
 
set_value 
 
 
 
 
setdefaults 
 
 
 
 
uninterpolated_value 

Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall commented on  PUP-3684 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 
 
Hailee Kenney or Henrik Lindberg May I get a quick sanity check, please? The settings/methods to check for removal that I can find include the ones below. Are there others I missed? 
 

Settings.shortinclude?
 

Settings.metadata
 

Settings.mkdir
 

Settings.get_config_file_default
 

Settings.params(section=nil)
 

Settings.sectionlist
 

Settings.uninterpolated_value
 

Settings.setdefaults
 

Settings.set_value() -> Settings.patch_value()
 

Duplicate Settings.setting() def
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 

Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall assigned an issue to Kurt Wall 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kurt Wall 
 
 
 

Assignee:
 
 Kurt Wall 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-21 Thread Steve Barlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Steve Barlow updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Steve Barlow 
 
 
 

Sprint:
 
 Platform Server 2014-12-17, Language 2015-01-21 , Language 2015-02-04 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-16 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-3684 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 
 
Merged to master at 0ee0db5 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-13 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-3684 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 
 
All of the removals have been made except the set_value for which there is a ticket PUP-3836 to deal with the cleanup of --dns-alt-names setting/CLI option. To make that easier, the deprecated set_value method was renamed to patch_value and marked to be @api private to facilitate the change in PUP-3836 without having to also deprecate this method. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-07 Thread Steve Barlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Steve Barlow updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Steve Barlow 
 
 
 

Sprint:
 
 Platform Server 2014-12-17 , Language 2015-01-21 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2015-01-05 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney assigned an issue to Unassigned 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Hailee Kenney 
 
 
 

Assignee:
 
 Hailee Kenney 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-12-29 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-3684 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 
 
I'm going to go ahead and toss this back into Ready for Engineering until everyone else is back from vacation and I can get some guidance on how I should proceed. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-12-29 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-3684 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 
 
When I started removing some of the deprecated methods in Puppet::Settings I ran into these test failures without the `set_value` method (spec/unit/face/certificate_spec.rb:131): 
 
 
 
 
 
 
it "should use the global setting if set by CLI" do 
 
 
 
 
  Puppet.settings.set_value(:dns_alt_names, 'from,the,cli', :cli) 
 
 
 
 
  
 
 
 
 
   subject.generate(hostname, options) 
 
 
 
 
  
 
 
 
 
   expected = %W[DNS:from DNS:the DNS:cli DNS:#{hostname}] 
 
 
 
 
  
 
 
 
 
  csr.subject_alt_names.should =~ expected 
 
 
 
 
end 
 
 
 
 
  
 
 
 
 

Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-12-19 Thread Kylo Ginsberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kylo Ginsberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kylo Ginsberg 
 
 
 

Scrum Team:
 
 Language 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-12-16 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney assigned an issue to Hailee Kenney 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Hailee Kenney 
 
 
 

Assignee:
 
 Hailee Kenney 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-11-19 Thread Joshua Partlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Joshua Partlow updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Joshua Partlow 
 
 
 

Sprint:
 
 Platform Server 2014-12-10 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-11-19 Thread Joshua Partlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Joshua Partlow created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Task 
 
 
 

Affects Versions:
 

 PUP 4.0.0 
 
 
 

Assignee:
 
 Andy Parker 
 
 
 

Components:
 

 Server 
 
 
 

Created:
 

 2014/11/19 2:33 PM 
 
 
 

Fix Versions:
 

 PUP 4.0.0 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Joshua Partlow 
 
 
 
 
 
 
 
 
 
 
As a follow on the to the legacy env removal, there are a few deprecated methods in Pupppet::Settings and Puppet::Module which weren't directly related to the environment removal, but which can be cleared out. 
There are also several settings in Puppet::Settings which look to be dead code: 
 

duplicate definitions of def setting(param)
 

shortinclude? (used by one of the option parsers?)
   

Jira (PUP-3684) Remove deprecated methods from Puppet::Settings and Puppet::Module

2014-11-19 Thread Joshua Partlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Joshua Partlow updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3684 
 
 
 
  Remove deprecated methods from Puppet::Settings and Puppet::Module  
 
 
 
 
 
 
 
 
 

Change By:
 
 Joshua Partlow 
 
 
 

Assignee:
 
 Andy Parker 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.