Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Henrik Lindberg commented on PUP-3743 Re: Parser should report invalid operand types when possible Closing this as it really needs type inference to be any good - and type inference would be too much of a performance problem at runtime, Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-3743 Parser should report invalid operand types when possible Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-3743 Parser should report invalid operand types when possible Change By: Henrik Lindberg Labels: help_wanted Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-3743 Parser should report invalid operand types when possible Change By: Henrik Lindberg Component/s: Language Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-3743
Parser should report invalid operand types when possible
If someone wants to have a crack at this and make a PR against the checker4_0.rb validator and that is not too slow then we would accept this.
It is not as easy as it seems to implement - for example:
$x = 1 + if $something { 2 } else { Booh }
I don't see us doing this on our own given that there is a runtime error for the error in the manifest.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-3743 Parser should report invalid operand types when possible Change By: Moses Mendoza Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Sean McDonald assigned an issue to Henrik Lindberg Puppet / PUP-3743 Parser should report invalid operand types when possible Change By: Sean McDonald Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Sean McDonald updated an issue Puppet / PUP-3743 Parser should report invalid operand types when possible Change By: Sean McDonald Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Sean McDonald commented on PUP-3743 Re: Parser should report invalid operand types when possible Henrik Lindberg what do you want to do about this ticket? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title
Thomas Hallgren created an issue
Puppet / PUP-3743
Parser should report invalid operand types when possible
Issue Type:
Improvement
Assignee:
Unassigned
Created:
2014/12/05 5:20 AM
Priority:
Normal
Reporter:
Thomas Hallgren
The parser should be improved to detect expressions that cannot evaluate to numeric values and report when they are used as LHS or RHS in binary expressions where the operator stipulates a numeric type. Right now, this is parsed with no error:
class foobar {
$x = $::os ? {
Ubuntu = 'upstart',
(CentOS/RedHat) = 'init',
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title
Thomas Hallgren updated an issue
Puppet / PUP-3743
Parser should report invalid operand types when possible
Change By:
Thomas Hallgren
TheparsershouldbeimprovedtodetectexpressionsthatcannotevaluatetonumericvaluesandreportwhentheyareusedasLHSorRHSinbinaryexpressionswheretheoperatorstipulatesanumerictype.Rightnow,thisisparsedwithnoerror:{noformat}classfoobar{$x=$::os?{Ubuntu='upstart',(CentOS/RedHat)='init',default=fail('OSnotsupported')}}{noformat}Inversionspriorto4.0CentOSandRedHatarestrings .Inversions =4.0theyaretypes.NeithercanbeusedasLHSorRHSofoperator'/'.
Add Comment
This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3743) Parser should report invalid operand types when possible
Title: Message Title Henrik Lindberg commented on PUP-3743 Re: Parser should report invalid operand types when possible To validate things like these (since the operands are expressions) means we have to add more (performance) expensive validations (while type inference is not required to detect the problem in the example, it would be needed for anything beyond static/literals). In any case an error is raised at runtime for the expressions in the example. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
