Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Release Notes Summary: In Puppet 4.0 many errors returned by our API were moved to follow best practices wrt HTTP error codes and a JSON format that follows our documented JSON schema. However one major subsystem of Puppet (the indirector) was not converted to follow this pattern. As of this release API endpoints that hit this subsystem will return proper HTTP error codes and message bodies that conform to our documented JSON standard. The previous behavior was to return a 400 Server Error for all issues with this subsystem. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Susan McNerney updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Susan McNerney Scope Change Category: Found Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Erik Dasher assigned an issue to Erik Dasher Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Erik Dasher Resolution: Fixed Assignee: qa Erik Dasher Status: Ready for Test Resolved Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller assigned an issue to qa Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Status: Ready for CI Test Assignee: Justin Stoller qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kevin Corcoran assigned an issue to Justin Stoller Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kevin Corcoran Assignee: Justin Stoller Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller assigned an issue to qa Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Status: Ready for CI Test Assignee: Justin Stoller qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kevin Corcoran updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kevin Corcoran Sprint: Server Jade 2016-04-20, Server Jade 2016-05-04, Server Jade 2016-05-18, Server Jade 2016-06- 29 15 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kylo Ginsberg Fix Version/s: PUP 4.y Fix Version/s: PUP 4.6.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Archana Sridhar updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Archana Sridhar Sprint: Server Jade 2016-04-20, Server Jade 2016-05-04, Server Jade 2016-05-18, Server Jade 2016-06- 15 29 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Archana Sridhar updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Archana Sridhar Sprint: Server Jade 2016-04-20, Server Jade 2016-05-04, Server Jade 2016-05-18, Server Jade 2016-06- 01 15 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Karen Van der Veer updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Karen Van der Veer Sprint: Server Jade 2016-04-20, Server Jade 2016-05-04, Server Jade 2016-05-18 , Server Jade 2016-06-01 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema Yes, AFAIK this PR is in good shape and ready to be merged but waiting on the PA release for master to un-freeze, and folks on the Client team have the time to merge. /cc Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Karen Van der Veer commented on PUP-3827 Re: Errors from indirected routes don't match error schema Waiting for the release of Agent 1.5.0 to complete. Right, Justin Stoller? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kevin Corcoran commented on PUP-3827 Re: Errors from indirected routes don't match error schema Justin Stoller is right, there is absolutely no time pressure or urgency on this. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller assigned an issue to Justin Stoller Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Assignee: Justin Stoller Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Fix Version/s: PUP 4.y Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Karen Van der Veer updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Karen Van der Veer Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema FWIW, I don't believe there's any time pressure to release this fix. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema Updated PR ready for review here: https://github.com/puppetlabs/puppet/pull/4957 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema This was reverted as it was causing errors in CI Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kylo Ginsberg Fix Version/s: PUP 4.y Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Geoff Nichols commented on PUP-3827 Re: Errors from indirected routes don't match error schema This may be related to failures we're currently seeing in puppet-agent CI. Please see PUP-6720 for more information. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Susan McNerney updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Susan McNerney Sprint: Server Jade 2016-04-20, Server Jade 2016-05-04 , Server Jade 2016-05-18 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Susan McNerney commented on PUP-3827 Re: Errors from indirected routes don't match error schema smoke tests have passed, full pipeline (multi-day effort) still to go. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Archana Sridhar updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Archana Sridhar Story Points: 0 1 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Archana Sridhar updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Archana Sridhar Story Points: 1 0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Karen Van der Veer updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Karen Van der Veer Sprint: Server Jade 2016-04-20 , Server Jade 2016-05-04 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema I've put up a PR for this here: https://github.com/puppetlabs/puppet/pull/4875 I initially began with an approach that would check to see if the accept headers had been set, but I quickly realized in testing that the accept headers will sometimes have to be set to "text/pson" to be a valid request to the indirector. So a valid request will sometimes not trigger the "application/json" requirement and backwards compatibility cannot be kept unless we explicitly ignore the accept header in those cases. Given that, I just made the indirected route handler as similar to other handlers as possible (no attempt to catch errors). We are validating a fair bit of functionality of the IndirectedRoutes class by return codes, which had to be changed to validate based on the error raised since catching errors and updating the response with return codes is now done higher up the stack. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kurt Wall updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kurt Wall updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kurt Wall QA Risk Assessment Reason: No downtime/dataloss potential Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Kurt Wall updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Kurt Wall QA Risk Assessment: Low Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Archana Sridhar updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Archana Sridhar Sub-team: jade Sprint: Server Jade 2016-04-20 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Labels: low-hanging-fruit server Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema So, looking into this is seems that the simplest route would be to just delete the exception handling code in the indirected_routes. Since that would be backwards incompatible, left to my own devices, I would refactor the exception handling in indirected_routes to check to see if json was a requested response format, if so re-raising the exceptions so that the wrapper handler can correctly deal with them (and we don't have to duplicate the code). If json wasn't specified I'd log a deprecation notice and do same reply that exists currently. Maybe adding a comment in the code that this should be removed in Puppet 5. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema Testing-wise we're testing that the structured error handling is done in a unit test for the generic handler interface. There's also an integration test for the indirected_routes handler that doesn't test the error handling, and uses a different set of test utils to test. Though I think it would be fairly easy to replicate the kind of testing done to test the error handling in the handler unit test. Grepping about I didn't see any acceptance tests for this kind of thing. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema Reviewing the docs it seems that there's some conflation what what is happening in our API (or I'm misreading it) The error return information seems to be nested within the Puppet Server Specific Endpoints and explicitly says that it is applicable to the /environments endpoint (which isn't a Puppet Server specific endpoint). It looks like the documentation is also opinionated about return formats, specifying that if a return type other than json is requested a 406 will be returned (I could not get that behavior by providing a header of "Accept: text/plain" to the environments endpoint). Ahhh... Looking at the code for the environment route, I see now that the generic handler code, included in the generic rack-rest handler handles all of the error processing correctly. Our issue is that indirected routes are implementing their own error handling, doing the wrong thing, and never letting the errors percolate up to the correct error handling code. So with that, there'd be a pretty simple solution to this by simply deleting the exception catching in indirected_routes which should let the wrapper handler do the right thing. The only issue with that is that it would change the behavior of the endpoint error codes not in a major version bump... Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller commented on PUP-3827 Re: Errors from indirected routes don't match error schema My notes so far: We catch any errors raised in our handler's call method (and raise if there's any issue anywhere in processing) in 'network/http/api/indirected_routes' where both handlers for exceptions explicitly set the content type to "text/plain" and pass the exception message through to the message body (via Puppet::Network::HTTP::Response#respond_with, Puppet::Network::HTTP::RackREST#set_response, Rack::Response#write). Exceptions outside of the handler's call (issues with the rack app itself) return a 500 via a substantively similar, but different code path, in 'network/http/rack'. Setting the content type properly, retrieving the requested format (defaulting to P JSON), and rendering the content accordingly – similar to our code for indirector paths should work. That approach should work assuming the Exception/message instance that we pass into the formatter chooser has supported_formats and to_pson defined that list pson as a valid serialization format and can serialize to the schema linked in the description respectively. Fantastically, nearly the exact same described beast exists in 'network/http/error' and conveniently its subclasses are the exceptions we're throwing all over the place. Given the above I think we can implement this by: Update do_http_control_exception to pass the exception it receives to the formatter and pass the properly formatted response on to the request. Update the do_exception handler to do similar after first wrapping the passed exception in a Puppet::Network::HTTP::Error::HTTPError:: HTTPBadRequestError. Update the 500 error handling to be substantively similar to the #2 above but first wrapping any exceptions in a Puppet::Network::HTTP::Error::HTTPError::HTTPServerError, natch. Gotcha: the HTTP error classes don't implement a supported_formats method, so we either need to implement that on their base class or rework/write our own version of accepted_response_formatter_for/accepted_response_formatter_or_pson (we may have to roll our own anyways/extract that functionality out for the 500 processing since that happens in the Rack app outside of an indirected route). Open question: 1. Accept header requirements and pson vs json: accepted_response_formatter_for requires an accepts header to be specified by the client. Is that the correct level of pedantry? accepted_response_formatter_or_pson defaults to pson if the accepts header isn't present, which is basically json, which seems fine... But pson serialization is implemented for indirector classes and/or resources while the current HTTP exceptions have implemented json serialization. I'm spacing on when and why its okay to do one and not the other (see if there's docs for that).
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Justin Stoller assigned an issue to Justin Stoller Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Justin Stoller Assignee: Justin Stoller Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: OnDeck-Tier3 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: OnDeck-Tier3 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: OnDeck-Tier1 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: ServerEmerald2015 OnDeck - 04-01 Tier1 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: Server SERVER 2015-04- 01 15 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: Server2015- 02 03 -18 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: Server2015- 03 04 - 18 01 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Sprint: SERVERnextcandidates 2 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Christopher Price updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Christopher Price Fix Version/s: PUP4.x Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Jeremy Barlow updated an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Change By: Jeremy Barlow Sprint: SERVERnextcandidates Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title Ruth Linehan created an issue Puppet / PUP-3827 Errors from indirected routes don't match error schema Issue Type: Improvement Affects Versions: PUP 4.0.0 Assignee: Unassigned Components: Puppet Server Created: 2015/01/09 11:15 AM Priority: Normal Reporter: Ruth Linehan For v2.0, and error schema (https://github.com/puppetlabs/puppet/blob/master/api/schemas/error.json) was added, specifying that errors should be returned as json, with message and issue_kind specified. The indirected routes don't follow this specification, they just return plain text (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/api/v3/indirected_routes.rb#L47-L50 and https://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/api/v3/indirected_routes.rb#L101-L117). It would be good, especially since we are migrating to v3 for Puppet 4, for this to follow the error schema and return json.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title
Ruth Linehan updated an issue
Puppet / PUP-3827
Errors from indirected routes don't match error schema
Change By:
Ruth Linehan
Forv2.0,anerrorschema(https://github.com/puppetlabs/puppet/blob/master/api/schemas/error.json)wasadded,specifyingthaterrorsshouldbereturnedasjson,with{{message}}and{{issue_kind}}specified.Theindirectedroutesdon'tfollowthisspecification,theyjustreturnplaintext(https://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/api/v3/indirected_routes.rb#L47-L50andhttps://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/api/v3/indirected_routes.rb#L101-L117).Itwouldbegood,especiallysincewearemigratingtov3forPuppet4,for this allroutes tofollowtheerrorschemaandreturnjson.
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3827) Errors from indirected routes don't match error schema
Title: Message Title
Ruth Linehan updated an issue
Puppet / PUP-3827
Errors from indirected routes don't match error schema
Change By:
Ruth Linehan
Forv2.0, and an errorschema(https://github.com/puppetlabs/puppet/blob/master/api/schemas/error.json)wasadded,specifyingthaterrorsshouldbereturnedasjson,with{{message}}and{{issue_kind}}specified.Theindirectedroutesdon'tfollowthisspecification,theyjustreturnplaintext(https://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/api/v3/indirected_routes.rb#L47-L50andhttps://github.com/puppetlabs/puppet/blob/master/lib/puppet/network/http/api/v3/indirected_routes.rb#L101-L117).Itwouldbegood,especiallysincewearemigratingtov3forPuppet4,forthistofollowtheerrorschemaandreturnjson.
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
