Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Maybe we should refine our contribution guidelines for subtasks to include the main task number as well. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Felix Frank commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Oh I see. Thanks for clearing this up. I guess it's fine - if you know how to read the tickets, it's reasonably simple to locate commits towards the subtasks. After all, there was no one branch to solve the encompassing task. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type This is a sub-task of PUP-1208 . That should be visible above the summary, and in the Subtasks section of PUP-1208 . Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Felix Frank commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Was this a duplicate of PUP-1208 ? I'm quite confused, for that one has been marked resolved as well, but I can find no commit that references it. There is also no reference to this ticket, either. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Eric Thompson updated an issue Puppet / PUP-3889 Fix puppet agent writing source to file when using non-md5 checksum type Change By: Eric Thompson QA Contact: EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Eric Thompson updated an issue Puppet / PUP-3889 Fix puppet agent writing source to file when using non-md5 checksum type Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title
Eric Thompson commented on PUP-3889
Re: Fix puppet agent writing source to file when using non-md5 checksum type
and it work on windows2012r2-r64 as well at SHA: f94e844
Administrator@vhm3l8m1k0mu95i ~
$ cmd /c puppet apply C:file_checksum.pp
Notice: Compiled catalog for vhm3l8m1k0mu95i.delivery.puppetlabs.net in environment production in 0.67 seconds
Notice: /Stage[main]/Main/File[checksum]/ensure: defined content as '{md5lite}8639680cb59210bb3f8e9a953a8ca790'
Notice: Applied catalog in 0.09 seconds
Administrator@vhm3l8m1k0mu95i ~
$ cat /cygdrive/c/checksum
this is foo, hear my md5lite roar
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-3889 Fix puppet agent writing source to file when using non-md5 checksum type Change By: Eric Thompson Assignee: EricThompson Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Oh, you're using the content parameter. This fix only addresses when you write from a source parameter, PUP-3898 is required for writing from content. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Is PUP-3887 included on the server? That's the behavior that should be fixed, the 2nd run shouldn't say the content was changed. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title
Michael Smith commented on PUP-3889
Re: Fix puppet agent writing source to file when using non-md5 checksum type
An appropriate test would setup a test module containing foo.txt and use
file {'checksum':
path = '/tmp/checksum',
ensure = 'file',
checksum = 'sha256',
source = 'puppet:///modules/test/foo.txt'
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Based on https://docs.puppetlabs.com/references/latest/type.html#file-attribute-source, I think you could also have it point directly to a source file while running as agent as well. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title
Eric Thompson commented on PUP-3889
Re: Fix puppet agent writing source to file when using non-md5 checksum type
okay. this works. however. changing the checksum doesn't force puppet to apply the change. is that an issue? ubuntu 14.04, same SHA
root@cbkktffmkrzznrz:~# cat /tmp/checksum
this is foo, hear my sha256 roar
root@cbkktffmkrzznrz:~# cat file_checksum.pp
file {'checksum':
path = '/tmp/checksum',
ensure = 'file',
checksum = 'sha256',
source = '/root/foo.txt'
}
root@cbkktffmkrzznrz:~# vi file_checksum.pp
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title
Eric Thompson commented on PUP-3889
Re: Fix puppet agent writing source to file when using non-md5 checksum type
verified on rhel7 at SHA: 0f551b3 with:
[root@upg2vzdvrwsz4go ~]# puppet apply file_md5.pp
Notice: Compiled catalog for upg2vzdvrwsz4go.delivery.puppetlabs.net in environment production in 0.45 seconds
Notice: /Stage[main]/Main/File[md5]/ensure: defined content as '{md5}867898eec6eaf29e5160c2d147a6653b'
Notice: Applied catalog in 0.09 seconds
[root@upg2vzdvrwsz4go ~]# cat /tmp/md5
eric is md5[root@upg2vzdvrwsz4go ~]# puppet apply file_md5lite.pp
Notice: Compiled catalog for upg2vzdvrwsz4go.delivery.puppetlabs.net in environment production in 0.45 seconds
Notice: /Stage[main]/Main/File[md5]/content: content changed '{md5lite}867898eec6eaf29e5160c2d147a6653b' to '{md5}4d302848edc2406105f02eb8f4f73ad0'
Notice: Applied catalog in 0.02 seconds
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title
Eric Thompson commented on PUP-3889
Re: Fix puppet agent writing source to file when using non-md5 checksum type
hmmm... Michael Smith it looks like it is getting and using the right checksum type, but it always says it's md5 upon updates:
root@cbkktffmkrzznrz:~# puppet agent -t
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Caching catalog for cbkktffmkrzznrz.delivery.puppetlabs.net
Info: Applying configuration version '1422897762'
Notice: /Stage[main]/Main/File[checksum]/content:
Notice: /Stage[main]/Main/File[checksum]/content: content changed '{md5lite}4d302848edc2406105f02eb8f4f73ad0' to '{md5}4d302848edc2406105f02eb8f4f73ad0'
Notice: Applied catalog in 0.10 seconds
root@cbkktffmkrzznrz:~# cat
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Josh Cooper commented on PUP-3889 Re: Fix puppet agent writing source to file when using non-md5 checksum type Merged in 0f551b3 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-3889 Fix puppet agent writing source to file when using non-md5 checksum type Change By: Josh Cooper Assignee: JoshCooper Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet / PUP-3889 Fix puppet agent writing source to file when using non-md5 checksum type Change By: Michael Smith Assignee: MichaelSmith Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3889) Fix puppet agent writing source to file when using non-md5 checksum type
Title: Message Title Michael Smith updated an issue Puppet / PUP-3889 Fix puppet agent writing source to file when using non-md5 checksum type Change By: Michael Smith Summary: Fixpuppetagentwritingsource contents to diskwith filewhenusing non-md5 checksumtype Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
