Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Nicholas Fagerlund commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) Please update the summary and description of this ticket to describe the actual problem and its fix. Alternately, if this was an internal cleanup that only affected tests and not user behavior, please note that in the summary/description. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Henrik Lindberg commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) This was a bug, an internal problem - user did nothing wrong. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-3934
Environment used before set in Resource.initialize (regression?)
Change By:
Henrik Lindberg
UPDATEDThiswasabug,aninternalproblemthatoccurredbecausetheactualcodepaththattriggeredtheproblemhadneverbeenconsideredpriortothechangesthatmadethisproblemsurface.ORIGINAL I'mnotabletodoacleanrunofthepuppetspecswhenusingstableorthetagged3.7.4commit.IfIrevertbacktothecommitjustbeforethisone:[0be9c1a|https://github.com/puppetlabs/puppet/commit/0be9c1adaec3b0d3450f202b89f205cfb8d10090](fixforPUP-3755),theneverythingworksOK.There'snothingwrongwiththecommitbutitprovokestherealproblemwhichisthattheResourceinitializermethodcallson{{resource_type}}whichinturnneedsthe{{current_environment}}atapointwheretheenvironmenthasnotbeenset.Thus,itfallsbacktothe_**root**_environmentratherthanusingtheenvironmentfromthecatalogthatcreateditandtheresourcetypeisnotfound.Ihavenogoodexplanationtowhythistestpassedeverywherebefore3.7.4wasreleased.I'mnotabletogetagreen3.7.4orstablebuildonanyofmymachines.Thespecthatfailsisthisone:{noformat}1)PurerubymanifestsshouldallowdefinesFailure/Error:catalog.resource(Bar[instance]).should_notbe_nilPuppet::Error:Couldnotparseforenvironment*root*:Nofile(s)foundforimportof'foo'atline2#./lib/puppet/parser/parser_support.rb:175:in`rescueinparse'#./lib/puppet/parser/parser_support.rb:166:in`parse'#./lib/puppet/node/environment.rb:545:in`perform_initial_import'#./lib/puppet/node/environment.rb:276:in`known_resource_types'#./lib/puppet/resource.rb:276:in`resource_type'#./lib/puppet/resource.rb:242:in`initialize'#./lib/puppet/resource/catalog.rb:305:in`new'#./lib/puppet/resource/catalog.rb:305:in`resource'#./spec/integration/parser/ruby_manifest_spec.rb:39:in`block(2levels)intop(required)'{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Kurt Wall commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) I'm going to pull this through to Done. It seems well-tested in spec and doesn't require further FR. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Kurt Wall assigned an issue to Unassigned Puppet / PUP-3934 Environment used before set in Resource.initialize (regression?) Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Kurt Wall assigned an issue to Kurt Wall Puppet / PUP-3934 Environment used before set in Resource.initialize (regression?) Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Steve Barlow updated an issue Puppet / PUP-3934 Environment used before set in Resource.initialize (regression?) Change By: Steve Barlow Sprint: Language2015-02-04 ,Language2015-02-18 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Josh Cooper commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) Merged to stable in 81d8c53 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Josh Cooper updated an issue Puppet / PUP-3934 Environment used before set in Resource.initialize (regression?) Change By: Josh Cooper Fix Version/s: PUP3.7.5 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-3934 Environment used before set in Resource.initialize (regression?) Change By: Thomas Hallgren Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Steve Barlow commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) Kylo Ginsberg As if you do not have enough to do...here I am pinging you again. Could you, or someone on your team take a look at this since Hendrik would like a second look from someone on the client team. Thanks. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Henrik Lindberg commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) I am fine with the change, it enables setting environment directly in a resource when it is created. When created via the catalog, it is clear that it should be looking things up in the catalog's environment even if the resource is not added to the catalog. I think it is prudent to also have a review of this by the client team - ping Kylo Ginsberg since Resource logic and environment is also used on the client. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title
Thomas Hallgren updated an issue
Puppet / PUP-3934
Environment used before set in Resource.initialize (regression?)
Change By:
Thomas Hallgren
I'mnotabletodoacleanrunofthepuppetspecswhenusingstableorthetagged3.7.4commit.IfIrevertbacktothecommitjustbeforethisone:[0be9c1a|https://github.com/puppetlabs/puppet/commit/0be9c1adaec3b0d3450f202b89f205cfb8d10090](fixforPUP-3755),theneverythingworksOK.There'snothingwrongwiththecommitbutitprovokestherealproblemwhichisthattheResourceinitializermethodcallson{{resource_type}}whichinturnneedsthe{{ environment current_environment }}atapointwheretheenvironmenthasnotbeenset.Thus,itfallsbacktothe_**root**_environmentratherthanusingtheenvironmentfromthecatalogthatcreateditandtheresourcetypeisnotfound.Ihavenogoodexplanationtowhythistestpassedeverywherebefore3.7.4wasreleased.I'mnotabletogetagreen3.7.4orstablebuildonanyofmymachines.Thespecthatfailsisthisone:{noformat}1)PurerubymanifestsshouldallowdefinesFailure/Error:catalog.resource(Bar[instance]).should_notbe_nilPuppet::Error:Couldnotparseforenvironment*root*:Nofile(s)foundforimportof'foo'atline2#./lib/puppet/parser/parser_support.rb:175:in`rescueinparse'#./lib/puppet/parser/parser_support.rb:166:in`parse'#./lib/puppet/node/environment.rb:545:in`perform_initial_import'#./lib/puppet/node/environment.rb:276:in`known_resource_types'#./lib/puppet/resource.rb:276:in`resource_type'#./lib/puppet/resource.rb:242:in`initialize'#./lib/puppet/resource/catalog.rb:305:in`new'#./lib/puppet/resource/catalog.rb:305:in`resource'#./spec/integration/parser/ruby_manifest_spec.rb:39:in`block(2levels)intop(required)'{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Thomas Hallgren created an issue Puppet / PUP-3934 Environment used before set in Resource.initialize (regression?) Issue Type: Bug Affects Versions: PUP 3.7.4 Assignee: Thomas Hallgren Created: 2015/01/31 10:27 AM Priority: Major Reporter: Thomas Hallgren I'm not able to do a clean run of the puppet specs when using stable or the tagged 3.7.4 commit. If I revert back to the commit just before this one: 0be9c1a (fix for PUP-3755 ), then everything works OK. There's nothing wrong with the commit but it provokes the real problem which is that the Resource initializer method calls on resource_type which in turn needs the environment at a point where the environment has not been set. Thus, it falls back to the *root* environment rather than using the environment from the catalog that created it and the resource type is not found. I have no good explanation to why this test passed everywhere before 3.7.4 was released. I'm not able to get a green 3.7.4 or stable build on any of my machines. The spec that fails is this one: 1) Pure ruby manifests
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Henrik Lindberg commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) I I run that on stable (1.9.3) I get the following error: 1) Pure ruby manifests should allow defines Failure/Error: catalog.resource(Bar[instance]).should_not be_nil Puppet::Error: Could not parse for environment *root*: undefined method `frozen' for []:Array at line 2 # ./lib/puppet/parser/parser_support.rb:175:in `rescue in parse' # ./lib/puppet/parser/parser_support.rb:166:in `parse' # ./lib/puppet/node/environment.rb:545:in `perform_initial_import' # ./lib/puppet/node/environment.rb:276:in `known_resource_types' # ./lib/puppet/resource.rb:276:in `resource_type' #
Jira (PUP-3934) Environment used before set in Resource.initialize (regression?)
Title: Message Title Thomas Hallgren commented on PUP-3934 Re: Environment used before set in Resource.initialize (regression?) That explains why it passed the tests before. Evaluation order probably affects what the :current_environment is a reference to. In any case I think this might be a good thing. My PR fixes a real bug that was below the radar. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
