Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Josh Cooper updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Josh Cooper Fix Version/s: PUP 4.10.5 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Jorie Tappa Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Ethan Brown commented on PUP-3940 Re: Puppet requests should include "real" MIME types Merged to master in https://github.com/puppetlabs/puppet/commit/7937f7ee8a92496ac0d8db3e31e7beb033217cd7 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Geoff Nichols assigned an issue to Ethan Brown Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Geoff Nichols Assignee: Josh Cooper Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Eric Delaney updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Eric Delaney QA Risk Assessment Reason: Check in includes tests for the change QA Risk Assessment: No Action QA Contact: Eric Delaney Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Josh Cooper updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Josh Cooper Component/s: Networking Services Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Josh Cooper updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Josh Cooper Release Notes Summary: Puppet will now send proper MIME content types, e.g. application/json, instead of format names, e.g. json, in its Accept header when making HTTP requests. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Kenn Hussey Sprint: Puppet 5 Race to the Finish! Agent 2017-06-14 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Geoff Nichols Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Geoff Nichols Sprint: Puppet 5 Race to the Finish! Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Geoff Nichols Acceptance Criteria: Agent sends requests with text/plain MIME type (and prefers that over s). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Josh Cooper commented on PUP-3940 Re: Puppet requests should include "real" MIME types Update. Puppet submits CSRs using text/plain: <- "PUT /puppet-ca/v1/certificate_request/agent1?environment=production& HTTP/1.1\r\nAccept: s\r\nX-Puppet-Version: 5.0.0\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nContent-Type: text/plain\r\nUser-Agent: Puppet/5.0.0 Ruby/2.4.1-p111 (x86_64-darwin15)\r\nConnection: close\r\nHost: example:8140\r\nContent-Length: 1582\r\n\r\n" <- "-BEGIN CERTIFICATE REQUEST--END CERTIFICATE REQUEST-\n" -> "HTTP/1.1 200 OK \r\n" -> "X-Puppet-Version: 5.0.0\r\n" -> "Content-Type: text/plain\r\n" -> "Server: WEBrick/1.3.1 (Ruby/2.4.1/2017-03-22) OpenSSL/1.0.2h\r\n" -> "Date: Tue, 23 May 2017 00:04:12 GMT\r\n" -> "Content-Length: 1939\r\n" -> "Connection: close\r\n"
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Moses Mendoza Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Kenn Hussey commented on PUP-3940 Re: Puppet requests should include "real" MIME types Josh Cooper this needs to be pulled into the current sprint in order to make the cut for Puppet 5.0... Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Sean McDonald updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Sean McDonald Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Sean McDonald updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Sean McDonald Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Josh Cooper commented on PUP-3940 Re: Puppet requests should include "real" MIME types The only request remaining is MIME type s which should be using text/plain. Assigning to 5.0 JSON epic since that is our opportunity to fix this. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Sean McDonald assigned an issue to Unassigned Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Sean McDonald Assignee: Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include "real" MIME types
Title: Message Title Sean McDonald updated an issue Puppet / PUP-3940 Puppet requests should include "real" MIME types Change By: Sean McDonald Team: Agent Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title
Josh Cooper commented on PUP-3940
Re: Puppet requests should include real MIME types
On the client side, just need to change https://github.com/puppetlabs/puppet/blob/3.7.4/lib/puppet/indirector/rest.rb#L46 to do:
mime_types = model.supported_formats.map { |f| model.get_format(f).mime }
add_accept_encoding({Accept = mime_types.join(', ')})
Add Comment
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Josh Cooper commented on PUP-3940 Re: Puppet requests should include real MIME types I think it's an incompatible change for 3.x, as the agent would need to send the new Accept mime-types, and the server would have to map those back to the appropriate serialization format. We could do do a hard cutover in 4.0, but I don't know about timing. It could be done in 4.x timeframe, though the server would need to handle both the old (binary) and new ways (application/octet-stream). Or wait to 5.0 and cutover then. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Jeremy Barlow commented on PUP-3940 Re: Puppet requests should include real MIME types For a little more background, if a client makes a request which does not include an Accept header value that matches one of the server endpoints' supported_formats, the server will return a failure response with an HTTP 406 (Not Acceptable). I've seen this at least for state change requests with bodies, e.g., PUTs - may apply to GET requests as well, not sure. For example, if the client tries to perform a PUT to the file_bucket which does not include raw in the Accept header, the server will return the HTTP 406 and fail the request. If we do this in a stable release, we'd presumably have to do it in such a way that backward compatibility were not broken. For example, the file_bucket endpoint on the server would need to treat either raw or application/x-raw in an Accept header from a client as valid for returning the raw content. If we were to instead defer this to a major, we arguably could do it without preserving backward compatibility for the use of non-standard MIME types in the HTTP payload. Seems like it might be too late to try to pull this into 4.0 at this point? I suppose we could do the incremental approach in stable and consider removing support for the non-standard MIME types in the HTTP payload later. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Jeremy Barlow commented on PUP-3940 Re: Puppet requests should include real MIME types Kylo Ginsberg I agree that this isn't critical enough and would be too risky to try to pull into 4.0 at this point. It is not blocking for any Puppet Server deliverables. I'd suggest we consider this again for 5.0 unless we think a transition period for 4.x is needed / worth the effort. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Kylo Ginsberg commented on PUP-3940 Re: Puppet requests should include real MIME types Crap, I have no memory of assigning this to myself and it doesn't show up in activity. Probably a stray keystroke? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Christopher Price updated an issue Puppet / PUP-3940 Puppet requests should include real MIME types Change By: Christopher Price Scrum Team: PuppetServer ClientPlatform Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Christopher Price updated an issue Puppet / PUP-3940 Puppet requests should include real MIME types Change By: Christopher Price Component/s: PuppetServer Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Christopher Price commented on PUP-3940 Re: Puppet requests should include real MIME types Kylo Ginsberg since you assigned this to yourself, we are assuming it should go to your scrum team? If not let us know and we can revisit. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Kylo Ginsberg commented on PUP-3940 Re: Puppet requests should include real MIME types My $.02: let's put this in puppet/stable so it's in 3.7.5. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3940) Puppet requests should include real MIME types
Title: Message Title Jeremy Barlow created an issue Puppet / PUP-3940 Puppet requests should include real MIME types Issue Type: Improvement Affects Versions: PUP 3.7.4 Assignee: Kylo Ginsberg Components: Client, Puppet Server Created: 2015/02/02 11:30 AM Priority: Normal Reporter: Jeremy Barlow When a Puppet agent makes requests to a master, the values it uses in the Accept header do not correspond to industry-standard MIME types - although it really seems like they should. For example, a request to the node endpoint includes: GET /production/node/my-node?transaction_uuid=39794d9e-a0c8-4a5b-bcee-d20efa1555b5fail_on_404=true Accept: pson, b64_zlib_yaml, yaml, raw
