Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Josh Cooper updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Josh Cooper Fix Version/s: PUP 3.8.5 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds assigned an issue to Unassigned Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Rob Reynolds Assignee: James Pogran Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title James Pogran updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: James Pogran Attachment: ScreenShot2015-06-17at10.59.49AM.png Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title
James Pogran commented on PUP-4386
Re: Windows Group resource reports errors incorrectly when specifying an invalid group member
Tested with http://builds.puppetlabs.lan/puppet-agent/42427827d2d923e040f0a6083fccdd2bda876858/artifacts/windows/puppet-agent-x64.msi
Using the following manifest example
group { 'guests': ensure = present, members = ['Guest', 'Administrator', ''], }
Run against win2012r2x64
Verified expected message is shown. Screenshot of test vm with output attached
Add Comment
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds assigned an issue to James Pogran Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Rob Reynolds Assignee: RyanGard JamesPogran Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Kylo Ginsberg Release Notes: BugFix Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds commented on PUP-4386 Re: Windows Group resource reports errors incorrectly when specifying an invalid group member Passed specs at https://jenkins.puppetlabs.com/view/All%20in%20One%20Agent/view/Stable/view/Puppet/job/platform_aio-puppet_pkg-promote_stable/98/ Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds assigned an issue to Ryan Gard Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Rob Reynolds Assignee: QA RyanGard Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds assigned an issue to QA Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Rob Reynolds Status: Readyfor CI Test Assignee: RobReynolds QA Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Ethan Brown commented on PUP-4386 Re: Windows Group resource reports errors incorrectly when specifying an invalid group member There are two separate approaches up for review. 4010 - throws an exception in the Windows group provider that the corresponding type must catch 4024 - performs validation on values if the provider has a member_valid? method available Both have to implement some sanity checking is the types is_to_s given that can be called from the resource_harness message building - https://github.com/puppetlabs/puppet/blob/stable/lib/puppet/transaction/resource_harness.rb#L147 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds commented on PUP-4386 Re: Windows Group resource reports errors incorrectly when specifying an invalid group member Leaning towards the validating PR (# 4024) instead of the earlier PR. Seems better to run validate instead. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Rob Reynolds commented on PUP-4386 Re: Windows Group resource reports errors incorrectly when specifying an invalid group member Merged into stable at fefe57c26. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Ryan Gard updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Ryan Gard QA Contact: EricThompson RyanGard Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Steve Barlow updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Steve Barlow Sprint: Windows2015-06- 03 17 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Ryan Gard updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Ryan Gard QA Risk Severity: Low QA Risk Probability: Medium QA Risk Severity Reason: producesanerror,justnotaninformativeone. QA Risk Assessment: Low QA Risk Probability Reason: negativecasethatonlyhappensonuserinputerror QA Highest Test Level: Unit QA Status: Reviewed
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Steve Barlow updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Steve Barlow Sprint: Windows2015- 05 06 - 20 03 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title
Ryan Gard updated an issue
Puppet / PUP-4386
Windows Group resource reports errors incorrectly when specifying an invalid group member
Change By:
Ryan Gard
BecauseofthebugdescribedinPUP-1542,extraneousmessagesmaybeoutputfromPuppetwhenerrormessagegenerationforaneventfailsintheresourceharnesssync_if_neededmethod.Thereare2issuesspecificallyintheWindowsgroupcode:*{{members_to_s}}expectsastring,butispassedanarraywhentryingtocreatethemessage,whichisaneasilycorrectableissue*{{members_to_s}}triestoresolvebadusernamestosidobjects,thentriestoaccessthe{{account}}memberof{{nil}}sidobjectInitiallyspikedasolutionforbothoftheseissuesin:https://github.com/Iristyle/puppet/commit/a6393b07772146101ae1894381e96cea25f05ed2Simplerepoexample.Assumethatthecurrentsystemhas:{code}bundleexecpuppetresourcegroupguestsgroup{'guests':ensure='present',gid='S-1-5-32-546',members=['Guest','Administrator'],}{code}Tryingtoapplythefollowingmanifestwithabaduser:{code}group{'guests':ensure=present,members=['Guest','Administrator',''],}#generatesNotice:Compiledcatalogforvagrant-2008r2.corp.puppetlabs.netinenvironmentproductionin0.22secondsError:Couldnotresolveusername:Error:/Group[Guests]:Couldnotevaluate:Puppet::Util::LogrequiresamessageNotice:Finishedcatalogrunin0.05seconds{code}Thisspikedchangedoesnotloseerrordetail,nortriggeranextraneous/misleadingmessage:{code}Notice:Compiledcatalogforvagrant-2008r2.corp.puppetlabs.netinenvironmentproductionin0.22secondsError:Couldnotresolveusername:Error:/Stage[main]/Main/Group[Guests]/members:changefromVAGRANT-2008R2\Guest,VAGRANT-2008R2\Administratorto[Guest,Administrator,]failed:Couldnotresolveusername:Notice:Finishedcatalogrunin0.05seconds{code} h3.QARiskassessment:lowRiskprobability:med(negativecasethatonlyhappensonuserinputerror)Riskseverity:low(producesanerror,justnotaninformativeone.)Testlayer:unitThiscanbecoveredbyunitcompletely.
Add Comment
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Josh Cooper updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Josh Cooper Fix Version/s: PUP4.1.0 Fix Version/s: PUP4.2.0 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Steve Barlow updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Steve Barlow Sprint: Windows2015-05- 06 20 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Ethan Brown Assignee: KyloGinsberg EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Steve Barlow updated an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Change By: Steve Barlow Sprint: Windows2015- 04 05 - 22 06 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4386) Windows Group resource reports errors incorrectly when specifying an invalid group member
Title: Message Title Ethan Brown created an issue Puppet / PUP-4386 Windows Group resource reports errors incorrectly when specifying an invalid group member Issue Type: Bug Affects Versions: PUP 4.0.0, PUP 3.8.0 Assignee: Kylo Ginsberg Components: Types and Providers, Windows Created: 2015/04/07 3:13 PM Fix Versions: PUP 4.0.1 Labels: windows Priority: Normal Reporter: Ethan Brown Because of the bug described in PUP-1542, extraneous messages may be output from Puppet when error message generation for an event fails in the resource harness sync_if_needed method. There are 2 issues specifically in the Windows group code:
