Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title
Eric Thompson updated an issue
Puppet / PUP-4447
error message when using $name/$title variables could be more expressive
Change By:
Eric Thompson
if one uses $name or $title as a define/class parameter you get a useful error that states that they are built in parameters:{code}Error: The parameter $name redefines a built in parameter in the 'define' _expression_ at /opt/puppet-git-repos/puppet/deftst.pp:2:3Error: The parameter $title redefines a built in parameter in the 'define' _expression_ at /opt/puppet-git-repos/puppet/deftst.pp:3:3Error: The parameter $name redefines a built in parameter in the Host Class Definition at /opt/puppet-git-repos/puppet/deftst.pp:11:3Error: The parameter $title redefines a built in parameter in the Host Class Definition at /opt/puppet-git-repos/puppet/deftst.pp:12:3Error: Found 4 errors. Giving upError: Found 4 errors. Giving up{code}but if you try to use $name and $title otherwise it is a bit less useful and opaque to the user:{code}[root@plgf5s85ojlj8m1 puppet]# puppet apply -e '$title = "lol" $name = "wut"'Error: Evaluation Error: Cannot reassign variable title at line 1:8 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Evaluation Error: Cannot reassign variable title at line 1:8 on node plgf5s85ojlj8m1.delivery.puppetlabs.net[root@plgf5s85ojlj8m1 puppet]# puppet apply -e 'define mydefinite ($title){}'Error: Could not parse for environment production: The parameter $title redefines a built in parameter in the 'define' _expression_ at line 1:20 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Could not parse for environment production: The parameter $title redefines a built in parameter in the 'define' _expression_ at line 1:20 on node plgf5s85ojlj8m1.delivery.puppetlabs.net[root@plgf5s85ojlj8m1 puppet]# puppet apply -e '[$title, $name] = ["lol","wut"]'Error: Evaluation Error: Cannot reassign variable title at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Evaluation Error: Cannot reassign variable title at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.net[root@plgf5s85ojlj8m1 puppet]# puppet apply -e '[$name, $title] = ["lol","wut"]'Error: Evaluation Error: Cannot reassign variable name at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Evaluation Error: Cannot reassign variable name at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.net{code} risk: lowprobability: lowseverity: lowtest level: unit
Add Comment
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson assigned an issue to Unassigned Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson updated an issue Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title
Eric Thompson updated an issue
Puppet / PUP-4447
error message when using $name/$title variables could be more expressive
Change By:
Eric Thompson
if one uses $name or $title as a define/class parameter you get a useful error that states that they are built in parameters:{code}Error: The parameter $name redefines a built in parameter in the 'define' _expression_ at /opt/puppet-git-repos/puppet/deftst.pp:2:3Error: The parameter $title redefines a built in parameter in the 'define' _expression_ at /opt/puppet-git-repos/puppet/deftst.pp:3:3Error: The parameter $name redefines a built in parameter in the Host Class Definition at /opt/puppet-git-repos/puppet/deftst.pp:11:3Error: The parameter $title redefines a built in parameter in the Host Class Definition at /opt/puppet-git-repos/puppet/deftst.pp:12:3Error: Found 4 errors. Giving upError: Found 4 errors. Giving up{code}but if you try to use $name and $title otherwise it is a bit less useful and opaque to the user:{code}[root@plgf5s85ojlj8m1 puppet]# puppet apply -e '$title = "lol" $name = "wut"'Error: Evaluation Error: Cannot reassign variable title at line 1:8 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Evaluation Error: Cannot reassign variable title at line 1:8 on node plgf5s85ojlj8m1.delivery.puppetlabs.net[root@plgf5s85ojlj8m1 puppet]# puppet apply -e 'define mydefinite ($title){}'Error: Could not parse for environment production: The parameter $title redefines a built in parameter in the 'define' _expression_ at line 1:20 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Could not parse for environment production: The parameter $title redefines a built in parameter in the 'define' _expression_ at line 1:20 on node plgf5s85ojlj8m1.delivery.puppetlabs.net[root@plgf5s85ojlj8m1 puppet]# puppet apply -e '[$title, $name] = ["lol","wut"]'Error: Evaluation Error: Cannot reassign variable title at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Evaluation Error: Cannot reassign variable title at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.net[root@plgf5s85ojlj8m1 puppet]# puppet apply -e '[$name, $title] = ["lol","wut"]'Error: Evaluation Error: Cannot reassign variable name at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.netError: Evaluation Error: Cannot reassign variable name at line 1:17 on node plgf5s85ojlj8m1.delivery.puppetlabs.net{code}
Add Comment
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title
Eric Thompson commented on PUP-4447
Re: error message when using $name/$title variables could be more expressive
validated on windows2012r2-rubyx64 at SHA: accdc21
Administrator@jeyap4urmyeyehz /opt/puppet-git-repos/puppet
$ cmd /c puppet apply -e '$title = "lol" $name = "wut"'
Error: Evaluation Error: Cannot reassign built in (or already assigned) variable '$title' at line 1:8 on node jeyap4urmyeyehz.delivery.puppetlabs.net
Administrator@jeyap4urmyeyehz /opt/puppet-git-repos/puppet
$ cmd /c puppet apply -e 'define mydefinite ($title){}'
Error: Could not parse for environment production: The parameter $title redefines a built in parameter in the 'define' _expression_ at line 1:20 on node jeyap4urmyeyehz.delivery.puppetlabs.net
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson assigned an issue to Unassigned Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Eric Thompson Assignee: QA Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title
Eric Thompson commented on PUP-4447
Re: error message when using $name/$title variables could be more expressive
validated on rhel7 at SHA: e5bce51
[root@lwfnn6bjeklzkfk puppet]# puppet apply -e '$title = "lol" $name = "wut"'
Error: Evaluation Error: Cannot reassign built in (or already assigned) variable '$title' at line 1:8 on node lwfnn6bjeklzkfk.delivery.puppetlabs.net
[root@lwfnn6bjeklzkfk puppet]# puppet apply -e '$name = "wut"'
Error: Evaluation Error: Cannot reassign built in (or already assigned) variable '$name' at line 1:7 on node lwfnn6bjeklzkfk.delivery.puppetlabs.net
[root@lwfnn6bjeklzkfk puppet]# puppet apply -e 'define mydefinite ($title){}'
Error: Could not parse for environment production: The parameter $title redefines a built in parameter in the 'define' _expression_ at line 1:20 on node lwfnn6bjeklzkfk.delivery.puppetlabs.net
[root@lwfnn6bjeklzkfk puppet]# puppet apply -e '[$title, $name] = ["lol","wut"]'
Error: Evaluation Error: Cannot reassign built in (or already assigned) variable '$title' at line 1:17 on node lwfnn6bjeklzkfk.delivery.puppetlabs.net
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson assigned an issue to QA Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Eric Thompson Status: Ready for CI Test Assignee: QA Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Thomas Hallgren commented on PUP-4447 Re: error message when using $name/$title variables could be more expressive Merged to master at 9e3c493 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Too complex to fix on 3.x because errors come from multiple places, and spec tests are completely restructured for compiler/parser. Changing this to only target 4.1.0 Change By: Henrik Lindberg Fix Version/s: PUP 3.8.1 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Henrik Lindberg Sprint: Language 2015-04-29 Story Points: 1 Scope Change Reason: surprising error message found while testing - trivial to fix Scope Change Category: Found Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Change By: Henrik Lindberg Fix Version/s: PUP 4.1.0 Fix Version/s: PUP 3.8.1 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Henrik Lindberg commented on PUP-4447 Re: error message when using $name/$title variables could be more expressive We can add validation on assignment to $name and $title to provide more helpful error messages because you are never allowed to assign to them. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Henrik Lindberg commented on PUP-4447 Re: error message when using $name/$title variables could be more expressive Message (while possible to improve with quotes, use of $ etc) makes sense in the general assignment case only if you know that $title and $name are always set. When you are doing a puppet apply, the logic you write in "top scope" is actually in the body of the class 'main' (a.k.a '' - the class named 'empty string'). Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4447) error message when using $name/$title variables could be more expressive
Title: Message Title Eric Thompson created an issue Puppet / PUP-4447 error message when using $name/$title variables could be more expressive Issue Type: Improvement Assignee: Unassigned Created: 2015/04/21 11:06 AM Priority: Normal Reporter: Eric Thompson if one uses $name or $title as a define/class parameter you get a useful error that states that they are built in parameters: Error: The parameter $name redefines a built in parameter in the 'define' _expression_ at /opt/puppet-git-repos/puppet/deftst.pp:2:3 Error: The parameter $title redefines a built in parameter in the 'define' _expression_ at /opt/puppet-git-repos/puppet/deftst.pp:3:3 Error: The parameter $name redefines a built in parameter in the Host Class Definition at /opt/puppet-git-repos/puppet/deftst.pp:11:3
