Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Sean Griffin assigned an issue to Unassigned Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Sean Griffin Assignee: Sean Griffin Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Steve Barlow Sprint: Client 2015-09-16, Client 2015-09-30 , Client 2015-10-14 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Sean Griffin assigned an issue to Sean Griffin Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Sean Griffin Assignee: qa Sean Griffin Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Eric Thompson QA Risk Assessment: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Steve Barlow Sprint: Client 2015-09-16 , Client 2015-09-30 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper assigned an issue to qa Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Josh Cooper Status: Ready for CI Test Assignee: Josh Cooper qa Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Josh Cooper Affects Version/s: PUP 4.2.0 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment One caveat, the proof of concept node terminus at https://github.com/puppetlabs/classifier/pull/350, relies on the master retrieving the agent's facts from its previous run and overriding the agent_specified_environment fact based on the configured_environment sent during the agent's current run. If the agent has never sent facts before, it will still do a double run. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment Changes look good, but isn't going to make 4.2.2 train. Retargeting for 4.3.0 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Josh Cooper Fix Version/s: PUP 4.2.2 Fix Version/s: PUP 4.3.0 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment Yes, all three; the intention is for set_by_config? to return true if set by anything other than the default. It looks like separating out :application_defaults and :overridden_defaults wasn't necessary. I may have done so to try to avoid unnecessary work. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment Michael Smith just to be super clear, what constitutes, "when an agent has explicitly requested a particular environment."? When set on the command line, when set in puppet.conf, when set programmatically, e.g. Puppet[:environment] = 'test'? In looking at the code, it looks like yes to all three, basically anything that sets puppet's :environment setting, except for :application_defaults and :overridden_defaults. The former is typically set via run_mode and so doesn't apply to :environment. The latter is used in setting hooks, e.g. when setting other properties, and currently only :storeconfigs uses it, so also doesn't apply. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Michael Smith Issue Type: Improvement Bug Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Michael Smith Release Notes Summary: When the configured_environment property was added to node and catalog communication, it was always set even when accepting the default. This was less useful than intended, as a node classifier may expect to know whether the agent explicitly requested that environment or is using the default. Change to only set the configured_environment property if an environment was explicitly requested on the agent, i.e. via puppet.conf or the command-line. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Steve Barlow Sprint: Client 2015-09-16 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Reid Vandewiele commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment +1 on a Notice indicating what environment is being run in generally. When it is appropriate to show a warning is closely related to the value of the agent_specified_environment fact. IF agent_specified_environment != nil AND server_specified_environment != agent_specified_environment THEN a warning should be shown. If agent_specified_environment is nil it's because the user didn't indicate an environment either in the puppet.conf or on the command line, so it's safe to assume that at least on the agent side the USER hasn't expressed any preference for one environment over another, so there's no point showing a warning. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Dan Welsh commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment Michael Smith Well put. I commented in https://tickets.puppetlabs.com/browse/PE-11655 along the same lines. The behind the scenes fix to increase efficiency and logic seems reasonable. But this should not come at the expense of informing the user that their intended action was successfully implemented. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith commented on PUP-5032 Re: Update node terminus configured_environment to mirror agent_specified_environment One concern that Dan Welsh raised is that the individual running puppet agent -t expects to see some indication of the environment they're running in. If they're used to running in a classifier, where it gives a message stating the environment the classifier has requested, than the absence of any message related to the environment might give the impression that they're request to use a particular environment was ignored. It seems reasonable to have an info message stating which environment is being used if no other messages convey that information. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Michael Smith Fix Version/s: PUP 4.2.2 Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith updated an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Change By: Michael Smith Puppet's communication with the node and catalog terminus included a configured_environment option in the last release. That option sometimes includes redundant or irrelevant information when Puppet[:environment] has the default setting. That redundant information precludes it from being used to identify when an agent has explicitly requested a particular environment.Change the behavior of configured_environment to only be set when the environment setting is explicitly set. This would technically be a breaking change in Puppet's node and catalog terminus behavior, but seeing as we have yet to document it I think it's a reasonable break. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5032) Update node terminus configured_environment to mirror agent_specified_environment
Title: Message Title Michael Smith created an issue Puppet / PUP-5032 Update node terminus configured_environment to mirror agent_specified_environment Issue Type: Improvement Assignee: Unassigned Created: 2015/08/12 3:14 PM Priority: Normal Reporter: Michael Smith Puppet's communication with the node and catalog terminus included a configured_environment option in the last release. That option sometimes includes redundant or irrelevant information when Puppet[:environment] has the default setting. That redundant information precludes it from being used to identify when an agent has explicitly requested a particular environment. Change the behavior of configured_environment to only be set when the environment setting is explicitly set. Add Comment
