Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Larissa Lane updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Larissa Lane Labels: i18n utf-8 windows Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Ethan Brown Release Notes Summary: Due to an underlying bug in the Ruby 2.1.x runtime, setting environment variables on Windows with Unicode characters that cannot be represented in the current local codepage could result in their corruption. Puppet now takes efforts to not use the problematic Ruby codepaths that can trigger this behavior, which were previously triggered any time an Exec resource was evaluated. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown commented on PUP-5768 Re: Fix problematic usage of ENV for Windows PUP-6035 captures some of the details we're interested in for running as a Unicode user. I will add details there for an alternate test for this particular scenario, given this ticket is closed. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Craig Gomes commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Agree with Ryan Gard on this one. From what I'm reading on this and having discussed with Glenn we've completed what was outlined in the ticket. The concerns listed within are edge cases and the remaining previously existing issues will get picked up with subsequent tickets. I'm in favor of moving this to done. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ryan Gard commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Ethan Brown Glenn Sarti Kenn Hussey I think this ticket is needs other components to make for a compelling FR case. I would suggest we move the ticket through as is since there is unit tests in place to cover these changes. From my manually testing thus far we have not made the situation any worse when dealing with Unicode users on Windows. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Kenn Hussey the FR failure cited above is likely caused by another issue (which might not be fixed in the build Ryan Gard used OR might be a separate issue). I don't expect that there will be additional code changes that land as a result of this ticket. I have pretty good confidence that our unit tests fix the issues in question, though we're going to need to come up with a different FR scenario that isn't blocked by other issues. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Ryan Gard The FR failure seems to duplicate that of FACT-1341 . I'm not sure where that leaves us as far as FR for this merge. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ryan Gard assigned an issue to Glenn Sarti Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Ryan Gard Assignee: Ryan Gard Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ryan Gard commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Functional Review Functional review failed with build 8e3267873a49a404c3a5121e45b350f7a8571d41 Environment Agent: Windows Server 2012 R2 (WIN_SUT) Test Case 1 Reproduction Steps Run Puppet from Unicode user account Install Puppet Agent test build on WIN_SUT. Create user "㔲㔳㔴㔵㔶" and join the user to the "Administrators" group on WIN_SUT. Logoff and logon as the "㔲㔳㔴㔵㔶" user on the WIN_SUT. Open a Puppet console and execute the following command: C:\>puppet --version Error: Could not initialize global default settings: Invalid argument @ dir_s_mk dir - C:/Users/? Expect Puppet should display the version number. Actual Puppet throws an unhandled exception: C:\>puppet --version
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ryan Gard commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Glenn Sarti here is the failure we were looking at earlier. Functional Review Functional review failed because of a bundler limitation running under a Unicode user account. Environment Agent: Windows Server 2012 R2 (WIN_SUT) Test Case 1 Reproduction Steps Run spec tests under Unicode user Install Ruby 2.1.8 on WIN_SUT. Install Ruby DevKit on WIN_SUT. Install Git on WIN_SUT. Open Git Bash console and clone the Puppet repo on the WIN_SUT. git clone https://github.com/puppetlabs/puppet.git Switch to the "stable" branch of Puppet repo. git checkout stable Create user "㔲㔳㔴㔵㔶" and join the user to the "Administrators" group on WIN_SUT. Logoff and logon as the "㔲㔳㔴㔵㔶" user on the WIN_SUT. Open console and navigate
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Builds at http://builds.puppetlabs.lan/puppet-agent/8e3267873a49a404c3a5121e45b350f7a8571d41/artifacts/windows/ Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Steve Barlow Sprint: Windows 2016-02-24 (Burn FF), Windows 2016-03-09 , Windows 2016-03-23 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown assigned an issue to Ryan Gard Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Ethan Brown Assignee: qa Ryan Gard Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Steve Barlow assigned an issue to qa Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Steve Barlow Status: Ready for CI Test Assignee: Ethan Brown qa Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Merged into stable at https://github.com/puppetlabs/puppet/commit/93ee117114c722ced7e4c65bc55c39fe9b271fb6 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Merged into master at https://github.com/puppetlabs/puppet/commit/dadd6e58a1f240d8bbcafe1751de2d0a93a5ece9 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Kenn Hussey Fix Version/s: PUP 4.4.1 Fix Version/s: PUP 4.4.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti assigned an issue to Ethan Brown Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Glenn Sarti Assignee: Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Ethan Brown Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti commented on PUP-5768 Re: Fix problematic usage of ENV for Windows Created specs for testing the bad behavior Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Glenn Sarti assigned an issue to Glenn Sarti Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Glenn Sarti Assignee: Ethan Brown Glenn Sarti Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Steve Barlow Sprint: Windows 2016-02-24 (Burn FF) , Windows 2016-03-09 (Burn CF) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Steve Barlow Fix Version/s: PUP 4.4.0 Fix Version/s: PUP 4.4.1 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ryan Gard updated an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Ryan Gard QA Risk Assessment: Medium QA Status: Reviewed QA Contact: Ryan Gard Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Craig Gomes assigned an issue to Ethan Brown Puppet / PUP-5768 Fix problematic usage of ENV for Windows Change By: Craig Gomes Assignee: Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown commented on PUP-5768 Re: Fix problematic usage of ENV for Windows There were some additional search hits inside of Ruby Facter 2.x where there is likely bad behavior as well. Probably not worth fixing at this point given these probably don't impact native Facter 3.x, but notes added for historical reasons: C:\source\puppet\.bundle\gems\ruby\2.1.0\gems\facter-2.4.4-x64-mingw32\lib\facter\path.rb: 10 Facter.add(:path) do 11setcode do 12: ENV['PATH'] 13end 14 end C:\source\puppet\.bundle\gems\ruby\2.1.0\gems\facter-2.4.4-x64-mingw32\lib\facter\core\execution\base.rb: 5 values.each do |var, value| 6# save the old value if it exists
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown created an issue Puppet / PUP-5768 Fix problematic usage of ENV for Windows Issue Type: Bug Assignee: Unassigned Created: 2016/01/28 2:50 PM Labels: windows Priority: Normal Reporter: Ethan Brown As part of PUP-5726, Windows API calls for retrieving / setting environment variables were added. This was done to work around a Ruby ENV bug https://bugs.ruby-lang.org/issues/8822 that corrupts UTF8 characters set in the environment (as keys or values) that don't map cleanly to the local codepage. While this was allegedly fixed in Ruby 2.3.0, it has not yet been backported or scheduled for backport. Therefore, the withenv helper was updated to not use Rubys ENV, and to instead use the API calls. However, there are a number of places where ENV is accessed and modified that may also trigger corruption issues. This ticket should cover: Finding other danger spots in the code - for instance access through ENV of PATH and HOME have risks of being problematic, but SYSTEMROOT, PATHEXT, windir and COMSPEC should be safe to ignore due to the low likelihood of these values containing Unicode characters. ENV usage inside tests can also generally be ignored, as problems running specs would likely only manifest on a non-English Windows install with a username that includes Unicode chars, that has a Unicode path as a home dir.
Jira (PUP-5768) Fix problematic usage of ENV for Windows
Title: Message Title Ethan Brown commented on PUP-5768 Re: Fix problematic usage of ENV for Windows It might be worth pushing on Ruby to backport the fix to 2.1.x Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
