Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-04-27 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

QA Status:
 
 Reviewed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-26 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Fix Version/s:
 
 PUP 4.3.3 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-24 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Behavior validated as defined in Francois Lafont's comment above using puppet-agent at bbb9b2a containing puppet at f6b27af on Ubuntu 14.04. 
 
 
 
 
 
 
# puppet apply -e "include 'test::foo'" 
 
 
 
 
Notice: Compiled catalog for ijsoajdeiiaq5q0.delivery.puppetlabs.net in environment production in 0.18 seconds 
 
 
 
 
Notice: param1: aaa, param2: [aaa, bbb] 
 
 
 
 
Notice: /Stage[main]/Test::Foo/Notify[Test]/message: defined 'message' as 'param1: aaa, param2: [aaa, bbb]' 
 
 
 
 
Notice: Applied catalog in 0.02 seconds 
 
 
 
 
  
 
 
 
 
# cat test/functions/data.pp 
 
 
 
 
function test::data { 
 
 
 
 
  { 
 
 
 
 
test::foo::param1 => 'aaa', 
 
   

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-24 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte assigned an issue to John Duarte 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

Assignee:
 
 qa John Duarte 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-23 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

QA Risk Assessment:
 
 Medium 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-22 Thread William Hopper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 William Hopper assigned an issue to qa 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 William Hopper 
 
 
 

Status:
 
 Ready for  CI  Test 
 
 
 

Assignee:
 
 qa 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-20 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 Hi, ORIGINAL REPORT  - All the files are in .zip attached file. I have a (very basic) module with the function {{data.pp}} as data provider and the default value of a parameter is {{undef}}:{code:puppet}function test::data {  {test::foo::param => undef,  }}{code}In the class {{::test::foo}}, I have this code:{code:puppet}class test::foo ( Optional[ String[1] ] $param ) { }{code}As you can see, the type of the parameter {{$param}} is an {{Optional}} which means that a {{undef}} value is accepted. However, if I test this code:{code:puppet}include '::test::foo'{code}I have an error:{code}~# puppet apply /puppet/modules/test/examples/example.pp Error: Evaluation Error: Error while evaluating a Function Call, Class[Test::Foo]: expects a value for parameter 'param' at /puppet/modules/test/examples/example.pp:1:1 on node puppet.athome.priv{code}It seems to me that it's not the expected behavior.Regards.PS: currently a possible and simple workaround is to set a {{undef}} default value in the declaration of the class like this:{code:puppet}class test::foo ( Optional[ String[1] ] $param = undef ) { }{code}but you have to set the {{undef}} value in two different places.UPDATEThis is fixed so that if an {{undef}} value is bound for a parameter key data binding will assign that {{undef}} to the parameter if the parameter does not have a default value _expression_. Earlier such a binding would have failed and required that the parameter had a default value _expression_ of {{= undef}} in order to make a lookup of {{undef}} possible. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
   

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-20 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 Hi,All the files are in .zip attached file. I have a (very basic) module with the function {{data.pp}} as data provider and the default value of a parameter is {{undef}}:{code:puppet}function test::data {  {test::foo::param => undef,  }}{code}In the class {{::test::foo}}, I have this code:{code:puppet}class test::foo ( Optional[ String[1] ] $param ) { }{code}As you can see, the type of the parameter {{$param}} is an {{Optional}} which means that a {{undef}} value is accepted. However, if I test this code:{code:puppet}include '::test::foo'{code}I have an error:{code}~# puppet apply /puppet/modules/test/examples/example.pp Error: Evaluation Error: Error while evaluating a Function Call, Class[Test::Foo]: expects a value for parameter 'param' at /puppet/modules/test/examples/example.pp:1:1 on node puppet.athome.priv{code}It seems to me that it's not the expected behavior.Regards.PS: currently a possible and simple workaround is to set a {{undef}} default value in the declaration of the class like this:{code:puppet}class test::foo ( Optional[ String[1] ] $param = undef ) { }{code}but you have to set the {{undef}} value in two different places. UPDATE  This is fixed so that if an {{undef}} value is bound for a parameter key data binding will assign that {{undef}} to the parameter if the parameter does not have a default value _expression_. Earlier such a binding would have failed and required that the parameter had a default value _expression_ of {{= undef}} in order to make a lookup of {{undef}} possible. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-20 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Component/s:
 
 DOCS 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Release Notes Summary:
 
 A small but annoying problem in data binding has been fixed, where if you defined a data key for a parameter to be nil (i.e. undef) and did not have a default _expression_ for the parameter that also specified undef (or some other value) an error would be raised. Now, if  nil/undef is bound as value in data, and there is no default _expression_, the value undef is assigned to the parameter instead of giving an error). 
 
 
 

Release Notes:
 
 Bug Fix 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Unassigned 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
and merged to master 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
merged to stable: 9319d1a 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren assigned an issue to Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Assignee:
 
 Thomas Hallgren Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Francois Lafont You do get special favours since you were an early adopter of the lookup features and using function style data binding . We should be thanking you finding real world problems. 
(Hint to others: you do get favours if you dare to live on the bleeding edge ) 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Ok, perfect. 
Thx guys for your precious and reactive help and good luck for the resolution of this little bug. 
Regards. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
yes - that is the expected behavior, 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Fix Version/s:
 
 PUP 4.4.0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Henrik Lindberg, sorry I wasn't clear. I will try to be precise here. I have this: 
 
 
 
 
 
 
class test::foo ( String[1] $param1, Array[ String[1] ] $param2 ) { ... }
 
 
 
 
 
 
 
And I have this in the functions/data.pp function: 
 
 
 
 
 
 
function test::data { 
 
 
 
 
  { 
 
 
 
 
test::foo::param1 => 'aaa', 
 
 
 
 
test::foo::param2 => [ 'aaa', 'bbb' ], 
 
 
 
 
  } 
 
 
 
 
}
 
 
 
 
 
 
 
So, with this simple puppet code: 
 
 
 
 
 
 
include '::test::foo'
 

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren There is a problem with changing the behavior of an undef result in data binding vs. not found due to the calling convention that "a given undef means use the default value". If you do this in puppet: 
 
 
 
 
 
 
class example($x = 'surprise') { } 
 
 
 
 
class {'example': x => undef }
 
 
 
 
 
 
 
The value of example::x is 'surprise'. IIRC, if $x does not have a default value _expression_, the result would be what data binding returned, or an error.  
This means that there is one case that needs fixing so that these statements are true: 
 

When data binding returns undef and parameter has no default value _expression_, the value of the parameter is set to undef.
 

When data binding returns undef and parameter has a default value _expression_, the value is set to the result of the default value _expression_.
 

If data binding has no value for the key, the default value _expression_ result is used
 

If neither data binding nor default value _expression_ has a value (including undef) then an error is raised.
 
 
With those rules there is one usage scenario that you cannot handle. Assume there are data bindings at lower priorities in the data bindings and you want to override this in a way that the manifests must provide the value (and cause an error if no value was given) - i.e. you want to do a binding that makes it look like there is no data bound at all for the given key. I think that case is highly specialised and such a rare corner case that it is worth sacrificing it for the far more useful "undef binding result is undef parameter value when parameter has no default value _expression_" since the later means you can skip the heavy handed declaration: 
 
 
 
 
 

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Francois Lafont I wonder what you mean by "default value provided by the 'data_provider'" - there is really no such concept; when merging all data providers in turn are asked for their opinion about what the value should be and the result is merged. The result of a default value _expression_ (i.e. for the parameter being looked up) should not be included in a merge. 
Can you elaborate what the problem was? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Ok, that's fine. In fact, it was very cruel. My metadata.json wasn't taken into account by puppet because I had a trailing comma here: 
 
 
 
 
 
 
$ cat modules/test/metadata.json  
 
 
 
 
{ 
 
 
 
 
  "name": "flaf-test", 
 
 
 
 
  "version": "0.1.0", 
 
 
 
 
  "author": "flaf", 
 
 
 
 
  "summary": "Module to make stupid tests", 
 
 
 
 
  "license": "Apache-2.0", 
 
 
 
 
  "source": "", 
 
 
 
 
  "project_page": null, 
 
 
 
 
  "issues_url": null, 
 
 
 
 
 

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Sorry, don't waste your time with my previous message. I think it's ok (I will give explanation in my next message). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Thanks for your answer Thomas. 
1. No, the doc is clear but I probably haven't read this part before today and I had just read tutorials where the data binding was declared via a default.rb. So thanks for this remark. 
2. So I have tried data binding declared in the metadata.json file but I have a problem. Sorry in advance if I have missed something stupid but here is my basic test (all is attached in the data-provider.zip file): 
 
 
 
 
 
 
$ tree modules/test/ 
 
 
 
 
modules/test/ 
 
 
 
 
|-- examples/ 
 
 
 
 
|   `-- example.pp 
 
 
 
 
|-- functions/ 
 
 
 
 
|   `-- data.pp 
 
 
 
 
|-- manifests/ 
 
 
 
 
|   `-- foo.pp 
 
 
 
 
`-- metadata.json 
 
 
 
 
  

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Francois Lafont 
 
 
 

Attachment:
 
 data-provider.zip 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Francois Lafont, while looking at the provided test case, I noticed that you declare a "default" binding for the data function using a default.rb file under lib/puppet/bindings/test. While that works, it's not the preferred way since this binding readily available by just adding this line to your metadata.json file: 
 
 
 
 
 
 
"data_provider": "function"
 
 
 
 
 
 
 
Is the documentation clear on this (it should be)? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Scope Change Category:
 
 Found 
 
 
 

Scope Change Reason:
 
 Fixed the issue while testing what's causing it. Might just as well submit a PR 
 
 
 

Story Points:
 
 1 
 
 
 

Sprint:
 
 Language 2016-02-24 (Burn FF) 
 
 
 

Fix Version/s:
 
 PUP 4.3.3 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are 

Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-19 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-5925 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
The actual lookup of the undef value works OK (returns undef as opposed to raising a not found error). The logic that manages how parameter bindings are assigned does however not treat undef as a valid value and changing it actually breaks a test with the inauspicious title "it should use the default value if the data_binding terminus returns nil". Probably an old relic that should be changed into "it should use the default value if no value is found using the data_binding terminus". 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-18 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren, I thought this should work. Any reason why it should not be allowed? - i.e. define data binding of undef 
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Scrum Team:
 
 Language 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-18 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5925) Optional data type and data binding with undef as default value

2016-02-18 Thread Francois Lafont (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Francois Lafont created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5925 
 
 
 
  Optional data type and data binding with undef as default value  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Attachments:
 

 test.zip 
 
 
 

Created:
 

 2016/02/18 4:58 PM 
 
 
 

Environment:
 
 
Ubuntu Trusty with puppet-agent 1.3.5 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Francois Lafont 
 
 
 
 
 
 
 
 
 
 
Hi, 
All the files are in .zip attached file. I have a (very basic) module with the function data.pp as data provider and the default value of a parameter is undef: 
 
 
 
 
 
 
function test::data { 
 
 
 
 
  {