Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Henrik Lindberg Release Notes Summary: With the new --strict flag in Puppet 4.5.0 you will now get warnings (or errors) when there is an attempt to set the same hash key more than once in the same hash. Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs Steve Barlow Thanks for the ping. Release note added. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Steve Barlow commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs Henrik Lindberg Thomas Hallgren Does this ticket need release notes info, or can I mark that as "not needed"? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Eric Thompson QA Highest Test Level: Unit QA Risk Assessment: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Eric Thompson commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs validated on ubuntu1404 at master puppet-agent SHA: f02899ae2ff66cea528d021ccdcd4adcf82b9ed root@y2lx40198bttgf3:~# puppet parser validate parse.pp Warning: The key 'key' is declared more than once at /root/parse.pp:4:13 root@y2lx40198bttgf3:~# puppet apply parse.pp Warning: The key 'key' is declared more than once at /root/parse.pp:4:13 Notice: Scope(Class[main]): some overriding value Notice: Compiled catalog for y2lx40198bttgf3.delivery.puppetlabs.net in environment production in 0.03 seconds Notice: Applied catalog in 0.87 seconds Add Comment
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Eric Thompson Assignee: qa Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Eric Thompson assigned an issue to qa Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Eric Thompson Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Thomas Hallgren commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs Merged to master at 92fa18e. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Thomas Hallgren Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Henrik Lindberg Sprint: Language Triage 2016-03-09 (Burn CF) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs PUP-5889 now has a PR that adds the --strict flag. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Henrik Lindberg Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Kylo Ginsberg commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs +1 on adding a --strict option and grouping this ticket under that umbrella. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Henrik Lindberg commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs I have an idea about adding a --strict option to puppet (separate ticket). You can set it to 'warning' 'error' or 'ignore'. We guarantee that we do not make things more strict in .z releases, but we may in an .y (users that used strict=error can then shift to strict=warning until they have fixed their issues). At major release boundary we make everything that is a "strict check" be standard. (Without this we end up with lots of different settings). There is a problem with warnings as well - someone may have the problem in a number of places. They may also have many nodes. This means that they will see the same warning lots of times. Thus when adding warnings, it is good to have a key that allows warnings to be suppressed. That led me down the path to instead doing a 'strict mode'. What I wanted to do with this ticket (and the --strict= ... one, and a few others) was to bring it up for discussion before we acted on them. That was the reason this ticket was floating around in Triage in a state other than "ready for engineering" and marked with a version. (There are 10-20 tickets similar to this one). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title
Thomas Hallgren updated an issue
Puppet / PUP-5937
Parser validator should warn about duplicate keys in hash constructs
Change By:
Thomas Hallgren
The keys in a hash construct are most often literals. As such, they can be validated during parsing so that the parser immediately complains about constructs like this:{code:puppet}$myhash = { key => "some value", other_key => "some other value", key => "some overriding value"}notice( $myhash[key] ){code}Presently, this is ignored and Puppet will notice 'some overriding value'. With a correct validation, it would instead yield an error issue a warning :{code}The key 'key' is declared more than once at /some/path/to/a.pp:3:17{code}
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Thomas Hallgren commented on PUP-5937 Re: Parser validator should warn about duplicate keys in hash constructs Yes, of course. It cannot error out on this. I changed the PR so that a warning is printed instead. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5937) Parser validator should warn about duplicate keys in hash constructs
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-5937 Parser validator should warn about duplicate keys in hash constructs Change By: Thomas Hallgren Summary: Parser validator should raise errors for warn about duplicate keys in hash constructs Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
