Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Steve Barlow Release Notes Summary: Should be documented as part of the experimental environment isolation feature Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title John Duarte commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Henrik Lindberg does this ticket need release notes, or is that covered elsewhere? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title John Duarte commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Thanks Thomas Hallgren. This passes validation given the criteria you have outlined on puppet-agent at SHA 5cb5a63. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Thomas Hallgren commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling I suggest that the test procedure is altered so that: 1. The module does not contain a .resource_types directory. 2. After the classification is made, and before the compile, a puppet generate types is executed (creates the .resource_types in the environment root). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Thomas Hallgren commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling This failing test assumes that the pcore type loader looks into the /.resource_types. The current implementation doesn't do that. It will only look at /.resource_types. The test does not fail if the directory is moved. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Note though that the expectations as written are using apply, in which case it is expected that the pcore type is used while compiling, and the ruby variant used when applying (since it has the logic to do the actual apply). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Thanks John Duarte. That can be codified in a unit test. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title
John Duarte commented on PUP-5949
Re: Update loaders to load pcore in place of ruby resource types when compiling
Thank you Thomas Hallgren for clarifying the pattern for using the pcore resource.
It appears that the ruby resource is still used when compiling the catalog. This is evidenced by the 'this is not the car you are looking for' being present in the compiled catalog.
Steps to reproduce
Install test module
See https://github.com/johnduarte/puppet-car This module contains the pcore resource as well as the ruby resource that can be instantiated with {car{"Lamborghini":}}. This module is installed in the production enviroment
Classify default to use resource
# cat /etc/puppetlabs/code/environments/production/manifests/site.pp
node default {
notice(car{"Lamborghini":})
}
Compile catalog
# puppet master --compile localhost.vm | grep 'not the car'
Warning: Host is missing hostname and/or domain: localhost.vm
"this is not the car you are looking for"
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Usage run: puppet generate --environment myenv The generated resource types are placed in env's .resource_types directory. Then run puppet master compile. Manual verification of ruby resource type not loaded could be to make it not load (deliberate error inserted say). Run master compile again. (Should work). Drop the .resource_types dir, now master compile breaks (on inserted error). Or something similar. henrik Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title
Thomas Hallgren commented on PUP-5949
Re: Update loaders to load pcore in place of ruby resource types when compiling
John Duarte, I can see some problems with your example.
1. The folder containing the pp resource should be named .resource_types, i.e. it must start with a dot. 2. Each file within this directory must define a Puppet::Resource::ResourceType3 with a name that matches the file name.
Try putting something like this in .resource_types/car.pp
Puppet::Resource::ResourceType3('car',
[], # no properties
[Puppet::Resource::Param(String, 'name', true)]
)
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title John Duarte commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Henrik Lindberg I do not understand the mechanics of how to lay down the custom pcore resource in order for it to get seen by puppet. I have created a test module with a regular custom type for 'car' and copy/pasta'd your 'car' pcore example in a 'resource_types' directory in the root of the module. This appears to be incorrect, because the 'pcore' code is not discovered when trying to instantiate a 'car' resource. My test module is here: https://github.com/johnduarte/puppet-car Errors when attempting to instantiate 'car': root@e8ibs8b1t5zf2bi:~# puppet apply -e "Things::Vehicles()" Error: Evaluation Error: Resource type not found: Things::Vehicles at line 1:1 on node e8ibs8b1t5zf2bi.delivery.puppetlabs.net root@e8ibs8b1t5zf2bi:~# puppet apply -e "Things::Vehicles::Car()" Error: Evaluation Error: Resource type not found: Things::Vehicles::Car at line 1:1 on node e8ibs8b1t5zf2bi.delivery.puppetlabs.net root@e8ibs8b1t5zf2bi:~# puppet apply -e "Car()" "this is not the car you are looking for" Error: Evaluation Error: Error while evaluating a Function Call, Creation of new instance of type 'Car' is not supported at line 1:1 on node e8ibs8b1t5zf2bi.delivery.puppetlabs.net
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title John Duarte assigned an issue to John Duarte Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: John Duarte Assignee: qa John Duarte Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title John Duarte updated an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: John Duarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title John Duarte updated an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: John Duarte QA Risk Assessment: High Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Steve Barlow Sprint: Language 2016-07-27 , Language 2016-08-10 (3rd 1.6.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling The merged PR caused PE installer to fail, worked when this PR reverted from contribution. See PUP-6558. It fails with a "cannot find resource" which looks like it could be a user defined type (since it is has a compound name). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Sean Griffin assigned an issue to qa Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Sean Griffin Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg commented on PUP-5949 Re: Update loaders to load pcore in place of ruby resource types when compiling Merged to master at: bafca0b Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Henrik Lindberg Acceptance Criteria: If a file is found under /.resource_types with the name of a resource type the following should happen:* A Ruby based Puppet::Type Class with the same name must not be loaded into the Ruby Runtime* A Pcore based implementation should instead be used* The catalog should have the exact same content as if the Ruby Puppet::Type implementation was used.* The requirement that Puppet::Type implementation must not be loaded is relaxed for the resource types built into Puppet (as some of them are loaded during the settings apply phase). It is allowed to also have a Pcore representation of those types for testing purposes. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Henrik Lindberg Scope Change Reason: next on env isolation work Story Points: 2 Sprint: Language 2016-07-27 Fix Version/s: PUP 4.6.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Change By: Henrik Lindberg Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5949) Update loaders to load pcore in place of ruby resource types when compiling
Title: Message Title Henrik Lindberg created an issue Puppet / PUP-5949 Update loaders to load pcore in place of ruby resource types when compiling Issue Type: New Feature Assignee: Unassigned Created: 2016/02/20 9:30 PM Priority: Normal Reporter: Henrik Lindberg When loading types, the pcore representation should have higher priority. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
