Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Sub-team: Language Story Points: 1 Team: Puppet Developer Experience Platform Core Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6274
include undef doesn't fail
Change By:
Henrik Lindberg
Release Notes Summary:
Attempt to use an empty string or undef as the name of a class when calling {{include}} will now raise an error instead of appearing to be silently ignored.
Release Notes:
Bug Fix
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Fix Version/s: PUP 5.4.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Component/s: Functions Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg commented on PUP-6274 Re: include undef doesn't fail The include function should be moved to 4.x function API for other reasons - and this can then be done as well. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Component/s: Language Component/s: Compiler Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Labels: low-hanging-fruit triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6274 include undef doesn't fail Change By: Henrik Lindberg Labels: low-hanging-fruit Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6274
include undef doesn't fail
I lowered the priority since it is actually doing what it is asked to do "include top scope" and it is more surprising than harmful.
With proper typing and code/data hygiene (--strict_variables) one should never end up in a situation where an include undef is evaluated.
If someone wants to spend time adding an error message / test to the include function for undef check, a PR would be welcome. Otherwise I think we are better off spending time cleaning up the parts of the compiler / 3.x that we left behind.
Change By:
Henrik Lindberg
Acceptance Criteria:
That {{include undef}} raises an error
Story Points:
1
Priority:
Normal Minor
Scrum Team:
Language
Add Comment
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Henrik Lindberg commented on PUP-6274 Re: include undef doesn't fail This is a real WAT caused by a series of tech debt amazeballs design decisions: The include function is a 3.x function The 3.x function API requires that undef as a puppet language value given directly to the function should be passed as an empty string (rather than the other two encodings in use for 3.x (Ruby symbol :undef or (what 4.x uses) Ruby nil). The name of the resource of type 'class' that is know as 'main' is internally named - (drumroll) - you guessed it, it's '' (empty string) There is always a class named '' (a.k.a 'main') No wonder include undef works since class 'main' is always included. We have not dared cleaning this up yet (which would entail rewriting the include function as a 4.x function and not accepting an include of undef, and that the class '' (while internally it may be called that, should really be referred to via 'main'). This is tricky though since it sort of also represents "top scope". A simpler change would be to simply error (in the 3.x implementation) on include of empty string - since it is nonsensical to include 'main' (it is always there). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Jira (PUP-6274) include undef doesn't fail
Title: Message Title
Daniel Parks updated an issue
Puppet / PUP-6274
include undef doesn't fail
Change By:
Daniel Parks
{code}❯ puppet apply -e "include undef"Notice: Compiled catalog for zhora.local in environment production in 0.04 secondsNotice: Applied catalog in 0.03 seconds{code}Expected results: compilation failureSimilarly, {{include ''}} doesn't fail, though {{include nosuchclass}} does.Example scenario: {{include $::some::class::tyypo}} (in my case, I accidentally grabbed the dollar sign while copying and pasting)
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title
Daniel Parks updated an issue
Puppet / PUP-6274
include undef doesn't fail
Change By:
Daniel Parks
{code}❯ puppet apply -e "include undef"Notice: Compiled catalog for zhora.local in environment production in 0.04 secondsNotice: Applied catalog in 0.03 seconds{code}Expected results: compilation failureSimilarly, {{include ''}} doesn't fail, though {{include nosuchclass}} does. Failure on undef would be particularly valuable when including a variable (especially accidently). Example scenario: {{include $::some::class::tyypo}}
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6274) include undef doesn't fail
Title: Message Title Daniel Parks created an issue Puppet / PUP-6274 include undef doesn't fail Issue Type: Bug Affects Versions: PUP 4.4.2 Assignee: Unassigned Created: 2016/05/06 2:18 PM Priority: Normal Reporter: Daniel Parks ❯ puppet apply -e "include undef" Notice: Compiled catalog for zhora.local in environment production in 0.04 seconds Notice: Applied catalog in 0.03 seconds
