Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Steve Barlow updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
Steve Barlow
Fix Version/s:
PUP 4.6.0
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
Release Notes Summary:
This fixes a bug in the OSX launchd service provider that caused puppet to crash if an invalid file existed in the Launch directory.Now, puppet will detect the invalid file, emit a warning, skip the file, and continue.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
Release Notes:
Bug Fix
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Validated using pre-release version of puppet-agent at SHA 88eaa08 containing puppet at SHA e535db0 on OSX 10.11.
Puppet no longer crashes, but emits a warning that the invalid file is being skipped.
xadbo9lsh0eh1ek:~ root# touch /Library/LaunchDaemons/foo
xadbo9lsh0eh1ek:~ root# puppet resource service
Warning: Cannot read file /Library/LaunchDaemons/foo; Puppet is skipping it.
Details: Execution of '/usr/bin/plutil -convert xml1 -o /dev/stdout /Library/LaunchDaemons/foo' returned 1: /Library/LaunchDaemons/foo: Property List error: Cannot parse a NULL or zero-length data / JSON error: No value.
service { 'com.apple.AEServer':
ensure => 'stopped',
enable => 'false',
}
...
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
QA Risk Assessment Reason:
Unlikely to regress
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
QA Risk Assessment:
Medium
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
QA Status:
Reviewed
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte assigned an issue to John Duarte
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
Assignee:
qa John Duarte
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
John Duarte assigned an issue to qa
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
John Duarte
Status:
Ready for CI Test
Assignee:
qa
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Branan Riley updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
Branan Riley
Story Points:
0
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Branan Riley updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
Branan Riley
Sprint:
Client 2016-06-29 (failover)
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
Henrik Lindberg
Scrum Team:
Client Platform
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Henrik Lindberg commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
ping Kylo Ginsberg
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Clay Caviness commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
https://github.com/puppetlabs/puppet/pull/5022
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Clay Caviness commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Also, this is probably more an issue with Puppet::Util::Plist that the launchd service provider.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Clay Caviness commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
I have a local patch that should fix this; let me do a bit more testing (and actually write some unit tests) to verify.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Clay Caviness updated an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Change By:
Clay Caviness
If a zero-length file exists in the standard locations for OS X LaunchAgent or LaunchDaemons exist, puppet will exit with an error:{code}# touch /Library/LaunchDaemons/foo# puppet resource serviceError: Could not run: undefined method `elements' for nil:NilClass{code}Not only does this cause {{puppet resource}} to fail, but {{puppet apply}} as well, causing failures.I discovered this by adding some logging to {{provider/service/launchd.plist}}, and saw the failure was when trying to read {{/Library/LaunchDaemons/.plist.puppettmp_9913}}, so it appears an interrupted puppet run left the {{.puppettmp_9913}} file, which then caused future runs to fail.Puppet 3 is not affected, so this is a regression of sorts. It appears there's an unhandled exception down in {{ cfpropertlylist cfpropertylist }}:{code}$ sudo /Library/GoogleCorpSupport/bin/puppet resource --trace serviceError: Could not run: undefined method `elements' for nil:NilClass/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/cfpropertylist/rbREXMLParser.rb:22:in `load'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/cfpropertylist/rbCFPropertyList.rb:312:in `load_str'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/cfpropertylist/rbCFPropertyList.rb:248:in `initialize'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/util/plist.rb:83:in `new'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/util/plist.rb:83:in `new_cfpropertylist'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/util/plist.rb:62:in `parse_plist'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/util/plist.rb:39:in `read_plist_file'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:196:in `read_plist'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:138:in `block (2 levels) in make_label_to_path_map'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:137:in `each'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:137:in `block in make_label_to_path_map'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:136:in `each'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:136:in `make_label_to_path_map'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:157:in `jobsearch'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/provider/service/launchd.rb:106:in `instances'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/type.rb:1162:in `block in instances'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/type.rb:1155:in `collect'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/type.rb:1155:in `instances'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/indirector/resource/ral.rb:24:in `search'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/indirector/indirection.rb:269:in `search'/Library/GoogleCorpSupport/Ruby/lib/ruby/site_ruby/puppet/application/resource.rb:225:in
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Samuel Keeley commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
It's not just zero length files, this happens with any random file you drop into /Library/LaunchDaemons.
I believe that this just needs to rescue an additional exception here https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/plist.rb#L63.
Allister Banks that is Puppet skipping the use of the data which has already been successfully read from the plist. This happens before that; the plist is never successfully read as CFPropertyList errors.
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Allister Banks commented on PUP-6410
Re: launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Reproduced on 1.4.2 version of the agent install, 2016.1.2. Odd that it can skip/allow a plist missing a 'label' key, as per: {{bash-3.2# defaults write /Library/LaunchDaemons/foo foo -bool True bash-3.2# puppet agent -t Info: Using configured environment 'darwinCanary' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for odmit17.montefiore.org Info: Applying configuration version '1466007674' Warning: The /Library/LaunchDaemons/foo.plist plist does not contain a 'label' key; Puppet is skipping it}}
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6410) launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Title: Message Title
Clay Caviness created an issue
Puppet / PUP-6410
launchd service provider crashes if a zero-length file in the {System,}/Library/Launch{Daemon,Agent} directory exists
Issue Type:
Bug
Affects Versions:
PUP 4.4.1
Assignee:
Unassigned
Created:
2016/06/15 9:42 AM
Priority:
Normal
Reporter:
Clay Caviness
If a zero-length file exists in the standard locations for OS X LaunchAgent or LaunchDaemons exist, puppet will exit with an error:
# touch /Library/LaunchDaemons/foo
# puppet resource service
Error: Could not run: undefined method `elements' for nil:NilClass
