Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-08-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6431 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 
 
Is this ticket in the correct state - there seems to be code that has been merged. Ping Eric Thompson and Sean Griffin 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-07-05 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson commented on  PUP-6431 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 
 
this... might be a feature. testing works around this by specifying is_tty to beaker #on DSL method options. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-06-22 Thread Sean Griffin (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Sean Griffin commented on  PUP-6431 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 
 
Replacing these lines: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/face/parser.rb#L39-#L48 with: 
 
 
 
 
 
 
  if files.empty? 
 
 
 
 
manifest = Puppet.lookup(:current_environment).manifest 
 
 
 
 
files << manifest 
 
 
 
 
Puppet.notice "No manifest specified. Validating the default manifest #{manifest}" 
 
 
 
 
  end
 
 
 
 
 
 
 
fixes the problem with 'on(agent, "puppet parser validate")' but breaks 'cat site.pp | puppet parser validate' 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA 

Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-06-22 Thread Sean Griffin (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Sean Griffin commented on  PUP-6431 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 
 
The problem is here: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/face/parser.rb#L39-#L48 
When 'puppet parser validate' is called from the command line, STDIN.tty? is true. Parser-validate looks up a default manifest file name and parse-checks the puppet code in that file. If you do it through ssh (or on()), STDIN.tty? is false. In that case parser-validate expects the text to validate to come from stdin, not a file. It is waiting for more input terminated by control-D.  
 
 
 
 
 
 
PuppetLabs382:01-160622 sgriffin$ ssh root@jtkosna3g7bbax2 puppet parser validate 
 
 
 
 
file { '/tmp/foo' : 
 
 
 
 
ensure => file, 
 
 
 
 
content => "bar", 
 
 
 
 
mode => "0644", 
 
 
 
 
} 
 
 
 
 
PuppetLabs382:01-160622 sgriffin$ echo $? 
 
 
 
 
0 
 
 
 
 
PuppetLabs382:01-160622 sgriffin$ ssh root@jtkosna3g7bbax2 puppet parser validate 
 
 

Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-06-22 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6431 
 
 
 
  puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 
 
 
 
 
 
 
 {code}#works when you specify a manifest:$) ssh root@somehost 'puppet parser --debug validate /tmp/parser_validate.r7iozi/parser_validate_exported.pp'Debug: Runtime environment: puppet_version=4.5.3, ruby_version=2.1.9, run_mode=user, default_encoding=UTF-8$) echo $?0# but not without a manifest (should go to default manifest, as when run on-host):$ ssh root@somehost 'puppet parser --debug validate'Debug: Runtime environment: puppet_version=4.5.3, ruby_version=2.1.9, run_mode=user, default_encoding=UTF-8#stalls here for... a long time{code}on the remote machine:{code}root@somehost:~# ps aux | grep [p]uppetroot  6093  5.5  1.3 179964 53620 ?Ssl  14:50   0:00 /opt/puppetlabs/puppet/bin/ruby /opt/puppetlabs/bin/puppet parser --debug validate{code}if you kill the process on the machine, ssh will returnif you run the command on the machine, it works as expected.this also does not work using beaker's on() as it sends its commands over SSHOSX runner here, SSHing to both rhel7 and ubuntu1404 this ticket should also fix puppet parser's test:https://github.com/puppetlabs/puppet/blob/5e16ae3f5d684c7c64b3737dd8b5d1c1e9912f11/acceptance/tests/face/parser_validate.rb#L24 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from 

Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-06-22 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6431 
 
 
 
  puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

Acceptance Criteria:
 
 * `puppet parser validate` validates the default manifest when run over SSH* its test also tests default manifests (https://github.com/puppetlabs/puppet/blob/5e16ae3f5d684c7c64b3737dd8b5d1c1e9912f11/acceptance/tests/face/parser_validate.rb#L24) 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6431) puppet parser validate stalls when run over SSH with no manifest specified

2016-06-22 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6431 
 
 
 
  puppet parser validate stalls when run over SSH with no manifest specified  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/06/22 2:55 PM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Eric Thompson 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
#works when you specify a manifest: 
 
 
 
 
$) ssh root@somehost 'puppet parser --debug validate /tmp/parser_validate.r7iozi/parser_validate_exported.pp' 
 
 
 
 
Debug: Runtime environment: puppet_version=4.5.3, ruby_version=2.1.9, run_mode=user, default_encoding=UTF-8 
 
 
 
 
$) echo $?